From owner-freebsd-bugs@freebsd.org Tue Oct 23 09:24:08 2018 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9A93310726C1 for ; Tue, 23 Oct 2018 09:24:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 2B0E1725D0 for ; Tue, 23 Oct 2018 09:24:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id E4BB110726BB; Tue, 23 Oct 2018 09:24:07 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C339C10726BA for ; Tue, 23 Oct 2018 09:24:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 64B78725CD for ; Tue, 23 Oct 2018 09:24:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id B475B13937 for ; Tue, 23 Oct 2018 09:24:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w9N9O64T011467 for ; Tue, 23 Oct 2018 09:24:06 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w9N9O6J2011458 for bugs@FreeBSD.org; Tue, 23 Oct 2018 09:24:06 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 232555] local_unbound fails to start if root.key is empty. Date: Tue, 23 Oct 2018 09:24:06 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: ari@stonepile.fi X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Oct 2018 09:24:08 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D232555 Bug ID: 232555 Summary: local_unbound fails to start if root.key is empty. Product: Base System Version: 11.1-RELEASE Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: ari@stonepile.fi Created attachment 198487 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D198487&action= =3Dedit Patch for /etc/rc.d/local_unbound It seems to be possible that local_unbound gets into state where /var/unbound/root.key exists but is empty as a result of unclean shutdown. The command that regenerates the file is unbound-anchor, which rebuilds it = if it doesn't exist or it is empty (stated in man page). However, /etc/rc.d/local_unbound doesn't invoke it if root.key exists, even as zero-length file. This results in situation where the local_unbound service no longer starts,= it is also unable to recover from such condition automatically. This leaves the machine without working DNS service: Oct 23 09:08:39 local-unbound-test unbound: [947:0] notice: init module 0: validator Oct 23 09:08:39 local-unbound-test unbound: [947:0] error: failed to read /root.key Oct 23 09:08:39 local-unbound-test unbound: [947:0] error: error reading auto-trust-anchor-file: /var/unbound/root.key Oct 23 09:08:39 local-unbound-test unbound: [947:0] error: validator: error= in trustanchors config Oct 23 09:08:39 local-unbound-test unbound: [947:0] error: validator: could= not apply configuration settings. Oct 23 09:08:39 local-unbound-test unbound: [947:0] error: module init for module validator failed Oct 23 09:08:39 local-unbound-test unbound: [947:0] fatal error: failed to setup modules Simple fix to solution would be the change the rc.d script so that it has s= ame logic as unbound-anchor, ie. run it if the file does not exist OR it is emp= ty. Patch attached. --=20 You are receiving this mail because: You are the assignee for the bug.=