Date: Fri, 14 Apr 2023 15:22:24 GMT From: Mikhail Pchelin <misha@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 2f53b5991ce0 - main - net80211: fix a typo in Rx MCS set for unequal modulation case Message-ID: <202304141522.33EFMObi021590@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by misha: URL: https://cgit.FreeBSD.org/src/commit/?id=2f53b5991ce05b7e6f2b1eb826cd902fb255a9eb commit 2f53b5991ce05b7e6f2b1eb826cd902fb255a9eb Author: Mikhail Pchelin <misha@FreeBSD.org> AuthorDate: 2023-04-14 15:20:09 +0000 Commit: Mikhail Pchelin <misha@FreeBSD.org> CommitDate: 2023-04-14 15:20:09 +0000 net80211: fix a typo in Rx MCS set for unequal modulation case RX MCS set defines which MCSs are supported for RX, bits 0-31 are for equal modulation of the streams, bits 33-76 are for unequal case. Current code checks txstreams variable instead of rxstreams to set bits from 53 to 76 for 4 spatial streams case. The modulations are defined in tables 19-38 and 19-41 of the IEEE Std 802.11-2020. Spotted by bz in https://reviews.freebsd.org/D39476 Reviewed by: bz Approved by: bz Sponsored by: Serenity Cybersecurity, LLC Differential Revision: https://reviews.freebsd.org/D39568 --- sys/net80211/ieee80211_ht.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/net80211/ieee80211_ht.c b/sys/net80211/ieee80211_ht.c index f98316bc5088..2bdbc101d861 100644 --- a/sys/net80211/ieee80211_ht.c +++ b/sys/net80211/ieee80211_ht.c @@ -3203,7 +3203,7 @@ ieee80211_set_mcsset(struct ieee80211com *ic, uint8_t *frm) for (i = 39; i <= 52; i++) setbit(frm, i); } - if (ic->ic_txstream >= 4) { + if (ic->ic_rxstream >= 4) { for (i = 53; i <= 76; i++) setbit(frm, i); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202304141522.33EFMObi021590>