From owner-freebsd-ports@FreeBSD.ORG Sun Apr 18 05:55:43 2010 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4578B1065670 for ; Sun, 18 Apr 2010 05:55:43 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx23.fluidhosting.com [204.14.89.6]) by mx1.freebsd.org (Postfix) with ESMTP id CC6648FC13 for ; Sun, 18 Apr 2010 05:55:42 +0000 (UTC) Received: (qmail 1858 invoked by uid 399); 18 Apr 2010 05:55:40 -0000 Received: from localhost (HELO ?192.168.0.145?) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 18 Apr 2010 05:55:40 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Date: Sat, 17 Apr 2010 22:55:39 -0700 (PDT) From: Doug Barton To: obrien@freebsd.org In-Reply-To: <4BC6BD7B.4040904@FreeBSD.org> Message-ID: References: <20100412222300.GA72952@dragon.NUXI.org> <4BC6BD7B.4040904@FreeBSD.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) X-message-flag: Outlook -- Not just for spreading viruses anymore! X-OpenPGP-Key-ID: 0xD5B2F0FB Organization: http://SupersetSolutions.com/ OpenPGP: id=1A1ABC84 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: ports@freebsd.org Subject: Re: [PATCH] upgrade Bash port to version 4.1. X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Apr 2010 05:55:43 -0000 On Thu, 15 Apr 2010, Doug Barton wrote: > On 04/12/10 15:23, David O'Brien wrote: >> Hi Folks, >> >> Bash 4.1 seems stable enough at PL5 to replace version 4.0 in >> '/usr/ports/shells/bash'. > > Agreed, I tested the PL5 with your patch and it seems fine. > > Please consider the attached patch as well, that adds OPTIONS generally > for the knobs already in the port, and a new option to use bash's > readline instead of the base version. Sorry, there was a logic error in the readline bit. Turns out if you actually try to use that configure option then compilation fails. Also, in spite of the --enable-static-link option the resultant binary is dynamically linked. I checked both a port build and building it by hand, same result. The current shells/bash (4.0) does not have this problem. Doug -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/ Computers are useless. They can only give you answers. -- Pablo Picasso