From owner-svn-src-all@freebsd.org Wed May 18 15:11:57 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2EC37B418A2 for ; Wed, 18 May 2016 15:11:57 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm22-vm1.bullet.mail.bf1.yahoo.com (nm22-vm1.bullet.mail.bf1.yahoo.com [98.139.212.127]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DB46110DB for ; Wed, 18 May 2016 15:11:56 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1463584309; bh=r9OxHjBieOzUw5Iq/mqugiBB1mRokMn1TEI6K3zxlZw=; h=From:Subject:To:References:Cc:Date:In-Reply-To:From:Subject; b=DLhTi8yC50Ut1o5CV+yrahdJqVI7Bq969U2VW2rMtBIdsZ+jo4h/GO3xMDX0Avk8vCkn3yAkjHcTWWQTk5osviRddeoL3q4EV7z+fOdDza44NTXKGLuC2l7ZV9W2vnqAeP9Yt1c9pudT35erm+Zr2D6bASUYk7q3188AwJke1muYWgFjgUxDBtGZZ6ir9+tNx6S5y+v7yTBqsgX7j+/3y9fPV+kLntcD7d/cRhw+YrwfzZ2ZXJXlX0f1O7gbvwYb8SNhJZU8ciHMGypBub/r9lJZjcZrfJ8jgMc4vnhdj4OtSMS3qve6w8pVaOSDzM0JGPwx08Mg6rpH7jJ1i3+YNQ== Received: from [66.196.81.172] by nm22.bullet.mail.bf1.yahoo.com with NNFMP; 18 May 2016 15:11:49 -0000 Received: from [98.139.211.202] by tm18.bullet.mail.bf1.yahoo.com with NNFMP; 18 May 2016 15:11:49 -0000 Received: from [127.0.0.1] by smtp211.mail.bf1.yahoo.com with NNFMP; 18 May 2016 15:11:49 -0000 X-Yahoo-Newman-Id: 470578.99196.bm@smtp211.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: jRmZ7qIVM1mxBEVVB3Jt_m1GFuQJW99T0F4R0vsNAuKareI NgiQQxFRwRxJHRwnrnKF31EZJkQZTGVbtAxgSOJFgeLA2ikEz3Px15Ap2un1 qVjUhZm_ebC5m_Tc4MoCYn1sXi2o93JUf3QutUfoG1K9GCzd1kPWKv.TqxSE s8uF5cvRXE1YudLlUeq8bH8CNNH6317Gh8Jl_Xt1i6dcYyxA0XnFNybUSaJi D6zKu_5wwfzoUvjZj5n93KtbchrYYbYmHhgSfAeMlRPdgUFXrxmVRXXdpC8U rYoMEiUpq7wBIMiq8wxfjyT0iJb6T7Fy2zsLyvcB0xOn1_Mdn8.THeIFc9yB obE.IEt7JhiSCiR0GAUKiyj136wB59kisY.t8mBWB2tfXevv8GY7zVySb1._ 5UrNT12k1UbHiyqTuQlT9.Q5ItKbJKhfKRkXDnNyh4oEhrR4E5CGU_XcPgwt .oA8AS5BgiVbYTWQUiFNVL0ztOpI67GclOdOrZwfj6XciMzH23sujhu8pEhe oBBK8yC6qjve1EdKlZnPmtSosSEt7qply X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf From: Pedro Giffuni Subject: Re: svn commit: r300098 - head/usr.sbin/makefs To: Ed Maste References: <201605180022.u4I0MqSU048808@repo.freebsd.org> Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-ID: <88775237-2a05-4c6f-5c15-0b7a19ce6d46@FreeBSD.org> Date: Wed, 18 May 2016 10:11:58 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 May 2016 15:11:57 -0000 On 05/17/16 20:12, Ed Maste wrote: > On 18 May 2016 at 00:22, Pedro F. Giffuni wrote: >> Author: pfg >> Date: Wed May 18 00:22:52 2016 >> New Revision: 300098 >> URL: https://svnweb.freebsd.org/changeset/base/300098 >> >> Log: >> makefs(8): Clarify the comment concerning seeding. >> >> Avoid giving the impression makefs currently supports reproduceable >> builds. > > Thanks! > > It might make sense to seed based on SOURCE_DATE_EPOCH > (https://reproducible-builds.org/specs/source-date-epoch/) if set, and > later on we ought to add an option to set the seed on the command > line. > Interesting. FWIW, NetBSD did some other changes but they basically removed the seeding which may be mildly dangerous in this case (makefs uses random() in other places without seeding). > But, there are a lot of other reproducible build tasks that are > probably more important to tackle before this. > Yes, I am not really very interested in reproducible builds but this is one of the cases where we cannot go blindly replacing random() with arc4random(). Pedro.