From owner-freebsd-current@FreeBSD.ORG Fri Sep 24 19:35:20 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8241C16A4CE for ; Fri, 24 Sep 2004 19:35:20 +0000 (GMT) Received: from mail3.speakeasy.net (mail3.speakeasy.net [216.254.0.203]) by mx1.FreeBSD.org (Postfix) with ESMTP id 29F3143D45 for ; Fri, 24 Sep 2004 19:35:20 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 32505 invoked from network); 24 Sep 2004 19:35:19 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 24 Sep 2004 19:35:19 -0000 Received: from [10.50.40.210] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i8OJZF7P020002; Fri, 24 Sep 2004 15:35:16 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: freebsd-current@FreeBSD.org Date: Fri, 24 Sep 2004 15:35:37 -0400 User-Agent: KMail/1.6.2 References: <20040924191225.32854.qmail@web14824.mail.yahoo.com> In-Reply-To: <20040924191225.32854.qmail@web14824.mail.yahoo.com> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200409241535.37511.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: Warner Losh cc: Rostislav Krasny cc: phk@FreeBSD.org Subject: Re: interesting bug of new fdc(4) - two /dev/fd0 device files X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Sep 2004 19:35:20 -0000 On Friday 24 September 2004 03:12 pm, Rostislav Krasny wrote: > I have FreeBSD 5.3-BETA5 and 5.3-BETA4 installed on separate disks of > the same computer. After the installation I added a second floppy drive > (disk B in DOS). See following logs about how both systems work after > that: > > dmesg and shell logs of 5.3-BETA5 (two /dev/fd0 device files): > > PNP0700: adding dma mask 0x4 > PNP0700: adding io range 0x3f2-0x3f5, size=0x4, align=0 > PNP0700: adding irq mask 0x40 > pnpbios: handle 12 device ID PNP0700 (0007d041) > [snipped] > fdc0: ic_type 90 part_id 80 > fdc0: at port 0x3f0-0x3f5 irq 6 drq 2 on > isa0 > fdc0: ic_type 90 part_id 80 > fdc0: [MPSAFE] > fdc0: [FAST] > fd0: <1440-KB 3.5" drive> on fdc0 drive 0 > fd1: <1440-KB 3.5" drive> on fdc0 drive 1 > > > ls -il /dev/fd[0-9] > > 73 crw-r----- 1 root operator 4, 10 Sep 24 20:21 /dev/fd0 > 73 crw-r----- 1 root operator 4, 10 Sep 24 20:21 /dev/fd0 > > > dmesg and shell logs of 5.3-BETA4 (no such bug): > > PNP0700: adding dma mask 0x4 > PNP0700: adding io range 0x3f2-0x3f5, size=0x4, align=0 > PNP0700: adding irq mask 0x40 > pnpbios: handle 12 device ID PNP0700 (0007d041) > [snipped] > fdc0: at port > 0x3f7,0x3f > 0-0x3f5 irq 6 drq 2 on isa0 > fdc0: FIFO enabled, 8 bytes threshold > fd0: <1440-KB 3.5" drive> on fdc0 drive 0 > fd1: <1440-KB 3.5" drive> on fdc0 drive 1 > > > ls -il /dev/fd[0-9] > > 32 crw-r----- 1 root operator 242, 0 Sep 24 19:05 /dev/fd0 > 34 crw-r----- 1 root operator 242, 1 Sep 24 19:05 /dev/fd1 > > > P.S. having two floppy drives became rare at our days but this is still > possible and correct to be used by anyone. Looks like a bug in fd2_attach(): fd->fd_geom = g_new_geomf(&g_fd_class, "fd%d", device_get_unit(fd->fdc->fdc_dev)); Try changing that line in sys/dev/fdc/fdc.c (about line 1909) to use fd->fd_dev rather than fd->fdc->fdc_dev. Or, alternatively, change the two lines to: fd->fd_geom = g_new_geomf(&g_fd_class, "%s", device_get_nameunit(fd)); -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org