From nobody Mon Jul 10 18:26:01 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4R0CBH71Vzz4ghR0 for ; Mon, 10 Jul 2023 18:26:15 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4R0CBG65rJz3wys for ; Mon, 10 Jul 2023 18:26:14 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-4fb7dc16ff0so7259452e87.2 for ; Mon, 10 Jul 2023 11:26:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20221208.gappssmtp.com; s=20221208; t=1689013572; x=1691605572; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=hbCmgSFZ0xzd+1UOHNxqTHihT/u3OV2d4MwpsMAW+gs=; b=HRmhxDnOpxbC3PW3MKU50A4XepzwlCmLL4/vLTAzQWrvGms5/HJmik4WzyK6RlNRY3 Y9i+6lFT0+QKCqkt+KlLJBeNPGw1nrQCsTDBHQmNUGcZMljvB7O3ks46fSwaVmUrhTp7 yFVvUX9xgKQN5/+tGhmtTcKyugLMrA14akl2z8+jTpgT1BhhrCfi25RXNkVjkMPLL5sP 7cm+gtXYq0vcu52WIXBLlWeEhrOlyLmcrotAJTC+el2DHDc9vDBX1Ef20LB9ec1/oFX2 HW2G59azKD6i7dym2KViMvnmY3YEum/IS0/fd9U07eRmsQNqf5jdzNulsFeDk2DqU3DT Jnuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689013572; x=1691605572; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hbCmgSFZ0xzd+1UOHNxqTHihT/u3OV2d4MwpsMAW+gs=; b=lLK4lp3w6SxhFHPDAifUSrftfN5wgicfhkxqkvTKyklp1Gtpn6jfVWVXcZDSDr1ocG C9zzMShDaj2117MtBzd4R1s/5zadIUoUwM0+Ad0Ow2UExU1m5gB7T8wfvZASD233denE 1VxP+pIW0aOTvfRxu4odjLlg3SXCpb9pky4CjS3HcnDOXcgdknR3IAIZ8FRqLZzy5NtI GKGvcwK8eeH8vlal258bdXF3wk00uJVIEjUYUT/COsllPW/RCHgSEnX+LIooMTaNxUWW lmHiF7pRI2bal4bsB2+DDs7MLogV11XzogNaLjcREUQ8txkIWZ9wJa80CTcRIrzeGh9s dwKA== X-Gm-Message-State: ABy/qLb4VhZ8oRxVU/W1AVaCk/UY732Z41FYCkzT1K0f1xSn4bzvUk+y ZvSHmaWyAi1WLBCK3fq8+kSW2c3NscGbalmeApJIsg== X-Google-Smtp-Source: APBJJlGPxHtpwGZRQJCoIlPHWP3E/ztQoby7scgsNZsUeoWbMjTad8rgjPyASNOxE7GuH/Eh2vtNZ5V3RVOeoCxxcLo= X-Received: by 2002:a05:6512:2807:b0:4fb:cabd:2a66 with SMTP id cf7-20020a056512280700b004fbcabd2a66mr11858473lfb.21.1689013572098; Mon, 10 Jul 2023 11:26:12 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202307072123.367LNZ4J060993@gitrepo.freebsd.org> <1e07dc3f-071c-bd8d-3f15-4aaee60582f6@FreeBSD.org> In-Reply-To: <1e07dc3f-071c-bd8d-3f15-4aaee60582f6@FreeBSD.org> From: Warner Losh Date: Mon, 10 Jul 2023 12:26:01 -0600 Message-ID: Subject: Re: git: 29cbe944e928 - main - CONTRIBUTING.md: minor changes To: John Baldwin Cc: Alexey Dokuchaev , Warner Losh , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000fc7bb90600261dfa" X-Rspamd-Queue-Id: 4R0CBG65rJz3wys X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --000000000000fc7bb90600261dfa Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jul 10, 2023 at 10:00=E2=80=AFAM John Baldwin wro= te: > On 7/9/23 8:06 PM, Warner Losh wrote: > > On Sat, Jul 8, 2023 at 12:15=E2=80=AFAM Alexey Dokuchaev > wrote: > > > >> On Fri, Jul 07, 2023 at 09:23:35PM +0000, Warner Losh wrote: > >>> commit 29cbe944e9287c2e61928c456512d3990aaffdaa > >>> > >>> CONTRIBUTING.md: minor changes > >>> > >>> - Misspelled GitHub > >>> - angle bracket not escaped correctly > >>> - Double white spaces > >> > >> You've removed them, while they are typically used after full stops > >> as texts render better with them unless you're using proportional > >> font. > >> > > > > It's the modern way.... but WuerfelDev also had a commit that backed > > that part out that I didn't fold in... > > I'm still torn since I see so many conflicting things about it :( > > > > I'm leaning towards putting them back. > > FWIW, I still use monospace fonts for code and thus still use double spac= es > for the reason Alexey stated. Reading code in proportional fonts (where > spacing is naturally wider at sentence breaks) is not really viable with > style(9) which mixes tabs with spaces for indentation. > OK. I've just pushed the other half of 788 where the submitter backed out the removal of the double spaces. And now I know why they should remain. Warner --000000000000fc7bb90600261dfa Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Mon, Jul 10, 2023 at 10:00=E2=80= =AFAM John Baldwin <jhb@freebsd.org> wrote:
On= 7/9/23 8:06 PM, Warner Losh wrote:
> On Sat, Jul 8, 2023 at 12:15=E2=80=AFAM Alexey Dokuchaev <danfe@freebsd.org> w= rote:
>
>> On Fri, Jul 07, 2023 at 09:23:35PM +0000, Warner Losh wrote:
>>> commit 29cbe944e9287c2e61928c456512d3990aaffdaa
>>>
>>>=C2=A0 =C2=A0 CONTRIBUTING.md: minor changes
>>>
>>>=C2=A0 =C2=A0 - Misspelled GitHub
>>>=C2=A0 =C2=A0 - angle bracket not escaped correctly
>>>=C2=A0 =C2=A0 - Double white spaces
>>
>> You've removed them, while they are typically used after full = stops
>> as texts render better with them unless you're using proportio= nal
>> font.
>>
>
> It's the modern way....=C2=A0 =C2=A0but=C2=A0 WuerfelDev also had = a commit that backed
> that part out that I didn't fold in...
> I'm still torn since I see so many conflicting things about it :(<= br> >
> I'm leaning towards putting them back.

FWIW, I still use monospace fonts for code and thus still use double spaces=
for the reason Alexey stated.=C2=A0 Reading code in proportional fonts (whe= re
spacing is naturally wider at sentence breaks) is not really viable with style(9) which mixes tabs with spaces for indentation.

OK. I've just pushed the other half of 788 where the su= bmitter backed out the removal
of the double spaces. And now I kn= ow why they should remain.

Warner=C2=A0
--000000000000fc7bb90600261dfa--