From owner-cvs-all Mon Aug 27 7: 9: 3 2001 Delivered-To: cvs-all@freebsd.org Received: from ipcard.iptcom.net (ipcard.iptcom.net [212.9.224.5]) by hub.freebsd.org (Postfix) with ESMTP id 465AF37B403; Mon, 27 Aug 2001 07:08:52 -0700 (PDT) (envelope-from max@vega.com) Received: from vega.vega.com (root@dialup5-10.iptelecom.net.ua [212.9.227.10]) by ipcard.iptcom.net (8.9.3/8.9.3) with ESMTP id RAA69743; Mon, 27 Aug 2001 17:08:01 +0300 (EEST) (envelope-from max@vega.com) Received: (from max@localhost) by vega.vega.com (8.11.4/8.11.3) id f7RE7qM49216; Mon, 27 Aug 2001 17:07:52 +0300 (EEST) (envelope-from sobomax@FreeBSD.org) From: Maxim Sobolev Message-Id: <200108271407.f7RE7qM49216@vega.vega.com> Subject: Re: cvs commit: src/sys/dev/md md.c To: dima@unixfreak.org (Dima Dorfman) Date: Mon, 27 Aug 2001 17:06:50 +0300 (EEST) Cc: sobomax@FreeBSD.ORG (Maxim Sobolev), cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG In-Reply-To: <20010827133317.4CFF83E31@bazooka.unixfreak.org> from "Dima Dorfman" at Aug 27, 2001 06:33:12 AM X-Mailer: ELM [version 2.5 PL5] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > > Maxim Sobolev wrote: > > sobomax 2001/08/27 06:25:48 PDT > > > > Modified files: > > sys/dev/md md.c > > Log: > > - On module unload try to detach all configured disks and let unload proceed > > if all disks were detached sucessfully; > > I'm not sure this is wise. More likely than not, trying to unload md > while there are still disks attached is a mistake on the user's part, > especially considering that most people aren't going to be loading and > unloading it on a regular basis. I understand why this may be useful > for a developer working on md, but it seems counter-intuitive from a > regular user's perspective. I'm not sure that I understood your concern. If the user wants to unload md driver it means that he/she no longer needs disks that are currently configured. After all, with this patch applied the driver will autodetach only idle disks, not touching those which are currently in use (i.e. still open()'ed), so no harm will be done anyway. I really don't see why the driver shouldn't help user in this case. -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message