From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Apr 2 16:20:18 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8206D16A4CE for ; Fri, 2 Apr 2004 16:20:18 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6749043D46 for ; Fri, 2 Apr 2004 16:20:18 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i330KIbv088272 for ; Fri, 2 Apr 2004 16:20:18 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i330KIYW088271; Fri, 2 Apr 2004 16:20:18 -0800 (PST) (envelope-from gnats) Resent-Date: Fri, 2 Apr 2004 16:20:18 -0800 (PST) Resent-Message-Id: <200404030020.i330KIYW088271@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jie Gao Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C335116A4CE for ; Fri, 2 Apr 2004 16:14:51 -0800 (PST) Received: from ensa.cpsc.ucalgary.ca (ensa.cpsc.ucalgary.ca [136.159.2.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6476043D49 for ; Fri, 2 Apr 2004 16:14:51 -0800 (PST) (envelope-from gaoj@cpsc.ucalgary.ca) Received: from imgw1.cpsc.ucalgary.ca (imgw1 [136.159.5.9]) i330CBxJ002984 for ; Fri, 2 Apr 2004 17:12:11 -0700 (MST) Received: from aibsd (sana-sa [136.159.7.231])i330C6qW031894 for ; Fri, 2 Apr 2004 17:12:06 -0700 Received: by aibsd (sSMTP sendmail emulation); Fri, 2 Apr 2004 17:12:06 -0700 Message-Id: <200404030012.i330C6qW031894@imgw1.cpsc.ucalgary.ca> Date: Fri, 2 Apr 2004 17:12:06 -0700 From: "Jie Gao" To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/65101: [PATCH] Port database/dbf: segmentation fault X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Jie Gao List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Apr 2004 00:20:18 -0000 >Number: 65101 >Category: ports >Synopsis: [PATCH] Port database/dbf: segmentation fault >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Apr 02 16:20:17 PST 2004 >Closed-Date: >Last-Modified: >Originator: Jie Gao >Release: FreeBSD 5.2.1-RELEASE-p3 i386 >Organization: >Environment: System: FreeBSD aibsd 5.2.1-RELEASE-p3 FreeBSD 5.2.1-RELEASE-p3 #2: Mon Mar 29 09:30:20 MST 2004 gaoj@aibsd:/usr/src/sys/i386/compile/AIBSD i386 >Description: The port database/dbf crashes on start up. Get a sigmentation fault due to a NULL pointer in strcmp function. >How-To-Repeat: Make database/dbf from ports, get a dbf file, say, test.dbf, and type: dbf test.dbf at where the test.dbf file is, you will get the sigmentation fault. >Fix: See the attached patch. The fix is already in dbf author's CVS. --- dbf.diff begins here --- diff -ruN dbf.bak/files/patch-dbf.c dbf/files/patch-dbf.c --- dbf.bak/files/patch-dbf.c Fri Apr 2 17:02:40 2004 +++ dbf/files/patch-dbf.c Fri Apr 2 17:02:21 2004 @@ -1,6 +1,15 @@ ---- dbf.c.orig Tue Nov 11 16:48:07 2003 -+++ dbf.c Tue Nov 11 16:48:19 2003 -@@ -315,6 +315,7 @@ +--- dbf.c.orig Thu Nov 20 05:22:03 2003 ++++ dbf.c Fri Apr 2 17:01:43 2004 +@@ -341,7 +341,7 @@ + if (verbosity > 0) + banner(); + +- if(0 == strcmp(export_filename, "-")) ++ if(!export_filename || (0 == strcmp(export_filename, "-"))) + output = stdout; + else + output = export_open(export_filename); +@@ -357,6 +357,7 @@ exit(1); if (writeLine) { @@ -8,7 +17,7 @@ if ((record = malloc(record_length + 1)) == NULL) { perror("malloc"); exit(1); } -@@ -327,7 +328,6 @@ +@@ -369,7 +370,6 @@ //lseek(dbfhandle, rotate2b(db->header_length) + 1, SEEK_SET); /* At this point we look if the following data set is deleted */ --- dbf.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: