From owner-freebsd-net@FreeBSD.ORG Sun Jan 27 12:22:48 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 3588FEDE; Sun, 27 Jan 2013 12:22:48 +0000 (UTC) (envelope-from ermal.luci@gmail.com) Received: from mail-qa0-f41.google.com (mail-qa0-f41.google.com [209.85.216.41]) by mx1.freebsd.org (Postfix) with ESMTP id ADB1BDD0; Sun, 27 Jan 2013 12:22:47 +0000 (UTC) Received: by mail-qa0-f41.google.com with SMTP id hy16so486172qab.7 for ; Sun, 27 Jan 2013 04:22:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=tXpA3/n0DTwi3IpikR0cJ8/o1adHSVlYkoqlq8tMg0A=; b=lM0NskQNLI8n3Dy7AtPX/UFRyWNtsrip8HcPa1ush6X61rsYlGRcw0MY+0Hx5VRNVn 2LnqPtp4Kj4+bW2PqEvmQyu2GX/slR/ie7j9luFzs1enwtaV4JilGXtGbuTw5MnGUFTx NGU/KOnuTQpO0bOKhQ5lHfTZU37oNcOJjDd2BRIj2Z4WbztmqSk9yGwouJ5R4NUahvBq Lz1XrTExkIa/21y6YaM0ZBL8NDMwA/9DmULcd4UWLzri5yq54LlbMfgWbIVgRKIM0RYd MibiwAuKqbTpDBmFK57K0wm3DAgJn9kT/ceVQohQiY++e8Zqh0CiM1XArzfwFH+xh4Wh kkeQ== MIME-Version: 1.0 X-Received: by 10.49.24.135 with SMTP id u7mr14520412qef.4.1359289359005; Sun, 27 Jan 2013 04:22:39 -0800 (PST) Sender: ermal.luci@gmail.com Received: by 10.49.27.197 with HTTP; Sun, 27 Jan 2013 04:22:38 -0800 (PST) In-Reply-To: <51050CA5.8030805@FreeBSD.org> References: <50C9C012.8020306@FreeBSD.org> <50C9C55A.5090900@ipfw.ru> <50CA0161.1060000@FreeBSD.org> <50CB5B8A.8030703@FreeBSD.org> <75277A1B-B434-4220-A800-9004C29DA92A@gmail.com> <51050CA5.8030805@FreeBSD.org> Date: Sun, 27 Jan 2013 13:22:38 +0100 X-Google-Sender-Auth: uBUzwUL2rogoiQN2-8IxxRmtU_o Message-ID: Subject: Re: ng_ether naming From: =?ISO-8859-1?Q?Ermal_Lu=E7i?= To: Andriy Gapon Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: Nikolay Denev , "Alexander V. Chernikov" , freebsd-net X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Jan 2013 12:22:48 -0000 Hello, it looks good, for just interface renaming scope. The problem of it is that you need to check if the ifnet pointer needs updated as well. For coming and going interfaces like vlans you would have to update some pointers as well at least the ifnet one. The complete patch would rather include moving detach/attach(?) code from if_ethersubr.c to ng_ether based on interface events. On Sun, Jan 27, 2013 at 12:16 PM, Andriy Gapon wrote: > > Guys, > > based on your suggestions and submissions I've produced the following > patch: > http://people.freebsd.org/~avg/ng_ether-renaming.diff > > It's only compile-tested at the moment :) > but I'd like to get your opinion about the direction of the change(s). > I am going to really test the change very soon. > > Thank you. > > -- > Andriy Gapon > -- Ermal