From owner-freebsd-net Fri Apr 28 11:52:59 2000 Delivered-To: freebsd-net@freebsd.org Received: from bubba.whistle.com (bubba.whistle.com [207.76.205.7]) by hub.freebsd.org (Postfix) with ESMTP id C563637B56E; Fri, 28 Apr 2000 11:52:54 -0700 (PDT) (envelope-from archie@whistle.com) Received: (from archie@localhost) by bubba.whistle.com (8.9.3/8.9.2) id LAA75594; Fri, 28 Apr 2000 11:52:54 -0700 (PDT) From: Archie Cobbs Message-Id: <200004281852.LAA75594@bubba.whistle.com> Subject: Re: Proposal for ethernet, bridging, netgraph In-Reply-To: from Robert Watson at "Apr 28, 2000 02:23:02 pm" To: rwatson@freebsd.org (Robert Watson) Date: Fri, 28 Apr 2000 11:52:54 -0700 (PDT) Cc: committers@freebsd.org, freebsd-net@freebsd.org X-Mailer: ELM [version 2.4ME+ PL54 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org Robert Watson writes: > I haven't had a chance to review this code as I'm travelling, but the > chances are it breaks bridge+ipfw as that code is rather fragile and > sensitive to mbuf foo. I've been using a cleaned up version of the > bridge+ipfw code that causes ipfw to only affect IP, and cleans up a lot > of the behavior (although it doesn't fix the general DUMMYNET problem of > prefixing mbufs with a DUMMYNET tag). It also doesn't fix the bug that > only allowed one DUMMYNET pipe to be applied to bridged packets, as any > pipe command in essence also acts as an accept (this should go into our > release ERRATA, btw). > > I'm flying back to Massachusetts this evening, and may have a chance to > put up diffs at that point or tomorrow, but I think coordinating these > patches to go in at the same time would make sense. > > As such, please hold off on committing until I can either get you the > patches and we can decide if that's a good idea or not :-) OK.. why don't you just commit your patches and I'll wait for them. My patch breaks bridging anyway and I need to fix that... and that will probably be easier after your patch.. the code is not pretty :-) Thanks, -Archie ___________________________________________________________________________ Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message