From owner-freebsd-current@FreeBSD.ORG Tue Aug 15 16:00:05 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0789716A4E5; Tue, 15 Aug 2006 16:00:04 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id D84CE43D78; Tue, 15 Aug 2006 15:59:56 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id k7FFxnnl028428; Tue, 15 Aug 2006 11:59:54 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Suleiman Souhlal Date: Tue, 15 Aug 2006 11:49:19 -0400 User-Agent: KMail/1.9.1 References: <20060814170418.GA89686@stud.fit.vutbr.cz> <200608151101.30951.jhb@freebsd.org> <44E1E64F.6020205@FreeBSD.org> In-Reply-To: <44E1E64F.6020205@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200608151149.20338.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 15 Aug 2006 11:59:54 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/1664/Tue Aug 15 10:28:31 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: emulation@freebsd.org, Divacky Roman , freebsd-current@freebsd.org Subject: Re: SoC: linuxolator update: first patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Aug 2006 16:00:05 -0000 On Tuesday 15 August 2006 11:20, Suleiman Souhlal wrote: > John Baldwin wrote: > > > >>+ KASSERT(em != NULL, ("proc_init: emuldata not found in exec case.\n")); > >>+ } > >>+ > >>+ em->child_clear_tid = NULL; > >>+ em->child_set_tid = NULL; > >>+ > >>+ /* allocate the shared struct only in clone()/fork cases > >>+ * in the case of clone() td = calling proc and child = pid of > >>+ * the newly created proc > >>+ */ > >>+ if (child != 0) { > >>+ if (flags & CLONE_VM) { > >>+ /* lookup the parent */ > >>+ p_em = em_find(td->td_proc, EMUL_LOCKED); > >>+ KASSERT(p_em != NULL, ("proc_init: parent emuldata not found for > >>CLONE_VM\n")); > >>+ em->shared = p_em->shared; > >>+ em->shared->refs++; > >> > >>This is unsafe. Please use the functions in sys/refcount.h. > > > > > > Well, in this case he's already holding a lock. If he always holds a lock > > when accessing and modifying refs, then refcount_*() would only add overhead. > > Isn't he holding the wrong lock (emul_lock vs emul_shared_lock)? Maybe. I think those should be merged into one lock anyway. :) -- John Baldwin