From owner-freebsd-current@freebsd.org Wed Dec 23 11:04:01 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CEF3EA5073F for ; Wed, 23 Dec 2015 11:04:01 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x235.google.com (mail-pf0-x235.google.com [IPv6:2607:f8b0:400e:c00::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AAB141A1A; Wed, 23 Dec 2015 11:04:01 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x235.google.com with SMTP id u7so75181442pfb.1; Wed, 23 Dec 2015 03:04:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=JIplqJMHwp6CMDUhoIJb5J+e/5SBz+hMWEeuJBdlZwM=; b=dy/30vPdMWHHDAE1h1qvAPBOAvllJmraDthw0vRxmUmYrJTXDRdydpozY8Is//CIym WqNKSMyk9TjHhL4MeUGsS1rWL/DWa5Dnwoq5/TL7Ca5zrxq8gHzTxI9qAuajgGxiq2UY +rOGrfO4L1Z04F3LAZwqIo5AO0gaxsk7gTxDNoTSaJ5ICMwyDQHBuEeK9CASz/223awm gvMxUPagH/R+O715rpsJ3pW6eTQ7RZwCMCBIR2RR4K0JrQozacwFItxwVH9V/ear5NYx 0RBsYtApyDrTVllECOsjQ3BOISWpUpKx8k9A9Oi/TE4+vWOLGrblLFQKaPAJfSe11yly dDng== X-Received: by 10.98.17.147 with SMTP id 19mr43188349pfr.66.1450868641101; Wed, 23 Dec 2015 03:04:01 -0800 (PST) Received: from ?IPv6:2601:601:800:126d:6572:283a:84b7:ac98? ([2601:601:800:126d:6572:283a:84b7:ac98]) by smtp.gmail.com with ESMTPSA id o2sm51944810pap.31.2015.12.23.03.03.58 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 23 Dec 2015 03:03:59 -0800 (PST) Content-Type: text/plain; charset=cp932 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: Build from 9.3-RELEASE to 11.0-CURRENT fails for i386 (-Wsign-compare issues with gcc) From: NGie Cooper In-Reply-To: Date: Wed, 23 Dec 2015 03:03:57 -0800 Cc: freebsd-current@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <6A4DDA2E-F07D-420A-9D24-C53C2036723C@gmail.com> References: <8E98A82D-C36F-4863-8BE4-81288735F3A1@gmail.com> <3659799.xE9v788p8Q@ralph.baldwin.cx> <3216653.gTnkE43ffA@ralph.baldwin.cx> To: John Baldwin X-Mailer: Apple Mail (2.2104) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Dec 2015 11:04:02 -0000 > On Dec 22, 2015, at 10:27, Garrett Cooper = wrote: >=20 >=20 >> On Dec 22, 2015, at 08:23, John Baldwin wrote: >>=20 >>> On Monday, December 21, 2015 11:01:36 AM John Baldwin wrote: >>>> On Saturday, December 19, 2015 01:05:36 PM NGie Cooper wrote: >>>> Hi John, >>>> I tried bootstrapping 9.3-RELEASE to 11.0-CURRENT with i386 and = ran into the -Wsign-compare issue below when running make libraries with = buildworld, because it=81fs building libkvm with gcc 4.2.1 :/=81c I=81fve = tried bootstrapping with clang/clang37, but haven=81ft been able to yet. = I=81fll try installing 10.2-RELEASE via freebsd-update so I can use = clang instead of gcc. >>>> Thanks! >>>> -NGie >>>=20 >>> We don't actually support going from 9 to 11. However, these = constants >>> should probably be explicitly unsigned anyway. I haven't tested = this at >>> all, but something like this: >>>=20 >>> Index: head/lib/libkvm/kvm_i386.h >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>> --- head/lib/libkvm/kvm_i386.h (revision 292553) >>> +++ head/lib/libkvm/kvm_i386.h (working copy) >>> @@ -57,8 +57,8 @@ >>> #define I386_PG_PS 0x080 >>> #define I386_PG_FRAME_PAE (0x000ffffffffff000ull) >>> #define I386_PG_PS_FRAME_PAE (0x000fffffffe00000ull) >>> -#define I386_PG_FRAME (0xfffff000) >>> -#define I386_PG_PS_FRAME (0xffc00000) >>> +#define I386_PG_FRAME (0xfffff000u) >>> +#define I386_PG_PS_FRAME (0xffc00000u) >>>=20 >>> #ifdef __i386__ >>> _Static_assert(PAGE_SHIFT =3D=3D I386_PAGE_SHIFT, "PAGE_SHIFT = mismatch"); >>=20 >> This passed a universe build on HEAD. If you can test that it fixes = the 9.3 -> 11.0 >> bootstrap I will commit it. >=20 > I'll fire up a 9.3 VM and give it a shot. > Thanks :)!! Hmm=81c no bueno on ref9-amd64. What likely needs to be done is that the = directory needs to be built by itself with gcc on i386. Thanks! -NGie cc1: warnings being treated as errors In file included from /scratch/tmp/ngie/svn/lib/libkvm/kvm_i386.c:63: /scratch/tmp/ngie/svn/lib/libkvm/kvm_i386.h:73: warning: comparison = between signed and unsigned *** [kvm_i386.So] Error code 1 bmake[5]: stopped in /scratch/tmp/ngie/svn/lib/libkvm 1 error bmake[5]: stopped in /scratch/tmp/ngie/svn/lib/libkvm *** [lib/libkvm__L] Error code 2 bmake[4]: stopped in /scratch/tmp/ngie/svn