From owner-svn-ports-all@freebsd.org Thu Apr 4 10:04:54 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B008B156B4A5; Thu, 4 Apr 2019 10:04:54 +0000 (UTC) (envelope-from meta@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5392968532; Thu, 4 Apr 2019 10:04:54 +0000 (UTC) (envelope-from meta@FreeBSD.org) Received: from icepick.vmeta.jp (unknown [IPv6:2405:6586:2280:1200:14ee:c802:8fad:59eb]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: meta/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id A367B19715; Thu, 4 Apr 2019 10:04:52 +0000 (UTC) (envelope-from meta@FreeBSD.org) Date: Thu, 4 Apr 2019 19:04:49 +0900 From: Koichiro Iwao To: Hiroki Sato Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r497400 - in head/net: . tigervnc tigervnc-server tigervnc-viewer Message-ID: <20190404100449.sli2ta4vkrxhvmpb@icepick.vmeta.jp> References: <201903311310.x2VDA4cN047931@repo.freebsd.org> <20190404.172215.1570903530092886558.hrs@allbsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190404.172215.1570903530092886558.hrs@allbsd.org> X-Operating-System: FreeBSD 12.0-STABLE amd64 User-Agent: NeoMutt/20180716 X-Rspamd-Queue-Id: 5392968532 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.92 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.92)[-0.921,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Apr 2019 10:04:54 -0000 On Thu, Apr 04, 2019 at 05:22:15PM +0900, Hiroki Sato wrote: > > If net/tigervnc now has only SERVER as the default options, it is no > longer worth keeping it as a meta-port because the resultant package > is an empty one which has a single dependency on tigervnc-server. An > entry to MOVED is sufficient in this case. > > Even if you want to keep this, at least you might want to take care > of backward compatibility with the old tigervnc. Both of SERVER and > VIEWER should be added back to it since it had VIEWER in > OPTIONS_DEFAULT. Thank you for the advice. I'll consider that. > LICENSE.TXT should not be installed into DOCSDIR. It will be > installed by specifying LICENSE_FILE in a per-package directory, so > you can simply drop it from DOCS. I understand now. The conflicting LICENSE.TXT in DOCSDIR is installed not by ports framework but upstream cmake. I was wondering why it conflicts that should not conflict. https://github.com/TigerVNC/tigervnc/blob/6011f96cdc5b8f68a864d7f6294d9a45030b3533/cmake/BuildPackages.cmake#L89 OTOH, LICENSE file installed by ports framework is located here, right? /usr/local/share/licenses/tigervnc-server-1.9.0_1/LICENSE Indeed LICENSE.TXT installed by upstream cmake can simply be dropped. -- meta