From owner-p4-projects  Thu Oct 31 13:35:10 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id EE74E37B404; Thu, 31 Oct 2002 13:35:07 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9D0D037B401
	for <perforce@freebsd.org>; Thu, 31 Oct 2002 13:35:07 -0800 (PST)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2F3CC43E91
	for <perforce@freebsd.org>; Thu, 31 Oct 2002 13:35:07 -0800 (PST)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id g9VLXjmV019028
	for <perforce@freebsd.org>; Thu, 31 Oct 2002 13:33:45 -0800 (PST)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.6/8.12.6/Submit) id g9VLXjos019025
	for perforce@freebsd.org; Thu, 31 Oct 2002 13:33:45 -0800 (PST)
Date: Thu, 31 Oct 2002 13:33:45 -0800 (PST)
Message-Id: <200210312133.g9VLXjos019025@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
Subject: PERFORCE change 20493 for review
To: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

http://perforce.freebsd.org/chv.cgi?CH=20493

Change 20493 by rwatson@rwatson_tislabs on 2002/10/31 13:33:40

	Trim redundant suser() check for hostname setting: the sysctl
	code already does this check so we don't need it here.

Affected files ...

.. //depot/projects/trustedbsd/mac/sys/kern/kern_xxx.c#4 edit

Differences ...

==== //depot/projects/trustedbsd/mac/sys/kern/kern_xxx.c#4 (text+ko) ====

@@ -97,10 +97,8 @@
 	name[0] = CTL_KERN;
 	name[1] = KERN_HOSTNAME;
 	mtx_lock(&Giant);
-	if ((error = suser_cred(td->td_ucred, PRISON_ROOT)) == 0) {
-		error = userland_sysctl(td, name, 2, 0, 0, 0,
-		    uap->hostname, uap->len, 0);
-	}
+	error = userland_sysctl(td, name, 2, 0, 0, 0, uap->hostname,
+	    uap->len, 0);
 	mtx_unlock(&Giant);
 	return (error);
 }

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message