Date: Thu, 12 Oct 2006 23:48:00 -0400 From: Tom Rhodes <trhodes@FreeBSD.org> To: Mikhail Teterin <mi+mx@aldan.algebra.com> Cc: trhodes@FreeBSD.org, freebsd-doc@FreeBSD.org, mi@aldan.algebra.com, jmacd@cs.berkeley.edu Subject: Re: docs/65530: [patch] minor improvement to getgrent(3) Message-ID: <20061012234800.3131bd97.trhodes@FreeBSD.org> In-Reply-To: <200610122226.39844.mi%2Bmx@aldan.algebra.com> References: <200610120845.k9C8jDdc070356@freefall.freebsd.org> <200610122226.39844.mi%2Bmx@aldan.algebra.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 12 Oct 2006 22:26:39 -0400 Mikhail Teterin <mi+mx@aldan.algebra.com> wrote: > ÞÅÔ×ÅÒ 12 ÖÏ×ÔÅÎØ 2006 04:45, Tom Rhodes ÎÁÐÉÓÁ×: > > This information is duplicated from the /usr/include/grp.h > > header file, we should change both or none. > > Why? Header files are only a second-from-last sources of information > (implementation being the last). A good manual page leaves no need to look at > the declaration. Then we should patch both, not just one. > > > I don't see a good reason to really change them right now as it seems seems > > self-explainatory. šThanks for the submission! > > ?? The information was put there in 1996 -- it just got lost because of a cvs > mishap. > > I don't believe it to be self-explanatory -- there is not even a single > example in the man-page. One could *guess*, that the list is null terminated, > but it should be explicit, or else time will be wasted searching for other > api (getgroupnumber() ?) or writing test-programs. To me it seems fine, but if you want both patched then go for it. Send me a patch please. ;) -- Tom Rhodes
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061012234800.3131bd97.trhodes>