From owner-svn-src-all@freebsd.org Sat Sep 10 20:04:59 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 68E60BD5AD6; Sat, 10 Sep 2016 20:04:59 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on071e.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe48::71e]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT SSL SHA2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D89EFFC2; Sat, 10 Sep 2016 20:04:58 +0000 (UTC) (envelope-from sjg@juniper.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=junipernetworks.onmicrosoft.com; s=selector1-juniper-net; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=jgPWMidWAWK7AMF3nV67/HyZZcN1Iql0Zm9mfhWOmYg=; b=Hqwg+zIe9HtKC1qAPIXQnbrbaIozRabhuDC4II9epe81N/GShlU+KK0QZ0gGBBHjeztmC6t//XcYvdqOBjzvnhpYBeN02+f/VSOErfY5I+TTXTpShKyH9Lz/obec2A+HJWliDOSofS1ipI5UzCjKiRq6PzNfdy58AbVnIu/Qlvk= Received: from SN1PR05CA0035.namprd05.prod.outlook.com (10.163.68.173) by DM5PR05MB3145.namprd05.prod.outlook.com (10.173.219.15) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.599.2; Sat, 10 Sep 2016 00:27:53 +0000 Received: from BN1AFFO11FD042.protection.gbl (2a01:111:f400:7c10::175) by SN1PR05CA0035.outlook.office365.com (2a01:111:e400:5197::45) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.619.3 via Frontend Transport; Sat, 10 Sep 2016 00:27:53 +0000 Authentication-Results: spf=softfail (sender IP is 66.129.239.18) smtp.mailfrom=juniper.net; FreeBSD.org; dkim=none (message not signed) header.d=none;FreeBSD.org; dmarc=none action=none header.from=juniper.net; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.239.18 as permitted sender) Received: from p-emfe01a-sac.jnpr.net (66.129.239.18) by BN1AFFO11FD042.mail.protection.outlook.com (10.58.52.253) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.587.6 via Frontend Transport; Sat, 10 Sep 2016 00:27:53 +0000 Received: from p-mailhub01.juniper.net (10.160.2.17) by p-emfe01a-sac.jnpr.net (172.24.192.21) with Microsoft SMTP Server (TLS) id 14.3.123.3; Fri, 9 Sep 2016 17:27:40 -0700 Received: from kaos.jnpr.net (kaos.jnpr.net [172.21.30.60]) by p-mailhub01.juniper.net (8.14.4/8.11.3) with ESMTP id u8A0Rdov011566; Fri, 9 Sep 2016 17:27:39 -0700 (envelope-from sjg@juniper.net) Received: from kaos.jnpr.net (localhost [127.0.0.1]) by kaos.jnpr.net (Postfix) with ESMTP id 92EF738551E; Fri, 9 Sep 2016 17:27:39 -0700 (PDT) To: Bryan Drewery CC: , , , Subject: Re: svn commit: r305634 - head/share/mk In-Reply-To: References: <201609090121.u891LZOO023156@repo.freebsd.org> Comments: In-reply-to: Bryan Drewery message dated "Fri, 09 Sep 2016 11:24:27 -0700." From: "Simon J. Gerraty" X-Mailer: MH-E 8.6; nmh 1.6; GNU Emacs 24.5.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <76390.1473467259.1@kaos.jnpr.net> Date: Fri, 9 Sep 2016 17:27:39 -0700 Message-ID: <76391.1473467259@kaos.jnpr.net> X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:66.129.239.18; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(7916002)(2980300002)(199003)(189002)(24454002)(69596002)(7126002)(356003)(50986999)(19580395003)(81156014)(50466002)(86362001)(76176999)(8676002)(117636001)(626004)(53416004)(68736007)(46406003)(7696004)(2906002)(9686002)(7846002)(50226002)(23726003)(92566002)(97756001)(586003)(4001430100002)(77096005)(97736004)(8936002)(11100500001)(87936001)(305945005)(4326007)(189998001)(2950100001)(450100001)(5660300001)(2810700001)(107886002)(106466001)(19580405001)(47776003)(81166006)(110136002)(105596002)(76506005)(42262002); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR05MB3145; H:p-emfe01a-sac.jnpr.net; FPR:; SPF:SoftFail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD042; 1:utWk/f2q1atuNHOcjvd7ljJLqFKJw3yQX9SFdbAdT7h48qUwHa+6/qSoMX7+eR3b4uuDVVSWYPxIdEPEnZFTb2AjnVRSp2Ns76n1wlliq1i7CsR/tzpwks9KSNlE8oIDQRL3kVig3RQ9JwqRlRyTyx9kk0bSlkO5JAwO24uEdsbKGmtekHCkZ8WJYl6B06y2SK111jdae5zgdIo943CBPkI5IM2LtkY8WuGyiEY6RyW4Z8NHTCK4RcBTMg7Ft7yKd8uAiwnD5uBfxkrW1Mq17bIHi9NRF7GyNn9ZXLnn9NAbfo1ZWfE+Xo7Wj9sueqvdbwBYw2EZVJ9q6g7BAsXduy0VcFVvycUGMOXkoYE+9ORUr8+rbITXXAv3MlRpwt2TcqDR7tRoWKkKYpwyPaXsNhkif9bwDJLjdrFEwiBCP50+Rr7vRtsEHhZh91u3AhPqZPTSN9TUMM3Bpq2zTVSAL3Hnh4/sNhNL4JfPo4Ej9evrSIIb0OLTS0oh/3cNTSD7U7+eM0/qQVbACDYyZOAm96nsvWBdDFXs9Gk86Jw82jU= X-MS-Office365-Filtering-Correlation-Id: a7abf8e9-a08b-4c5e-9537-08d3d9114de3 X-Microsoft-Exchange-Diagnostics: 1; DM5PR05MB3145; 2:NpJo9oKaWIulp5HCxGCLOqMNV2DmL3fQgM2uTGTvPHiSvyX9SNkSgtqfBEXzIlLW+UG/p3BAciuPh7NTnyIPUpsfABU0/QwQPubZtDXSPnf/YxxiQ+NPyBNh8bPsuXMdbXjpnwte4BEN2yVYb+Zph3kZXGI7WsG14cjW/8Hg6wIcoiRhxTMiGXhxEqs6mWLm; 3:31/wysTkjc/Q+1tYlLdhD7YgUMBQ3sdw1CkdeAtGboPxA9A4pTUCWW6cE4VMoXS/xBhPtF1AizWqQJfh3w7YWcFcAChL1ICXz0MnwnAlHV6ov2HivwxTnrwM0rzBMoacQpGIKN8xo8NJmwPe9SnnPIj+HiMphi+iNMRNkW7AW4gXo28r9n6Sw2Fzq08gc+tmwlXhp5D1eqEWbQcSNcBaAitcgS22zYHCCxS8nIKc1/Y=; 25:gSMs3JmaDZFGG4N8BW0mFUUstXzrMNEAje4hLsc5LL3SaGmsq1n3nQP0kyLgorMurXTvog6CV/8IcqPm+OSGhTkDv/ra1MWd/B47xsxnhkasAeSc8JwXcV4QvMTbqHVHENo6aUBO3i/kD7L4s/cKF0rklzLvfk09bxNQmogc/ow9lXikrviR/WdFOfne5P9Ax4xLCeEOAEWKQlBK/GFSdLa7bTiDjgnqY03RliTKNlkGcniCRudXO2Op9GLr6MgMvoyuyKind0KsIIVvo5OuhpcrUlzjQNefbmf5HXSChqsk644MNf8v9quEHrq4glx2ghBwlm6w9jnXG7bwR6ATM2dAXyuA+2WTF1uZOFM8C2ReausDQ/h9qdf8KkDN9d4/axmmZQ8M588U847ySPWuyInqpKXTtX/1t28iUBcsUQ0= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM5PR05MB3145; X-Microsoft-Exchange-Diagnostics: 1; DM5PR05MB3145; 31:tGd8wB5OHCwbrYkmmAA10r5cwZEFBSCBQu1p6L5XpqOC1h/kB5PaCiLsUFDiFcE3EbGBZ58uksnvRzJhyWGC41zGTat8tXQNLgWqZtnjdVR9sCpUbCHeUgV3HZ04TsX/jreROeLWFckkpo8k+/UD7uUvnXYM4QR9kMrXTyjfQIYOf+lxuuX0TlyZnJI2pCgoqj4IzIaxmIXhg+Uv230lVR2IK4q411zYHJJrMzyp7jE=; 20:CnAmmlad34bnh9aTsOPb4+XU/7bPHwtA4xPuoGaEpAU0HvQy1uqxGHe7t3DVcpxQc2kPbpKzslpOU+BG/+jtsi+ehVIPZ7UyiI7KikhP3ofWX0DZJTU7QNvSLW5S/Np6IQ4PO0Yk8zt6G9KKh3vBPnVOq1AmzEiHwjpXUUEiXzo5vkFcdl3fn8zvIv84+a1Qk8a/1C5PmkE+o09nJBtDd0EbjtzpG9lSatQYKtkEpA1Zb6BZtWMXDQAX4I6efyb3GxRYy1YW9hRtHqDnBj7qH5Hri3uDv5t+KJZdPOjHKFHsQtiz2qkxsTCCPs+FodqAdMDUmsQV7N2q2NQNyHie8MBTHrQoaSD8QYgnqW3NR+P5Hr3QPfjZL2Lbn1UpwB7LtMTOUJPFCqs5WsN6FibKVVXC06y0kWeU21DF49JqnfE23VnedfPoh6Xh4elL7byowGgi3NgQHb++CI1bI253m2CR2vJlot2mNrL2BnnOG2sDZFBS2XLsLkI6EVIuXGiX X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(13015025)(13017025)(13023025)(13024025)(13018025)(5005006)(8121501046)(10201501046)(3002001)(6055026); SRVR:DM5PR05MB3145; BCL:0; PCL:0; RULEID:; SRVR:DM5PR05MB3145; X-Microsoft-Exchange-Diagnostics: 1; DM5PR05MB3145; 4:hBen3htlQznMibhunFC3BWxjIJlNga7XC/6wFg2RBiiUxRNrbJ3NAQzQ0EJl02c4sNB8ZSH8VCROooc5oGOPxAchJ4Kfxd3bhwyv5ekpRpWVDQ5ewyR1vExs5XYPvhW/ocK22/bGS7B2/WI1EiSY+O5hcZMb1yCUuG0Fy1w1eiUeZg201yo+AuPjaLqcqvrNOyq7bnIo2VZhqzSMvluQc5hUSo2zGrD9PPt74zddLchQAvktv2ON4op+qll7/EJb2iSd8h4bgUkhrBUg2Uj7wB2fjV0X4adliFbbMx/GnskM3UoGBerGa5MV9re+06AV7Tsadxee68fzyptHp0ifToIP1xtQ/km/y+YNVruI47a2XTWbul7FBaZAc2b1l3yzyNrXFsu1AYUW2r4O0YZJRpVySfdE2hJ4744ME1rWpD4BgKIqMLilMV8sNF19cNz/PNXZYl80312tjczEdbgwshjvonr5i8UnMrgvx+Ogc7x5tTKQs3sNiGM+h7rm/emQ X-Forefront-PRVS: 0061C35778 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR05MB3145; 23:mSreuyjjEPtU24r2ID2O5OrLOfYfvq6XScJEaHCR0?= =?us-ascii?Q?DRUNugEfKCMX94hSPljrYTCPkCZlMDdoDvWqcXHoGmy6s9yYK2RrW30/Y49u?= =?us-ascii?Q?KN1NC9iNKJI71HXU+I5ttb6R13CdbSrLXukvItQ5Xd0+XT4dOeFNWBwSxjP/?= =?us-ascii?Q?g65/mdiQKzmIzdkSDsTdJVXlqSqCBfW6rb+Xu1AsAKAtdBeUGdTwsuMhy4X6?= =?us-ascii?Q?w/JSeI4qMkRxXL2WM1rwiA4IJTVGykVCu6FojmMZGtKM/8LvII4Y8Ha0YYZQ?= =?us-ascii?Q?Q+EhtbmoGDhkft3p1KM41zMynjZgvh/sfvROil5LZmIlsBCMqTPVTVPS4ix4?= =?us-ascii?Q?cgpI8ihFeJCsfIqnFGcKEC2YBwrK7fTIrj+l0D8j7SJnWMjz9czl43S6YYzQ?= =?us-ascii?Q?LcSJLbUqO+Vwe4lim/VlSlnB2016eOUdHN5Zw7lmLSu2yG91gjTyaHRCUAdk?= =?us-ascii?Q?gG4u2z313UZdLwsGQvv4kPXAjrzGZaBYs9Ptmj/9ZVNHUSt+WT/ij12IBBWW?= =?us-ascii?Q?M+YrhIT5PG2v/EprmC2v2o70nUBRJOVsy3U1nNVLSR02ZnVa6y9aMbOubZHQ?= =?us-ascii?Q?Sfz88Ezgym1rPps7HdpEcgBvWaVFK5hP851I4neC32S7A2q+snc6MBKkF5B+?= =?us-ascii?Q?JtRwLtPpiV8xoRp81OO4UCdsICui4wC8mdVQCS5sgETja63+U89T/fw1PorE?= =?us-ascii?Q?lHLV1H6bdvn0cPSoScWdQYKNIN6bPjnLuyeFe2I20JlYrawF5wtmg5b93taY?= =?us-ascii?Q?gtjNahrHwhuHRpuQXfATgB8n1/DoBM25GfNFTVqSR1FFrZXk/9qnhmPb7NAy?= =?us-ascii?Q?NzAu/sfG51L0RNccxbYKiLIidWQNxvZ8M68akS5KNYKRa2TKhaSs0oSl3GTQ?= =?us-ascii?Q?HHQjLe4TDWXwGN0nc3Zs8X5jeyeNQFL9dtQyeF7Ag7ROU1LMWbYSWW3loOOJ?= =?us-ascii?Q?i/24YmAzU5UgwsZz0Tb38tunmY4UX2zqWQHGG6K5A7vejIKqbKhIjZnzrAdf?= =?us-ascii?Q?F7gwaCY7TJqEBvgdhJtmQzY+8w4DDqC6od5YH3aaWWX91IW+zem9Q41pDeY+?= =?us-ascii?Q?E5VNJb1RRgZWo1qQu0tlmwi2WqyXyh1OiS+KSrd8ALsHShl/0iiTWh/k2uzu?= =?us-ascii?Q?IbpNl2pfyOZ6zHePV6ZR40cHknQZmRmD9vGjgeW2ZsB0aAVrd1vUAIT+bzKT?= =?us-ascii?Q?zBH6Cfs+WV3E6r03cNVH0nfDQzY+oeeHb6mIQZL3EQJlfPapbyK3Jzj8oeKQ?= =?us-ascii?Q?q9d+M66iZSXHxkhqNc=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR05MB3145; 6:zauOS0+ZiSZ3KSv5vg2zfMtr69QAzL+S49GHyGak9qGaHMB1/kH+vGQMTb2m4PQJSW4H1xdeGKZ3v1bgJ45haUrBIwnIQroafY5qljD1tZG0meF5piBdVN7pxc9iAzjD9e5MY07DjJHiJ5Rc7mCVZ24DgS6KB+gL2WxgMm/JNNcGj6P0NHysJkJOUGIQOWeBIlbpaJlwBVIzt1WiiA1dvT/RfCXYc0uv5MR59LMtUvgD5cFnwZdJxjEOlsxYWkUOTUvRFextQc6oEt63b65HYYgjSEXciZJc7Qr6kM44jgPReS1Hsbl1gQGFLf4WWUz6IiKpO91j8J2UrleFsDKhsA==; 5:tyy6L4jTf2pMahMRpIexiejj0NulOm8LX4Ru7Vug3Yi7FHPWYli30Vv6A2i+x4P+ZaJ9RFhOyO6gAzH0h5HlyyGMd+FTUXA6RSWiVAkFRVZIJfhHda0Qa6qkJfl9nFCNCqPonzf6xI0Kj30rZnQ2yA==; 24:xhOgCHcsCr6xav07K5dHY+QUM3PtlUZdWAwMYOUFdMKW7O2ZeCGtcvVcukiPVJtvBpzrAYWI+j5HaeNRobVAwqSVqXhcL9AsZxgcD8SkNWc=; 7:xaGtM3hLhz1JvrIojNYaRgGiKlO5Hjwt2RUc/4MO8qecow4+IeVKZEg87+RKPBGrMac0JaeGGmRb2dh2dimm6qffzbjsQEkHRceiQysWqUFd2cQ7UtMGKS4e2UoR7wrv+monq+c2TFqSiyr6B55ARyDdyNd9zxQWz7kRJVS2oFr2zpVv8XgJbEWKuLs+u54ttRYxw8u0Z15S3LJFw/ZOM96jSjPXcPDLc1fGr7NTJtRppqJzWC2AOUA0Fsr7Ain2 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2016 00:27:53.0059 (UTC) X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4; Ip=[66.129.239.18]; Helo=[p-emfe01a-sac.jnpr.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR05MB3145 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Sep 2016 20:04:59 -0000 Bryan Drewery wrote: > > +# we can afford to use cookies to prevent some targets > > +# re-running needlessly > > +META_COOKIE_TOUCH= touch ${COOKIE.${.TARGET}:U${.OBJDIR}/${.TARGET}} > > Could you use ?= here please? I have a META_COOKIE_TOUCH in local.sys.mk Sure. > Also note that you need to remove this cookie immediately in any target > that uses it. I covered this a bit in my BSDCan presentation. The > problem is if meta mode determines that a target is outdated, then > partially rebuilds the target, then fails before touching the cookie. > The next build may not consider the target out-of-date anymore and fail > to retry. > > Consider something like: > foo: foo.c > target_install: > cp foo ${DESTDIR}/usr/bin/ > touch target_install > > It may consider this target out-of-date due to foo rebuilding (and > detected in target_install.meta), but the cp may fail. The next build, > target_install.meta was overwritten with the failed attempt, and is now > newer than foo and still has its target_install cookie. Nothing will The mtime of the .meta file is not relevent as it is not the target If foo is still newer than target_install and referenced by the the .meta file the target will still be out-of-date Sill, one could do things like: .ERROR: ${.ERROR_TARGET:Drm -f ${.ERROR_TARGET}} or if multiple things to be done on .ERROR .ERROR: rm-failed rm-failed: .NOMETA ${.ERROR_TARGET:Drm -f ${.ERROR_TARGET}} to ensure that any failed target is removed. > cause it to retry copying, and it proceeds on with the build without > properly failing again. I hit this case in at least include/ (which > went through a lot of further changes, finally of which was the removal > of cookies in r300346) and some other cases which I don't recall the > specifics for.