From owner-cvs-src@FreeBSD.ORG  Tue Jul  8 02:02:39 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9034237B401; Tue,  8 Jul 2003 02:02:39 -0700 (PDT)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id A2BFA43F75; Tue,  8 Jul 2003 02:02:37 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3p2/8.8.7) with ESMTP id TAA18305;
	Tue, 8 Jul 2003 19:02:10 +1000
Date: Tue, 8 Jul 2003 19:02:09 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Tony Finch <dot@dotat.at>
In-Reply-To: <20030707144037.GA30539@chiark.greenend.org.uk>
Message-ID: <20030708185807.R10890@gamplex.bde.org>
References: <200307061244.h66CiBqg079835@repoman.freebsd.org>
	<20030707003216.GI72093@elvis.mu.org>
	<20030707200516.E7247@gamplex.bde.org>
	<20030707144037.GA30539@chiark.greenend.org.uk>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: Alfred Perlstein <bright@mu.org>
cc: Garance A Drosihn <drosih@rpi.edu>
cc: src-committers@FreeBSD.org
cc: Philippe Charnier <charnier@FreeBSD.org>
Subject: Re: cvs commit: src/usr.sbin/lpr/lpd lpd.c ...
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Jul 2003 09:02:39 -0000

On Mon, 7 Jul 2003, Tony Finch wrote:

> On Mon, Jul 07, 2003 at 08:15:40PM +1000, Bruce Evans wrote:
> > On Sun, 6 Jul 2003, Garance A Drosihn wrote:
> >
> > >   [ ignoring that question for the moment, why would I want
> > >    to define __FBSDID as 'struct __hack'? ]
> >
> > You would have to define it as something non-null (if you didn't
> > remove it), since defining it to null would give a syntax error
> > for the ";" following it (if you didn't remove this instead).
> > "struct __hack" is a harmless non-null something which uses an
> > unusual (?) struct hack as an implementation detail.
>
> Though be warned that the identifier __hack is reserved so it
> would be better to choose something else for portability.

__FBSDID is reserved too, so #defining it already gives undefined
behaviour :-).

Bruce