From owner-freebsd-net Sun Dec 31 12: 7:52 2000 From owner-freebsd-net@FreeBSD.ORG Sun Dec 31 12:07:49 2000 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from freesbee.wheel.dk (freesbee.wheel.dk [193.162.159.97]) by hub.freebsd.org (Postfix) with ESMTP id 66CF737B400; Sun, 31 Dec 2000 12:07:48 -0800 (PST) Received: by freesbee.wheel.dk (Postfix, from userid 1001) id CBB053E4B; Sun, 31 Dec 2000 21:07:46 +0100 (CET) Date: Sun, 31 Dec 2000 21:07:46 +0100 From: Jesper Skriver To: Don Lewis Cc: Kris Kennaway , Poul-Henning Kamp , security-officer@FreeBSD.ORG, cvs-all@FreeBSD.ORG, freebsd-net@FreeBSD.ORG Subject: Re: what to do now ? Was: cvs commit: src/sys/netinet ip_icmp.c tcp_subr.c tcp_var.h Message-ID: <20001231210746.A81834@skriver.dk> References: <20001218182600.C1856@skriver.dk> <20001219222730.A29741@skriver.dk> <200012201046.CAA19456@salsa.gv.tsc.tdk.com> <20001220155118.N81814@skriver.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20001220155118.N81814@skriver.dk>; from jesper@skriver.dk on Wed, Dec 20, 2000 at 03:51:18PM +0100 Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Wed, Dec 20, 2000 at 03:51:18PM +0100, Jesper Skriver wrote: > On Wed, Dec 20, 2000 at 02:46:21AM -0800, Don Lewis wrote: > > > } @@ -714,6 +715,15 @@ > > } (lport && inp->inp_lport != lport) || > > } (laddr.s_addr && inp->inp_laddr.s_addr != laddr.s_addr) || > > } (fport && inp->inp_fport != fport)) { > > } + inp = inp->inp_list.le_next; > > } + continue; > > > > Wouldn't it be more cleaner (gets rid of the loop) and more efficient (if > > we're getting blasted with ICMP messages) to use in_pcblookup_hash()? > > I didn't change the loop, but I'll have a look at this code, to see if > we can improve it, but again, to get moving, I'd like to commit this, > and leave this for a later improvement, ok ? I've looked at this, and as far as I can see we cannot use in_pcblookup_hash, as it lookup a single session, and the code can in other cases act on multiple sessions, path MTU discovery is such a case. /Jesper -- Jesper Skriver, jesper(at)skriver(dot)dk - CCIE #5456 Work: Network manager @ AS3292 (Tele Danmark DataNetworks) Private: Geek @ AS2109 (A much smaller network ;-) One Unix to rule them all, One Resolver to find them, One IP to bring them all and in the zone to bind them. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message