Date: Tue, 3 Jul 2007 21:21:44 +0100 From: Shaun Amott <shaun@FreeBSD.org> To: "Michael W. Lucas" <mwlucas@blackhelicopters.org> Cc: ports@freebsd.org Subject: Re: My First Port Message-ID: <20070703202143.GA24072@charon.picobyte.net> In-Reply-To: <20070703182834.GA70894@bewilderbeast.blackhelicopters.org> References: <20070703182834.GA70894@bewilderbeast.blackhelicopters.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 03, 2007 at 02:28:34PM -0400, Michael W. Lucas wrote: > > I would appreciate any comments, critiques, etc., before I submit > this. (Or, if you ports guys would rather I submit it as-is and then > tell me all the things I did wrong, I'm OK with that too.) While I'm > not a ports guy, I'm willing to try to maintain this. > A few minor observations: 1) You're missing the standard header block. 2) There's a trailing space on the COMMENT line. 3) Instead of setting EXTRACT_SUFX, we have a special variable for bzip2 files: USE_BZIP2= yes Otherwise, it looks good. Shaun -- Shaun Amott // PGP: 0x6B387A9A "A foolish consistency is the hobgoblin of little minds." - Ralph Waldo Emerson
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070703202143.GA24072>