From owner-cvs-src@FreeBSD.ORG Mon May 21 19:07:32 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C592716A400; Mon, 21 May 2007 19:07:32 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.freebsd.org (Postfix) with ESMTP id 7E4D213C44C; Mon, 21 May 2007 19:07:32 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id AF1082086; Mon, 21 May 2007 21:07:28 +0200 (CEST) X-Spam-Tests: AWL X-Spam-Learn: disabled X-Spam-Score: 0.0/3.0 X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on tim.des.no Received: from dwp.des.no (des.no [80.203.243.180]) by smtp.des.no (Postfix) with ESMTP id 9F26B2083; Mon, 21 May 2007 21:07:28 +0200 (CEST) Received: by dwp.des.no (Postfix, from userid 1001) id 8818D577A; Mon, 21 May 2007 21:07:28 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Doug Barton References: <200705211144.l4LBiEHY098477@repoman.freebsd.org> <4651E084.1020605@FreeBSD.org> <86zm3yghuf.fsf@dwp.des.no> <4651E90D.8030001@FreeBSD.org> Date: Mon, 21 May 2007 21:07:28 +0200 In-Reply-To: <4651E90D.8030001@FreeBSD.org> (Doug Barton's message of "Mon\, 21 May 2007 11\:46\:37 -0700") Message-ID: <86veemgfm7.fsf@dwp.des.no> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, "Ralf S. Engelschall" , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/rc.d hostid X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2007 19:07:32 -0000 Doug Barton writes: > Dag-Erling Sm=C3=B8rgrav writes: > > Doug Barton writes: > > > Meanwhile, I've attached a patch that simplifies the hostid_hardware() > > > quite a bit, and has the added virtue of only calling csh if it's > > > needed. > > It also fails to ensure that the UUID has the correct syntax. > If we're really concerned that this could be a problem (and I don't > know enough about it to comment) then feel free to wrap a syntax test > around the last echo. What I'm trying to do is simplify the routine, > and allow obviously bogus responses to be rejected with cheap tests. > > Given that this thing is on by default, and that people are always > complaining that rc.d stuff runs too slow, we need to be a little more > careful to do it well, rather than just good enough. The current code correctly checks for a syntactically correct UUID. Your proposed replacement does not. I fail to see how that qualifies as "doing well rather than just good enough" DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no