Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 10 Nov 2019 19:29:07 +0300
From:      Max Brazhnikov <makc@freebsd.org>
To:        Piotr Kubaj <pkubaj@anongoth.pl>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r517126 - head/cad/librecad
Message-ID:  <1895192.4WAli8B44Z@mercury.ph.man.ac.uk>
In-Reply-To: <20191110121847.GA1240@KGPE-D16>
References:  <201911091301.xA9D1GwQ033178@repo.freebsd.org> <2953745.bT80LyP3VS@mercury.ph.man.ac.uk> <20191110121847.GA1240@KGPE-D16>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 10 Nov 2019 13:18:49 +0100 Piotr Kubaj wrote:
> It seems it's a known issue, reported here https://github.com/LibreCAD/LibreCAD/issues/1130
> 
> Do you find this patch acceptable?

Fine for me

> Index: /usr/ports/cad/librecad/Makefile
> ===================================================================
> --- /usr/ports/cad/librecad/Makefile    (revision 517201)
> +++ /usr/ports/cad/librecad/Makefile    (working copy)
> @@ -5,8 +5,10 @@
>  PORTREVISION=  10
>  CATEGORIES=    cad
> 
> -PATCH_SITES=   https://github.com/LibreCAD/LibreCAD/commit/
> -PATCHFILES=    d0a0ef284b7fcc5c0d65b92c30855f62b637653f.patch:-p1
> +PATCH_SITES_gcc= https://github.com/LibreCAD/LibreCAD/commit/
> +PATCH_SITES=   ${PATCH_SITES_${CHOSEN_COMPILER_TYPE}}
> +PATCHFILES_gcc=        d0a0ef284b7fcc5c0d65b92c30855f62b637653f.patch:-p1
> +PATCHFILES=    ${PATCHFILES_${CHOSEN_COMPILER_TYPE}}
> 
>  MAINTAINER=    jhale@FreeBSD.org
>  COMMENT=       2D CAD system
> 
> On 19-11-10 13:54:41, Max Brazhnikov wrote:
> > On Sat, 9 Nov 2019 13:01:16 +0000 (UTC) Piotr Kubaj wrote:
> > > Author: pkubaj
> > > Date: Sat Nov  9 13:01:16 2019
> > > New Revision: 517126
> > > URL: https://svnweb.freebsd.org/changeset/ports/517126
> > > 
> > > Log:
> > >   cad/librecad: fix build on GCC architectures
> > >   
> > >   Merge upstream patch to fix build with GCC.
> > >   
> > >   PR:		241496
> > >   Approved by:	jhale (maintainer timeout), linimon (mentor)
> > > 
> > > Modified:
> > >   head/cad/librecad/Makefile
> > >   head/cad/librecad/distinfo
> > > 
> > > Modified: head/cad/librecad/Makefile
> > > ==============================================================================
> > > --- head/cad/librecad/Makefile	Sat Nov  9 12:44:25 2019	(r517125)
> > > +++ head/cad/librecad/Makefile	Sat Nov  9 13:01:16 2019	(r517126)
> > > @@ -5,6 +5,9 @@ DISTVERSION=	2.2.0-rc1
> > >  PORTREVISION=	10
> > >  CATEGORIES=	cad
> > >  
> > > +PATCH_SITES=	https://github.com/LibreCAD/LibreCAD/commit/
> > > +PATCHFILES=	d0a0ef284b7fcc5c0d65b92c30855f62b637653f.patch:-p1
> > 
> > Hi Piotr,
> > 
> > the port doesn't build on stable after this commit. Revering the change helps.
> > 
> > Max
> > 
> > 







Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1895192.4WAli8B44Z>