From nobody Sat Feb 1 12:58:57 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YlXrj6kGqz5n5Sr; Sat, 01 Feb 2025 12:59:01 +0000 (UTC) (envelope-from bz@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YlXrj642sz3Kfj; Sat, 01 Feb 2025 12:59:01 +0000 (UTC) (envelope-from bz@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738414741; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3oBmiJQtrfaTfhWHB8eunMTMtlaEpkcTln/8c8MfbLA=; b=mXMr6g8TT8XeltBijo2a5CEOxDOnRUnwsCdt7s6HlBR8A/+SHvOoFCRHumvXf/vQpHWIEb byiiFmUDfICuYHn1ZtteAE44pk0M8BRLsdHYNawRSKNsTPRcC8UrwUfUhzv0dsIhY5H21z 8+aj6GlJpTJOZ9P0a11P7S31ziv7SRX4GfxlOW7OF8ZB3HzmSQmZ2WVD3oVMzOnr2+eEKu c1Md92XtAgsFREWp3G39g91wzZKf22NajO0E0INA/z2p43o9tSJcYVFLVq8U5hfTXQCC8Y cXqeG6cv+BEw37/KbLzMYZ4xma7cEg2cm9ysTVlSeJ2dsfu4UcBKByYuHEcfaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738414741; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3oBmiJQtrfaTfhWHB8eunMTMtlaEpkcTln/8c8MfbLA=; b=RXlOw2iP4cCmZpk+tOgxXJ6PG3Eqi39ZmQsmg0Bk+Wea8y9E0KwvikmY3OBURICkcPPBK2 bAwq160OFZFKsnZKZ79jeBMZwHbX3r9wgT8z7mn1pQAXmHEYsrYIW5v7JJBOilRhV5QdAC WxlZC2rh8vz78iJMOjTJAFY4j21nVOdk+aAAf4v5wqDHkVPzQ4iPSGlMRQRzo02af3LSOI EIYiX49jGFetf8MrnQFm6c8uc6DahDy01OCi1l3CoMdahtHLE1Mdx3wQLDUu6b1RXsB1ft hXLP9CPRiH7o1EuCOc657krlTMLKgUfYsAJFuTPKrQbpCHwJKEphHUpwAGFJfA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738414741; a=rsa-sha256; cv=none; b=ELKwvGn2Q1CYIaHMl6oX3F5cTj/T1J+qezN840p44SnKDazqUWv/eFg/Y9WHIB0hLdbTYz R8a4GLYqMs/28CWsVouQ6/mInm0Uc+GRH5JqcQ81Yj0CSTeBD5UoNJBTUS6FOWJ7oxDAKX F5be2F33uqjm/ytxxEFNNICfNNJA1WC4yJtRmfrPxcJA0RViYCQY6XxzyuQsU49S+fTUQK 0K76BkWrH+LQjXI0F9qW8jL5ZpzDT/w4kKF/q1NKwaaYC9yNmQ3fdjyHSk3smoDZ0hJM5B 6CM4PHZBa/aNj00AKaEV6/ZVFqhcQBO02p9MI5sd/oPIB4gAe9rzvRoFZYEr2Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from mx-01.divo.sbone.de (mx-01.divo.sbone.de [IPv6:2003:a:140a:2200:6:594:fffe:19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "E6" (verified OK)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4YlXrj4TTSz17YG; Sat, 01 Feb 2025 12:59:01 +0000 (UTC) (envelope-from bz@freebsd.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id 5E411A64805; Sat, 01 Feb 2025 12:58:59 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 9F2492D029DD; Sat, 1 Feb 2025 12:58:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id tmou9tVWfYOY; Sat, 1 Feb 2025 12:58:58 +0000 (UTC) Received: from strong-iwl0.sbone.de (strong-iwl0.sbone.de [IPv6:fde9:577b:c1a9:4902:b66b:fcff:fef3:e3d2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 7D0982D029D8; Sat, 1 Feb 2025 12:58:58 +0000 (UTC) Date: Sat, 1 Feb 2025 12:58:57 +0000 (UTC) From: "Bjoern A. Zeeb" To: Gleb Smirnoff cc: Adrian Chadd , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 0f1bf1c22a0c - main - umb: Introduce the USB umb(4) network driver In-Reply-To: Message-ID: <4n0s7403-2177-581r-s0qn-q5psor42no8s@serrofq.bet> References: <202501202347.50KNleC1038560@gitrepo.freebsd.org> <859rn769-r59r-71q6-qoqs-90ps5qps488p@SerrOFQ.bet> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed On Fri, 31 Jan 2025, Gleb Smirnoff wrote: > On Fri, Jan 31, 2025 at 08:16:53PM -0800, Adrian Chadd wrote: > A> > > commit 0f1bf1c22a0c97e84a4db19197a75952487aa20b > A> > > Author: Adrian Chadd > A> > > AuthorDate: 2025-01-20 23:46:15 +0000 > A> > > Commit: Adrian Chadd > A> > > CommitDate: 2025-01-20 23:46:15 +0000 > A> > > > A> > > umb: Introduce the USB umb(4) network driver > A> > > A> > Still breaks at least: > A> > amd64 MINIMAL kernel failed, check _.amd64.MINIMAL for details > A> > amd64 MINIMALUP kernel failed, check _.amd64.MINIMALUP for details > A> > A> It wasn't broken when it landed, I did a universe pass. > > This is not related to Adrian's changes, but to 1111a44301da39d7b7459c784230e1405e8980f8. > > I have the patch in my queue, waiting for universe. Sorry. My fault. umb only has an unused function in the default compile settings due to a missing #ifdef DEV_NETMAP. 24 1 warning generated. 25 /tank/users/bz/git/FreeBSD/freebsd-src/sys/dev/usb/net/if_umb.c:848:1: warning: unused function 'umb_input' [-Wunused-function] 26 848 | umb_input(if_t ifp, struct mbuf *m) 27 | ^~~~~~~~~ -- Bjoern A. Zeeb r15:7