From owner-svn-src-head@FreeBSD.ORG Mon Jul 21 02:56:08 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0D63A60F; Mon, 21 Jul 2014 02:56:08 +0000 (UTC) Received: from smtp1.multiplay.co.uk (smtp1.multiplay.co.uk [85.236.96.35]) by mx1.freebsd.org (Postfix) with ESMTP id C46342932; Mon, 21 Jul 2014 02:56:07 +0000 (UTC) Received: by smtp1.multiplay.co.uk (Postfix, from userid 65534) id C560320E7088C; Mon, 21 Jul 2014 02:56:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.multiplay.co.uk X-Spam-Level: ** X-Spam-Status: No, score=2.0 required=8.0 tests=AWL,BAYES_00,DOS_OE_TO_MX, FSL_HELO_NON_FQDN_1,HELO_NO_DOMAIN,RDNS_DYNAMIC autolearn=no version=3.3.1 Received: from r2d2 (82-69-141-170.dsl.in-addr.zen.co.uk [82.69.141.170]) by smtp1.multiplay.co.uk (Postfix) with ESMTPS id 6ECE220E7088A; Mon, 21 Jul 2014 02:56:02 +0000 (UTC) Message-ID: <09AF6051EC3848B6B691A5570B5B065E@multiplay.co.uk> From: "Steven Hartland" To: "Nikolai Lifanov" , "Xin LI" References: <201407182041.s6IKffMR077972@svn.freebsd.org> <5d0810f5950150ef60044acf239adb4a@mail.lifanov.com> Subject: Re: svn commit: r268855 - in head: cddl/contrib/opensolaris/cmd/ztest sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys Date: Mon, 21 Jul 2014 03:56:00 +0100 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=response Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.5931 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Cc: svn-src-head@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2014 02:56:08 -0000 ----- Original Message ----- From: "Nikolai Lifanov" To: "Xin LI" Cc: ; Sent: Monday, July 21, 2014 2:22 AM Subject: Re: svn commit: r268855 - in head: cddl/contrib/opensolaris/cmd/ztest sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys > On 2014-07-18 16:41, Xin LI wrote: >> Author: delphij >> Date: Fri Jul 18 20:41:40 2014 >> New Revision: 268855 >> URL: http://svnweb.freebsd.org/changeset/base/268855 >> >> Log: >> MFV r268848: >> >> Instead of asserting all zio's be properly aligned, only assert >> on the logical ones. >> >> Cap uberblocks at 8k, otherwise with ashift=17, there would be >> only one uberblock. >> >> This fixes a problem that zdb would trip assert on pools with >> ashift >= 0xe (8k). >> >> While there, also change the code so it only attempt to condense >> space map unless the uncondensed size consumes greater than >> zfs_metaslab_condense_block_threshold blocks. >> >> Illumos issue: >> 4958 zdb trips assert on pools with ashift >= 0xe >> >> MFC after: 2 weeks >> > > This specific commit makes boot hang just before mounting the root dataset for me when vfs.zfs.vdev.cache.size tunable is set. > Unsetting this tunable or reverting this commit (currently running r268933 minus r268855) fixes the boot for me. > > Please let me know if I can provide any more information. Interesting, is there a reason you enabled vdev caching as its been disabled by default for quite some time with the comment: * TODO: Note that with the current ZFS code, it turns out that the * vdev cache is not helpful, and in some cases actually harmful. It * is better if we disable this. Once some time has passed, we should * actually remove this to simplify the code. For now we just disable * it by setting the zfs_vdev_cache_size to zero. Note that Solaris 11 * has made these same changes. Regards Steve