From owner-svn-src-all@freebsd.org Sun Oct 1 20:37:24 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 17648E2E020; Sun, 1 Oct 2017 20:37:24 +0000 (UTC) (envelope-from ohartmann@walstatt.org) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 881A36E0CD; Sun, 1 Oct 2017 20:37:23 +0000 (UTC) (envelope-from ohartmann@walstatt.org) Received: from thor.intern.walstatt.dynvpn.de ([78.53.138.91]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MX1dc-1dmbsM2ruW-00W0WN; Sun, 01 Oct 2017 22:37:14 +0200 Date: Sun, 1 Oct 2017 22:37:07 +0200 From: "O. Hartmann" To: Andriy Gapon Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r324178 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua Message-ID: <20171001223707.574cde55@thor.intern.walstatt.dynvpn.de> In-Reply-To: <201710012012.v91KCUvU024559@repo.freebsd.org> References: <201710012012.v91KCUvU024559@repo.freebsd.org> Organization: WALSTATT User-Agent: OutScare 3.1415926 X-Operating-System: ImNotAnOperatingSystem 3.141592527 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/gUatc3cd7sv0Nvvw5jqFa6W"; protocol="application/pgp-signature" X-Provags-ID: V03:K0:pba9SuM1jreTa2fIn17UsIW6NpCBzM7+D8Zbqh8+/myZPJtKh+h pMksc0musYBHyCzBZkXAobEE5eSyJRRQ8JUrf1AxrGyAe5avrRqYYS2jYEOT5dfxCEEcgg7 LkAo/U7TtbCmPkaoMAN4thdQFL7c9etdtd15ychEFaK02uSYlFNp3WmWVm2P1MrL4NGI6c9 UYR+gcmell/dUZR7Sl/Pw== X-UI-Out-Filterresults: notjunk:1;V01:K0:CjSsEtgPgLo=:u/zVRe9hnEqYxQbfmFO/TN WJ9X4USWjg6K1xQQBPKhVqzbGWEZ/crAQq3aWY7bWcWusB0PNT3Hg2dKmwcRR/M6pXVYIgqYx 4VjykJhVyya4iLkgIurOTvsBRin4M2XROym0fQwMc+ZOocioLLqb/s6k0ulqvAheCAHML3MH9 36yNXekriH8JdS5xMTIQ4DZtGNj9Jec5hnDrSFP8G+f+LeR+64kf21nZIL0jPn6pRPR2dL3oY HvHyeTmx9UQGyZTqsKKJkvSoKs31iY03ktfzADlr5wXFeUJiENw3QHP3JmdV/IbJtGg54JHJX Hb2YN0XMeXF/YxII8InRemfcG1ragNy5gG2ALgyBT7/Ns0YOEhSGpr1q91lPmv7JipfOdZRX8 USgWSlK6y3LKKf0B0X2yrGkxYFvISlZOS4bU5NndZjmN8BCKZ0wEdRxLxvvESNgyA9uKOCFbI NhryczXTFVHTPw5UfYK//MyBiIiYOcGSGsFnylkLVt5y/F4aymSJbkIBVWFQiIjk3fsYvNHcO Aem2JCihJssCv3lCAhXQGT9HllcJiwbVKdRlleiZzI3xCEHIEqbunXjf27APViSjlFNcptisn oy0ycgauCdcGJsQ8m/sBKB0Tj0GtHGYV77OGctLhv1sVv/xzan2GTgqEH8f5QhoyLoD7AWbyK 1nYm2ldK5szkB5B+qQ5kO8TFkYdnzoERN2EHl9o28e0Cx7DZVVsBwcuxza8DVQx4aMTqaStCa Ni2tvi7iWK60EuLhs7Z0RDYJ6qM8QBBgWYTO7z3UNprbGPI4AFtLLu/LkLHi3dA/LNKmabeB0 Kf2R5OxU4G6r1+ZQ6+mc3pprYVadQ== X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Oct 2017 20:37:24 -0000 --Sig_/gUatc3cd7sv0Nvvw5jqFa6W Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am Sun, 1 Oct 2017 20:12:30 +0000 (UTC) Andriy Gapon schrieb: > Author: avg > Date: Sun Oct 1 20:12:30 2017 > New Revision: 324178 > URL: https://svnweb.freebsd.org/changeset/base/324178 >=20 > Log: > unbreak kernel builds on sparc64 and powerpc after r324163, ZFS Channel= Programs > =20 > The custom iscntrl() in ZFS Lua code expects a signed argumnet, so > remove the harmful cast. > =20 > Reported by: ian > MFC after: 5 weeks > X-MFC with: r324163 >=20 > Modified: > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua/lstrlib.c >=20 > Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua/lstrlib= .c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua/lstrlib.c Sun= Oct 1 > 19:52:47 2017 (r324177) +++ > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua/lstrlib.c Sun Oct= 1 > 20:12:30 2017 (r324178) @@ -867,7 +867,7 @@ static void addquoted (lua_St= ate *L, > luaL_Buffer *b, i luaL_addchar(b, '\\'); luaL_addchar(b, *s); > } > - else if (*s =3D=3D '\0' || iscntrl(uchar(*s))) { > + else if (*s =3D=3D '\0' || iscntrl(*s)) { > char buff[10]; > if (!isdigit(uchar(*(s+1)))) > sprintf(buff, "\\%d", (int)uchar(*s)); > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" The build of world fails for me with the error shown below: [...] Building /usr/obj/usr/src/cddl/lib/libzpool/lapi.o --- lstrlib.o --- /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua/lstrlib.c:114:1= 2: warning: implicitly declaring library function 'tolower' with type 'int (int)' [-Wimplicit-function-declaration] p[i] =3D tolower(uchar(s[i])); ^ /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua/lstrlib.c:114:1= 2: note: include the header or explicitly provide a declaration for 'tolower' /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua/lstrl= ib.c:127:12: warning: implicitly declaring library function 'toupper' with type 'int (int)' [-Wimplicit-function-declaration] p[i] =3D toupper(uchar(s[i])); --=20 O. Hartmann Ich widerspreche der Nutzung oder =C3=9Cbermittlung meiner Daten f=C3=BCr Werbezwecke oder f=C3=BCr die Markt- oder Meinungsforschung (=C2=A7 28 Abs.= 4 BDSG). --Sig_/gUatc3cd7sv0Nvvw5jqFa6W Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iLUEARMKAB0WIQQZVZMzAtwC2T/86TrS528fyFhYlAUCWdFR8wAKCRDS528fyFhY lO+3AgCG98hzR6klneCBzM9ESDen+hDdR3X+1R8j495xxBIQVYaycVpmGtja2ZGm lujaRHd4WMXP/jEwU6bTsEd26ribAf9ebi8MdvsX/Dx6kIazaspOT0plWZFew07j tR9MtRWCSX0AMfDitTU+WY2Ktomgk73wAATnVnZ5WAjgtiQhww8s =C3W6 -----END PGP SIGNATURE----- --Sig_/gUatc3cd7sv0Nvvw5jqFa6W--