From owner-svn-src-all@FreeBSD.ORG  Sun Jan 15 05:58:35 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B105F106564A;
	Sun, 15 Jan 2012 05:58:35 +0000 (UTC)
	(envelope-from lists@eitanadler.com)
Received: from mail-lpp01m010-f54.google.com (mail-lpp01m010-f54.google.com
	[209.85.215.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 941688FC0C;
	Sun, 15 Jan 2012 05:58:34 +0000 (UTC)
Received: by lahd3 with SMTP id d3so1404946lah.13
	for <multiple recipients>; Sat, 14 Jan 2012 21:58:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=eitanadler.com; s=0xdeadbeef;
	h=mime-version:in-reply-to:references:from:date:message-id:subject:to
	:cc:content-type:content-transfer-encoding;
	bh=NM0rLOtQ5SdJTPho9DMVgTkERjbhdxcfb5m+rTzHBX4=;
	b=PuVwXtDukkrNoPhN0nCJXkKq975B5l9WIBT2Ku7EZCcij/lO4GfyBfiZz9tk0NSRZ/
	3vsXUrt804ufc5v5zECwixxyZhQksbOPRmNtgmQY+gUFVsZtSYx0lepJ4m6rCqmcTTyy
	ofC5YZM+gsAwyFR8k19Zg3b+EZ7o2lSj5uDV0=
Received: by 10.152.106.227 with SMTP id gx3mr3459325lab.45.1326607113241;
	Sat, 14 Jan 2012 21:58:33 -0800 (PST)
MIME-Version: 1.0
Received: by 10.112.18.227 with HTTP; Sat, 14 Jan 2012 21:58:02 -0800 (PST)
In-Reply-To: <201201142246.q0EMkI6P052011@svn.freebsd.org>
References: <201201142246.q0EMkI6P052011@svn.freebsd.org>
From: Eitan Adler <lists@eitanadler.com>
Date: Sun, 15 Jan 2012 00:58:02 -0500
Message-ID: <CAF6rxgnw-duMzh540D_ZNmhsdRb2h7gB0JN0j693XLyUoj0Rvw@mail.gmail.com>
To: Jilles Tjoelker <jilles@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r230118 - head/bin/sh
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Jan 2012 05:58:35 -0000

On Sat, Jan 14, 2012 at 5:46 PM, Jilles Tjoelker <jilles@freebsd.org> wrote=
:
> Author: jilles
> Date: Sat Jan 14 22:46:18 2012
> New Revision: 230118
> URL: http://svn.freebsd.org/changeset/base/230118
>
> Log:
> =C2=A0sh: Change input buffer size from 1023 to 1024.
>
> =C2=A0PR: =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 bin/161756

On Wed Oct 19 22:33:38 UTC 2011 you said in the PR:

Although this change looks like an improvement, it does not seem
fully satisfying. I would like to see performance numbers for the
change on your slow embedded platform. Also, why use 1023 or 1024?
Another buffer size may be better.

But the PR does not seem to answer the question. Can you explain why
you decided to act on the PR now?

--=20
Eitan Adler