From owner-svn-ports-all@freebsd.org  Fri Dec 29 16:16:02 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2BF9DEA3527;
 Fri, 29 Dec 2017 16:16:02 +0000 (UTC)
 (envelope-from emaste@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id EAE266FE0B;
 Fri, 29 Dec 2017 16:16:01 +0000 (UTC)
 (envelope-from emaste@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id vBTGG0Qo098630;
 Fri, 29 Dec 2017 16:16:00 GMT (envelope-from emaste@FreeBSD.org)
Received: (from emaste@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id vBTGG0OG098629;
 Fri, 29 Dec 2017 16:16:00 GMT (envelope-from emaste@FreeBSD.org)
Message-Id: <201712291616.vBTGG0OG098629@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: emaste set sender to
 emaste@FreeBSD.org using -f
From: Ed Maste <emaste@FreeBSD.org>
Date: Fri, 29 Dec 2017 16:16:00 +0000 (UTC)
To: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: svn commit: r457511 - head/multimedia/xine
X-SVN-Group: ports-head
X-SVN-Commit-Author: emaste
X-SVN-Commit-Paths: head/multimedia/xine
X-SVN-Commit-Revision: 457511
X-SVN-Commit-Repository: ports
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Dec 2017 16:16:02 -0000

Author: emaste (src committer)
Date: Fri Dec 29 16:16:00 2017
New Revision: 457511
URL: https://svnweb.freebsd.org/changeset/ports/457511

Log:
  multimedia/xine: set LLD_UNSAFE to avoid lld
  
  xine relies on ld.bfd's permissive treatment of shared library symbols
  with protected visibility, and attempting to link with lld fails with
  errors like:
  
  /usr/bin/ld: error: cannot preempt symbol: xine_usec_sleep
  >>> defined in /usr/local/lib/libxine.so
  >>> referenced by actions.c
  >>>               actions.o:(wait_for_window_visible)
  
  For now set LLD_UNSAFE=yes so that the port will continue to link with
  ld.bfd if /usr/bin/ld is lld, until the issue can be addressed (with a
  change in libxine or in lld).
  
  PR:		214864
  Approved by:	portmgr (LLD_UNSAFE blanket)
  Sponsored by:	The FreeBSD Foundation

Modified:
  head/multimedia/xine/Makefile

Modified: head/multimedia/xine/Makefile
==============================================================================
--- head/multimedia/xine/Makefile	Fri Dec 29 15:47:00 2017	(r457510)
+++ head/multimedia/xine/Makefile	Fri Dec 29 16:16:00 2017	(r457511)
@@ -27,6 +27,7 @@ INSTALLS_ICONS=	yes
 
 CPPFLAGS+=	-I${LOCALBASE}/include
 LDFLAGS+=	-L${LOCALBASE}/lib
+LLD_UNSAFE=	yes	# lld disallows preemption of protected visibility syms
 
 DOCSDIR=	${PREFIX}/share/doc/xine-ui