From nobody Wed Feb 8 19:53:58 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PBrKf70XPz3p9ZB for ; Wed, 8 Feb 2023 19:53:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PBrKf5ShQz3Hw5 for ; Wed, 8 Feb 2023 19:53:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675886038; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PVwuLgXUcJWTWyk0Om3xIX81d6vN6PRIsMgR7si36+8=; b=l8VAs0mtSEV5PhiMGGw39K+Klae/6htNhwFovPYDRo78iibZFg0oV41L3C148iwQWSREs2 8GpKuq/BW65F3EoYTQn2Id2z+xA3Cgm0kA0z6zJYlQgR4I7iIAD+bS/h1Z8pkhcwkPM/Ry QQCUg1q9BSlHAZ7p02mExPFvOMhMa8aWlsWzHsQFg+TVJhpnph4q2splvAo8JXSzjqN2aS fcsAMzdxq3SquSTJPOaqvB7LdLuLSi375t8ZuM3hpkJ4+mGBdby7fsAVquCDhabBGfaBvL OLUnAwRTVMUosZ/lqMlN53CiX5xsE0Cn4Dc/RT93AfTISf8/4n17RGxrTydbOg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1675886038; a=rsa-sha256; cv=none; b=st8RC34GUGRtGFNDx/zZNRa/syW72Y+qlRvo3/5tSqhWh9xvtIf/r9Ou6/Wah/dOPup+tS Sl2Mu6bfHl0IB6zycSFIXW76lPZM0eEUIUfryZ0bCABOQgPWqW47alelSNJ2HyCOYzLXoi pJ4ibWz+/geQx5VMYAbrY1k6qA+5XbDFcGwLPab/9zKm413PmIEUTjnklJiRcJNX25f6cA fsdsBMTvbRzlJ+pyoRAFoadBNemx2m+rVa7rCYG4R7cNBMzMIHj4okeorKCTFqalKl2pkL HSwkKs9WGY8FSq7NZE6Vdmgfo88XlNAXOGZKDcYBQpYDA1f6m1SLkQ/B45uI1Q== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PBrKf4WCKz18dY for ; Wed, 8 Feb 2023 19:53:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 318Jrw6F035216 for ; Wed, 8 Feb 2023 19:53:58 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 318Jrw66035215 for bugs@FreeBSD.org; Wed, 8 Feb 2023 19:53:58 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 269418] ice(4): strips VLAN headers with netmap Date: Wed, 08 Feb 2023 19:53:58 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.4-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: brian90013@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269418 Bug ID: 269418 Summary: ice(4): strips VLAN headers with netmap Product: Base System Version: 12.4-RELEASE Hardware: amd64 OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: brian90013@gmail.com Hello, I am testing the E810 NIC on FreeBSD 12.4 using netmap and observe VLAN hea= ders are stripped from incoming packets. I have -vlanhwtag set on the interface (though below I show why this doesn't matter). I tested this scenario with = the same server, OS, and capture file using the e1000, ixgbe, and ixl drivers a= nd all three kept the VLAN headers when using netmap with -vlanhwtag set on the interface. A quick look at ice_set_default_vsi_ctx() shows ICE_AQ_VSI_INNER_VLAN_EMODE_STR_BOTH is set in all cases. There are no conditionals using IFCAP_VLAN_HWTAGGING in the ice driver. I would expect t= he code to check for that capability and set ICE_AQ_VSI_INNER_VLAN_EMODE_NOTHI= NG if -vlanhwtag like ixl does in ixl_initialize_vsi(). I tried adding a conditional check but ran into the next issue. ixl_initialize_vsi() is called from ixl_if_init() so it reinitializes the V= LAN setting every time iflib_if_ioctl() is run. On the ice driver, ice_initialize_vsi() is called from ice_if_attach_post() and ice_rebuild() = but not ice_if_init(). So changing the VLAN capabilities using ifconfig doesn't appear to change the driver settings. I would like the ice driver to preserve VLAN headers when using netmap just like the other Intel iflib drivers. I have experimented with adding a call = to ice_initialize_vsi() inside ice_if_init(), but there are other changes need= ed and I am looking for a solution with no side effects. Thank you for your ti= me and your help! --=20 You are receiving this mail because: You are the assignee for the bug.=