From owner-dev-commits-ports-all@freebsd.org Thu Apr 22 10:56:52 2021 Return-Path: Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E11825EB584; Thu, 22 Apr 2021 10:56:52 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FQvW866Sjz3jyt; Thu, 22 Apr 2021 10:56:52 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1619089012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VgdqKUnelneqG5yRUZ8oTHGZ6r3If9694vaowyzv684=; b=q04Qce28fDmyUSi2uH1tWXcDaOknBZPl/1Y5zVW3hGc3ae6oreJiE/a5JV+NQPuFmH5GQE yLghMn4yJMuDPuZkHBBnptmJsvFb/gVns0lF3COwM4c7rR9HopWg+6VWBp5B1u0YWWXR/B wUZkIzqDwafnVLyOnwbXamkU3YsItrG2/MJ9cxQrYTnzzQ2rOq9/X3Kvcuw6fifmHkWy74 EpM54Fyin0VqteCsvFwLmJOc7evyJcBKEEq9Lhwj75Hjh21vLhFJNCCMp+heJggkkUx9Vt QiBvBFH/EX0GO/2hybiPu0+ACAmPJb95qv23W9GMDeDnvBesp8FJU4HR8CvQlw== Received: by freefall.freebsd.org (Postfix, from userid 1033) id C4C9425A3B; Thu, 22 Apr 2021 10:56:52 +0000 (UTC) Date: Thu, 22 Apr 2021 10:56:52 +0000 From: Alexey Dokuchaev To: Mathieu Arnold Cc: Michael Gmelin , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 5b7c17856512 - main - git hooks: Rework authorship instructions. Message-ID: References: <20210422101616.c3i7dn6gfm6hhner@aching.in.mat.cc> <20210422104914.d3kwtrwl2jovwvu2@aching.in.mat.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210422104914.d3kwtrwl2jovwvu2@aching.in.mat.cc> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1619089012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VgdqKUnelneqG5yRUZ8oTHGZ6r3If9694vaowyzv684=; b=Hyayouim6/3yIzh1uQgagyxfKDudV+fGcbOaY/NX8SaSm5qtoEbjJIrQumzQnbGAoD2mUg nLG6TspIpe8PJCUq8jPkYlX7d8gpxOzRwHG21A6ElKsZy1yzEncp+lCg9d0XkNFqWpDfJQ Pu8G2D5km9gg2B90fawhv4gJAU/8Cy+KNolBFB76bNhtgkdmuPEyWpFjjBuJdAzcVFFXPL RlZAUnO1xnAguibf9s3dzuKAt79XWbzQz5D10Rf54UAysxdXVlpBkhIye/CD3Q+AGW3A4P zla1yUDmYjHTQLa/ENW1MaX6lIeryW/wss6RUrNRe4QqoRPo3uBvW9d3F/5lZw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1619089012; a=rsa-sha256; cv=none; b=bLBHjOP/LMiGYnud3HIdndxSNnaqwA7kPiYDoHISNBqDP1Y9ZwyQ2zqIiq8gnXdw5mlrZQ GVwdXQov7EJfNuL3NeF656UNTGILp2EC6zulPrlofx990kMaujXkjPxGVxONCL7TmeZre/ 9khW891JXVRnga1IXow/tY7KqbD5PC9fZkSnsMAl1r+gRFaLOnLsfERy6HIBVcXvHuFOgz g8xn52l4MTQZR4uX8FVRa2zN55gSUPyaMoCA6kKEMFGP+gWPjz2WqqHOKhk5nSaj4YBwD/ 8C5IKEAMMYZsoc4tC6nz/neHtNeXGwWjK2vNS9URrNXOkfX80ojnClJD0oOvJQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: dev-commits-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Apr 2021 10:56:52 -0000 On Thu, Apr 22, 2021 at 12:49:14PM +0200, Mathieu Arnold wrote: > On Thu, Apr 22, 2021 at 10:43:46AM +0000, Alexey Dokuchaev wrote: > > On Thu, Apr 22, 2021 at 12:16:16PM +0200, Mathieu Arnold wrote: > > > On Thu, Apr 22, 2021 at 12:10:26PM +0200, Michael Gmelin wrote: > > > > ... > > > > I agree that author should only be used if a submission is applied > > > > unaltered (pull request/git patch). > > > > > > Submitted by has always been for submission that was unaltered (or only > > > slightly altered) if it was only the basis of the work, then "submitted > > > by" is not to be used, in those cases, reported by is the correct > > > choice. > > > > Not really, no. "PR:/Submitted by:" is canonical combination, yet most > > of us modify submitted patches because they almost always need more work. > > Then you are misusing Submitted by. Submitted by was supposed to be > used when you committed something that was, well, submitted by someone > else. If the work is yours, and that you based your work on someone > else's, then, it is not submitted by them. No: "submitted" literally means there was actionable submission, i.e. a patch. It could be good enough to be committed as is (rarely), or require various amounts of polishing. Regardless of its quality, it is still not merely a "report" as you would suggest. "Reports" are sent by portscout or pkg-fallout. ./danfe