From nobody Sat Jun 27 13:04:14 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gnXmw2p4vz6jXL7; Sat, 27 Jun 2026 13:04:16 +0000 (UTC) (envelope-from siva@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gnXmw1rpSz3LGw; Sat, 27 Jun 2026 13:04:16 +0000 (UTC) (envelope-from siva@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782565456; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RbACN5aOXZKAOH9+lXpp265IrP67eBhagTFCFMKBS6Y=; b=oKn7Obx8JxuOVK5/JkteQ87b3s5/W2vqNPdsB0qfgqWmfl4ncr2l1VfEIJNzksAhH4sL7B Nf8DN5qUsLeyYDmPHMRZGM+iaW6HQJVN6SJsGv8DuC8GD60ompIplrguA8zS/bPYa7NNDf KeUd83FVwwXqazVcUvnDxUvdLHLbBOOcs/460Ljs1hNdrLOXrTfvQPLRq01DhmKzTJvqkG UsG9PrgrfsLnCbvXvbN3q+eF8KznHEzWDUfW3MxBr3KvsJHowsK0TDCZnuUDY95TbTcl5a ox2YTDFXgaRrno7Hu2yjBHEQ0g8WIzKwRHSlERRkniRof7H/Yi2l248Ka6i5/Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782565456; a=rsa-sha256; cv=none; b=R2rwJ0AM/e5wfjVyQkS+iRUXb18dzWG+/G6zSTsDRRIgsdVYvVKBfBRZs2W+4yFuly0eWL wdoXYra7BPBBqBTy5/gkKsnN91rWBYqz5kJ9MoSWRch19+o1V74QCx5Jr0oPWJ0CqpkNo0 HYgSxMhq/4t4dOnU/S2T6AWEkFanW5hlNofKD2yCrwLzmfU3LSgV1nJV1T4ClGJ0YAUk6v gOEIJGJjVCgkCibEQMBBkjpZigttf17PLTOjm2MmemSkmPQxokYm5HOE9tsCy0kZNiYt+N Q8KvUQk6yXK/Q4uckonlmERJIgVRjBf2lcI+y7fI6h7jcdCoiUjP/wql6TF4ww== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782565456; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RbACN5aOXZKAOH9+lXpp265IrP67eBhagTFCFMKBS6Y=; b=IjE14J8Hy3XtEHi+ObuZ8ahd/8hPOkRa1UeXurAeDmp4T4DCaYSlneIK1ZXinYZI+6jVbx BxGbl4Zxyu1V2BGWKRA5e8MdzsJE9X0uxwjftL6hXvbBK2Mx8T0dHjDdQejjcAvGZxPMxC WG+Veoy22rLYpHgJEQiOWNwgXskzRFtr8GVLEpBcDEM2//UA4K/yc/x0aVHBhecY4UfADr nKSL+iZLv9QAHWOx+lmwLF1zUnV5GTHrHv1w8VvK8bSLDFf9R6XkRcN7CjilPvbBVbCGOl 4IyZLO3XrB8e5VLcLfzQ4S5pwp8MnD1zQGTt7DW3fBevrpwKF1Q3WNpnfmnyRA== Received: from localhost (unknown [IPv6:2606:6d00:f3a:e400:81d5:7f04:b887:71b1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: siva/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gnXmv5Hxlz11Gs; Sat, 27 Jun 2026 13:04:15 +0000 (UTC) (envelope-from siva@FreeBSD.org) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 27 Jun 2026 09:04:14 -0400 Message-Id: Subject: Re: git: 5b8c28adb829 - main - ping/tests: expect bell chars from stderr after initial status From: "Siva Mahadevan" Cc: , , To: =?utf-8?q?Dag-Erling_Sm=C3=B8rgrav?= X-Mailer: aerc 0.21.0 References: <6a3f0534.34ab3.7098834f@gitrepo.freebsd.org> <86bjcwdxet.fsf@ltc.des.dev> In-Reply-To: <86bjcwdxet.fsf@ltc.des.dev> On Sat Jun 27, 2026 at 66:00 UTC, Dag-Erling Sm=C3=B8rgrav wrote: > Siva Mahadevan writes: >> commit 5b8c28adb829b50fb8ac065637fa99f717858bab >> Author: Siva Mahadevan >> AuthorDate: 2026-06-26 12:22:57 +0000 >> Commit: Siva Mahadevan >> CommitDate: 2026-06-26 22:46:09 +0000 >> >> ping/tests: expect bell chars from stderr after initial status >> =20 >> After 141bb85798 and 8bda488114f3, ping(8) first writes and flushes = the >> initial status to stdout, then writes notification bell characters t= o stderr. >> =20 >> This patch corrects the expected order of the output to stdout and s= tderr. >> This is a temporary fix; the test should be rewritten to separate th= e output >> streams and run expectations on each individually. >> =20 >> Reviewed by: des >> MFC after: 3 days >> Sponsored by: The FreeBSD Foundation > > The change is correct, but the commit message is not, and reads like a > chatbot. Please revert and re-commit with a correct human-written log > message. I do not use LLMs or chatbots. I wrote this by hand. If it is incorrect, my apologies, but I'm not sure in which way. I wrote this from what I understood from the comments in the associated reviews[0][1]. Can you suggest a better commit message? And I'm not sure it warrants a revert and re-commit. [0] https://reviews.freebsd.org/D57765 [1] https://ron-dev.freebsd.org/FreeBSD/src/pulls/50