From owner-svn-src-all@freebsd.org Fri Apr 19 12:07:07 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4C8F2158EA2A; Fri, 19 Apr 2019 12:07:07 +0000 (UTC) (envelope-from oshogbo.vx@gmail.com) Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 35E41731C5; Fri, 19 Apr 2019 12:07:06 +0000 (UTC) (envelope-from oshogbo.vx@gmail.com) Received: by mail-lf1-x12c.google.com with SMTP id i68so3918365lfi.10; Fri, 19 Apr 2019 05:07:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jjqHxxVBIYetT13OgJJ0bw1na2r4Sk4JvFTnIF3BDLE=; b=eZd6ewxwvnGEaoNmTbv9rNK33dke5joIlLcW8P0OJi7hrmT9hsPKztkgMxoiM4B27X wrYvpfljJy8PGpfr7CsKcURTR7KdA2aYFqzCRo1tYup+rcMdiepIPb6ijYn2NdITzBdq E1RsW8vcMfLo7kHkfoMw97WJJjgx56wChrv8MjlQjio/zJwdTzB1qfBdwejFK/7OhMTp 4UDZFhytKre+LrxhRa8uIZkizWMItTRtTWSi4XSeXl3NeoDqoxnbEjR3C4GLzfYNbI8b GTRRG7of6hhDatkGjfZxOUj9QIRP9yGQBxPMfjUOw5rrgTnuqFT+icxVLx37T6DFp0n9 kTrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=jjqHxxVBIYetT13OgJJ0bw1na2r4Sk4JvFTnIF3BDLE=; b=bM7kID1CbhHm+ndxTuQA+07HXvmAxxXvpA0zQD/FgeXZRrYWYVnmenh7s4sT4VUnhS LXWGFOE/jSB9PyIKfVBcEI6L7gjEID3AWDp5D4Sne2aGsZS1DRylnkUW/aN8JsCwcoA6 q5oi3EkBiq5mCrwoRbAHCoKpKVa35WIpbnLExk9y1n7bjFaX8qNs7dm5EV9ZyqtkNiBK 9TcuXoUCdCQ9tDr+hDP6eaUWL5Qx3VjbtgnHmA2LasM4Wkl2RnJucbcgSnmO8xswOL0F up2xdhTcjF+XGd2jaL+L4D/Iy4FNHIvBGAKVBrGOoe8buajWiQhBL0IjHJYsWqLcBzXU V1lQ== X-Gm-Message-State: APjAAAU9BMtj29XOmraILMqRKtIGPq9ejBP6XqpBjvESB3vb0Kdk/B1U WZBVgxdgtd6YbnfScgTCYhzqeYZYvlc= X-Google-Smtp-Source: APXvYqx/cqYCL902SrTBQ6pyxX70aeAgf84kUmhYtDFDeZc4Ji+tjsdy6G7laJPS/cG+Pu/aV+x+kw== X-Received: by 2002:a19:8017:: with SMTP id b23mr2223359lfd.12.1555675622770; Fri, 19 Apr 2019 05:07:02 -0700 (PDT) Received: from jarvis ([77.79.224.226]) by smtp.gmail.com with ESMTPSA id d80sm414629lfd.90.2019.04.19.05.07.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Apr 2019 05:07:01 -0700 (PDT) Sender: Mariusz Zaborski Date: Fri, 19 Apr 2019 14:06:25 +0200 From: Mariusz Zaborski To: Adrian Chadd Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r346322 - head/lib/libcasper/services/cap_fileargs Message-ID: <20190419120625.GA2747@jarvis> References: <201904171658.x3HGwckd080598@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7AUc2qLy4jB3hD7Z" Content-Disposition: inline In-Reply-To: <201904171658.x3HGwckd080598@repo.freebsd.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 35E41731C5 X-Spamd-Bar: ------- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=eZd6ewxw; spf=pass (mx1.freebsd.org: domain of oshogbovx@gmail.com designates 2a00:1450:4864:20::12c as permitted sender) smtp.mailfrom=oshogbovx@gmail.com X-Spamd-Result: default: False [-7.64 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.99)[-0.988,0]; SIGNED_PGP(-2.00)[]; FORGED_SENDER(0.30)[oshogbo@freebsd.org,oshogbovx@gmail.com]; MIME_TRACE(0.00)[0:+,1:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; TAGGED_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[oshogbo@freebsd.org,oshogbovx@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[freebsd.org]; IP_SCORE(-2.84)[ip: (-9.53), ipnet: 2a00:1450::/32(-2.38), asn: 15169(-2.24), country: US(-0.06)]; RCVD_IN_DNSWL_NONE(0.00)[c.2.1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; MID_RHS_NOT_FQDN(0.50)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Apr 2019 12:07:07 -0000 --7AUc2qLy4jB3hD7Z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 17, 2019 at 04:58:38PM +0000, Adrian Chadd wrote: > Author: adrian > Date: Wed Apr 17 16:58:38 2019 > New Revision: 346322 > URL: https://svnweb.freebsd.org/changeset/base/346322 >=20 > Log: > [casper] fix compilation when casper is disabled. > =20 > This triggers an error in gcc-mips 6.4.0 complaining about unused argum= ents. > =20 > Tested: > =20 > * compiled/run on mips32; nothing complained. >=20 > Modified: > head/lib/libcasper/services/cap_fileargs/cap_fileargs.h >=20 > Modified: head/lib/libcasper/services/cap_fileargs/cap_fileargs.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/lib/libcasper/services/cap_fileargs/cap_fileargs.h Wed Apr 17 16= :45:42 2019 (r346321) > +++ head/lib/libcasper/services/cap_fileargs/cap_fileargs.h Wed Apr 17 16= :58:38 2019 (r346322) > @@ -108,8 +108,12 @@ fileargs_cinitnv(cap_channel_t *cas __unused, nvlist= _t > lstat(name, sb) > #define fileargs_open(fa, name) \ > open(name, fa->fa_flags, fa->fa_mode) > -#define fileargs_fopen(fa, name, mode) \ > - fopen(name, mode) > +static inline > +FILE *fileargs_fopen(fileargs_t *fa, const char *name, const char *mode) > +{ > + (void) fa; __unused is not good enough? > + return (fopen(name, mode)); > +} > #define fileargs_free(fa) (free(fa)) > #endif > =20 >=20 --=20 Mariusz Zaborski oshogbo//vx | http://oshogbo.vexillium.org FreeBSD committer | https://freebsd.org Software developer | http://wheelsystems.com If it's not broken, let's fix it till it is!!1 --7AUc2qLy4jB3hD7Z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkD1x0xkJXVVY1Gwf38KEGuLGxWQFAly5ub4ACgkQ38KEGuLG xWSAyxAAoDpfjabhuC7jWIoSj9d7qswZRdwG29tXSMQmpR5XXeNnIqH/5Avgji5m 6AFtksNmD6nquVw/hFQmPZ5Lx0//8LSc4iBOuSadunIiTrR2MwSsr7SQ3PTD077q o+j4OHNnMqJpiwht6FvoC5iXx9sqsI52eoAo5MAq/1FhiAPkzm4VxHyxehZHM6Rq X8SbxG0KClFOh0umt/WF0RZN8aMAnMdqK+wQEkgbgqa6PNQ7sI4NAnDem0+pwNL/ SsD/2h4JXP+g6IuHEJUYXRkZ3vobc5ovd/su+IzqBywSjQ3wraGwiEq75NKIMrDh doi9NRdyKHKdKXI/m2CJ2AtVpMCpnSJ+b0McpsIJ8l04ElNMxXj8Uw5vlUK9cTR1 0B0E5Z4/15GPSwcD1/CzpIXP1oH3GkXj9wyJuYv8D94r5Xpw04M6ECKydEvUHfVS j7Z0mA7IxaLC5+wYVm8SSfcSyj48x6JLRMGfDrnFfyEzrE0Qy+hUvV9eJEedc5xn kD651vNchdisLu9INXlhqke5RIlVvea+083JERVsUDkLDcCFoURqk93wyGIMBUNs mIm/4SaDSgh5p0BNqUw/BM+R4AxLqCyfUFlAaJbJa5jPjhQduGKD2LdZEtBGtrRA RtTUu0iWDCF3tkyWIjmo+S2H+34kP5fRQv2E5rna449v0louZdY= =dVXk -----END PGP SIGNATURE----- --7AUc2qLy4jB3hD7Z--