From owner-cvs-all Mon May 8 7:43: 0 2000 Delivered-To: cvs-all@freebsd.org Received: from gidora.zeta.org.au (gidora.zeta.org.au [203.26.10.25]) by hub.freebsd.org (Postfix) with SMTP id D92E837B53E for ; Mon, 8 May 2000 07:42:54 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: (qmail 9162 invoked from network); 8 May 2000 14:42:51 -0000 Received: from bde.zeta.org.au (203.2.228.102) by gidora.zeta.org.au with SMTP; 8 May 2000 14:42:51 -0000 Date: Tue, 9 May 2000 00:42:48 +1000 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Joe Karthauser Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/chflags chflags.c [Heads up?] In-Reply-To: <20000505202851.A20115@pavilion.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Fri, 5 May 2000, Joe Karthauser wrote: > I only received one reply to this so I'm guessing that no-one else minds. > [I know that we've all been preoccupied with restructuring documents ;)] > > It's been suggested the {g|s}etflagsbyname is a better set of > function names, and I'm inclined to agree. I'm going to commit > this next week, unless there are serious objections in advance. getflagsbyname() is a much worse name. getflags() gets a string representing the flags from the flags, i.e., it gets non-flags by number. "flags" is too generic. I would prefer names like fileflagstostr() and strtofileflags(), but shorter. If the names are changed, then the broken interfaces should be fixed: 1) getflags() returns the string in a static buffer. 2) The "def" arg for getflags() is too specialized for ls. The caller can easily translate from "" to whatever it wants to print if no flags are set. (ls prints "-" and mtree prints "none".) Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message