From owner-freebsd-ports@freebsd.org Tue Jun 28 15:56:56 2016 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D6B5FB81A71 for ; Tue, 28 Jun 2016 15:56:56 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id B1C9026B4 for ; Tue, 28 Jun 2016 15:56:56 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id AD79AB81A6F; Tue, 28 Jun 2016 15:56:56 +0000 (UTC) Delivered-To: ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AA809B81A6E; Tue, 28 Jun 2016 15:56:56 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pa0-x22e.google.com (mail-pa0-x22e.google.com [IPv6:2607:f8b0:400e:c03::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 77F1426B3; Tue, 28 Jun 2016 15:56:56 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pa0-x22e.google.com with SMTP id bz2so7705200pad.1; Tue, 28 Jun 2016 08:56:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:reply-to:subject:references:to:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=cTwYkHXuHZwDheyP4k6wzuz7lvfl2urcdyg2ytKLK3o=; b=Br86p23YpQFGceGVzG1ZkEY5cIu/1j1BzIQfhQShZV5k0spXl6l65f92nCjwtrEyDH 3gdQ+0rxsmSvD01jwwaklxGYtx5sirhhGOkU+meSYWYhjZoT0aA4LAQosD5YP2IO+QoA LUDHd3uXs3LK0XSqC6dsF1TcGZsflYk8Kx0+DfaEgMIvMr2Hu8Li/3XdAGbhgXerSzd7 dDF4GSlNGAGIMVSTks3qJcQozKc28uqVn1gNxxVC6KwUdmFTFGwdHqA5gL327IovpBeJ F8xt5kQc1xiAPNQtMtwtX1cUcB9NvArYmSdquQqZjuGTHN2kLAYzTLc1bWvrXZFcB+Ha TWJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:reply-to:subject:references:to:cc:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding; bh=cTwYkHXuHZwDheyP4k6wzuz7lvfl2urcdyg2ytKLK3o=; b=EIVlfGo2LiRlPlEtgzTr1VES/tsVhL3HOwHwcmmr5w82kCDNSGhb2ijiq/dkkDz9Ni ZFOI6DqfKTRGfEafzFr6P33CNoJbfaNwvBjm//hqhLdSAcBIHnk/S5/kUu0Rg8wwnbOY FAYeFOM2UqqyAJivvi6BTgeQG3A8ri0KQngBKygJ3LtTfjXyZNA9/1ohnxsXW48Bt52o Lq3wQr8xK2YWXDvfZFBRKH7qpz/P4dqw3cgnVoDn8rX7KCnBRYb63xayPqTWu2XtgUhz URvs6P49vUBQPL4/kHFXv0FOZkbIxtR6S4HHv0zl3C3XyaEswcDl6SIC/Z9Ik7ukMKMR ZvAw== X-Gm-Message-State: ALyK8tJzThHq+2dQ7qkopKGPHcVrnWkN9t06V+GqzfkVoOL5aLNWGTzDUJjP2VIRHHPOzw== X-Received: by 10.66.118.169 with SMTP id kn9mr2935421pab.109.1467129415903; Tue, 28 Jun 2016 08:56:55 -0700 (PDT) Received: from ?IPv6:2001:44b8:31ae:7b01:ac25:cc30:5165:1dd1? (2001-44b8-31ae-7b01-ac25-cc30-5165-1dd1.static.ipv6.internode.on.net. [2001:44b8:31ae:7b01:ac25:cc30:5165:1dd1]) by smtp.gmail.com with ESMTPSA id b71sm7549981pfc.51.2016.06.28.08.56.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Jun 2016 08:56:55 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: pkg SAT_SOLVER bugs References: <20150414200459.GE39658@ivaldir.etoilebsd.net> <20150421103454.GR1394@zxy.spb.ru> <5593D0AE.2010205@selasky.org> <416359ce-1dcd-1160-5c56-f120a0f6358f@selasky.org> To: Hans Petter Selasky , Slawa Olhovchenkov , Baptiste Daroussin Cc: ports@FreeBSD.org, FreeBSD Current From: Kubilay Kocak Message-ID: Date: Wed, 29 Jun 2016 01:56:47 +1000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:47.0) Gecko/20100101 Thunderbird/47.0 MIME-Version: 1.0 In-Reply-To: <416359ce-1dcd-1160-5c56-f120a0f6358f@selasky.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2016 15:56:56 -0000 On 27/06/2016 8:38 PM, Hans Petter Selasky wrote: > Hi, > > I found some bugs in PKG with regard to the SAT_SOLVER environment > variable. Please find patch attached :-) > > Issues fixed: > 1) No need to use hash table when generating SAT rules for external > solver. Variables are already in a linear array. Fix encoding and > decoding of SAT data. > 2) Endless variable loop caused pkg to crash. > 3) it->inverse was checked for non-zero, while it should actually be > checked for -1 only. SAT rules produces were all negative. > > How to verify: > > make -C /usr/ports/math/picosat all install clean > > env SAT_SOLVER=picosat pkg upgrade > > --HPS > Heads-up: Have just updated picosat to its latest version, enjoy!