From nobody Tue Mar 28 07:11:09 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pm17L2prgz41Vr8; Tue, 28 Mar 2023 07:11:10 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pm17L0fMtz3nxg; Tue, 28 Mar 2023 07:11:10 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679987470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IFvtvKpY2bpiv9x8BgG7tYbvpPLi8naueEcah1TA+1I=; b=Ofdc5LR/7hD10f5y9oJC7FhZninRVO90ACtTrm6uLp/vRNspCR4SyalLj3iAFHWHLVT0SF /IuRiD1f0pkldDYJEUF/I175XyPICJlUDNfststlzHl7bfZrJC4/AJj8Q9AKZzaaND+MT1 DawsVvn3VPmUTwJGEXx8feRLGgWo/oEh7RfLB4w573W2AFYWfQ60UPQiCLiax45bTEKar7 ytldETpY1wYvGeBz+zan1dzNCW4px7f6hiqR++8dhNnJ3/CwBMUIB4llFVPKPznzRotjqv RdPH5s00yVH8hoc7TdhOfB+PPmRWda6HbwfvY3nwuTho87hLEKbWdWlTRU4/TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679987470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IFvtvKpY2bpiv9x8BgG7tYbvpPLi8naueEcah1TA+1I=; b=qSMlgWQ+H+d/I7lx0zHfzFg/0V5pYwlkqMUv9m74Q66PRWkIMdRB0BeI/TXRoDQ7V6pEUh iU4/opIqSONWBWvv0VwlEQCoarBToUSBajwbf2JMdkasbBQAzRxELeb4je/pdJQLPTzFz5 hDYA8DL35Y3+Pc/zwbbb7FQVLvMhL1SNR+wlD5oyoWa9GYcdFZrotz+B/vtH+labksfrd/ Ebb02AOAlP1f12z8aqBlwkLVmzzd1tncPWdJd77SXFdovnA1Q2ygmTpvaqI3fxwOM4RXOG chPuzAyNJ4J/3Mo6bogwpKUqn+0aAIs78UKMm3BJSY7WAc3xb4MkXkm6ZInwRQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1679987470; a=rsa-sha256; cv=none; b=TrO1Vv8Zad/ryljtOOnKuW3eZgg/PDeU2xyzAz+NoPrgu7SY+mk2tzLDkDu+ii8fLoBNOM 7crQO0UZMKAMM3t3F1qsSAAs2UyzwUXaqEYDCFu7PBGdvT2FvE2WXPgYT+9XPefldfKvVB 7ydI7lxcCvJFe1dz6SDCEoxiBtFWAN8c1JDCmxswYtpQRkAHQAnV4vEblTjmine6Y2ugU+ Rxzgk9UkpfcKDORnPYBykKRhF/SOCMoRFmPvuc+ivcft5u5untVdMIOYLi5qWpO9XdDfqS eqnLJrbPx6EWvhimLna3358se2JRVjNl6fsBCcSNOhQ6JUuKpHHq1Fysw68J/g== Received: by freefall.freebsd.org (Postfix, from userid 1033) id F22001FD51; Tue, 28 Mar 2023 07:11:09 +0000 (UTC) Date: Tue, 28 Mar 2023 07:11:09 +0000 From: Alexey Dokuchaev To: Dirk Meyer Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: fa5c1863d7d0 - main - print/a2ps: update to 4.15.3 Message-ID: References: <202303271943.32RJhY21083204@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202303271943.32RJhY21083204@gitrepo.freebsd.org> X-ThisMailContainsUnwantedMimeParts: N On Mon, Mar 27, 2023 at 07:43:34PM +0000, Dirk Meyer wrote: > commit fa5c1863d7d0efd004340358af2065da2ea1ae2f > > print/a2ps: update to 4.15.3 Hi Dirk, That's a rather scarce commit log, given the amount of changes. > 26 files changed, 135 insertions(+), 489 deletions(-) > > -MAINTAINER= dinoex@FreeBSD.org > +MAINTAINER= dirk.meyer@dinoex.sub.org Oh, but why? > COMMENT= Formats an ASCII file for printing on a postscript printer > -WWW= https://www.gnu.org/software/a2ps/ > +WWW= http://www.inf.enst.fr/~demaille/a2ps/ Why? This page does not even open for me. > -CPE_VENDOR= gnu > +MAKE_JOBS_UNSAFE=yes When marking port as make -jX unsafe, an excerpt from the failure log should be included, so interested hackers could try to fix it, e.g. particular error used as MAKE_JOBS_UNSAFE value instead of `yes'. > +OPTIONS_DEFAULT=NLS NLS is already on default options list, no need to put it there twice. > post-install: > +.if ${PORT_OPTIONS:MEMACS} > + ${MKDIR} ${STAGEDIR}${PREFIX}/lib/xemacs/site-lisp > + ${LN} -sf ${PREFIX}/share/emacs/site-lisp/a2ps-print.el \ > + ${STAGEDIR}${PREFIX}/lib/xemacs/site-lisp/a2ps-print.el > + ${LN} -sf ${PREFIX}/share/emacs/site-lisp/a2ps.el \ > + ${STAGEDIR}${PREFIX}/lib/xemacs/site-lisp/a2ps.el > +.endif Consider factoring this part in `post-install-EMACS-on' helpder target. > - ${RM} ${STAGEDIR}${PREFIX}/lib/liba2ps.la > + ${RM} -f ${STAGEDIR}${PREFIX}/lib/liba2ps.la Why? make -V RM /bin/rm -f ./danfe