Date: Thu, 29 Oct 2020 00:27:07 +0000 From: myfreeweb <greg@unrelenting.technology> To: =?ISO-8859-1?Q?Romain_Tarti=E8re?= <romain@blogreen.org>, Jan Beich <jbeich@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r553559 - in head/x11: . tilix Message-ID: <6305D686-A3AB-409A-9129-1DBF02DD5F3E@unrelenting.technology> In-Reply-To: <20201028203529.GA74398@blogreen.org> References: <202010281850.09SIocHR051975@repo.freebsd.org> <7dra-i0ig-wny@FreeBSD.org> <20201028203529.GA74398@blogreen.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On October 28, 2020 8:35:29 PM UTC, "Romain Tarti=C3=A8re" <romain@blogree= n=2Eorg> wrote: >On Wed, Oct 28, 2020 at 09:00:39PM +0100, Jan Beich wrote: >> Romain Tarti=C3=A8re <romain@FreeBSD=2Eorg> writes: >>=20 >> > +PATCH_DIST_STRIP=3D-p1 >> > +PATCH_SITES=3D https://patch-diff=2Egithubusercontent=2Ecom/raw/gnun= n1/tilix/pull/ >> > +PATCHFILES=3D 1733=2Ediff >>=20 >> pull/1234=2Ediff is a moving target=2E Better use commit hashes e=2Eg= =2E, >>=20 >> PATCH_SITES=3D https://github=2Ecom/${GH_ACCOUNT}/${GH_PROJECT}/commit/ >> PATCHFILES+=3D ce11b0bd936f=2Epatch:-p1 # https://github=2Ecom/gnunn1/t= ilix/pull/1733 > >Good catch, this indeed makes sense! > >> > +BUILD_DEPENDS=3D ldc2:lang/ldc \ >> > + po4a-translate:textproc/po4a \ >> > + ${LOCALBASE}/libdata/pkgconfig/vted-3=2Epc:x11-toolkits/gtkd >>=20 >> Why not use shared libs like Alpine, Arch, Debian, Fedora, Void? >> See https://github=2Ecom/DankBSD/ports/commit/2b892e4ea4aa > >Oh, I was not aware of this effort :-( ! I hapenned to find out some >old WIP ports in my local ports directory, and saw that I could get >everything to compile, so as these pieces where not in the FreeBSD ports >tree I though it was worth it to push them=E2=80=A6 > >Building shared libs seems to require quite a lot of extra work but the >author of these ports seems to have done all this=2E I added him in Cc >(hey Greg!)=2E Is there a reason for your ports x11-toolkits/gtkd-3 and >x11/tilix _not_ being in the "official" FreeBSD ports tree?=20 Haven't submitted them because I was waiting on the LDC port update landin= g, which I think did happen recently, but now that I'm working on other stu= ff and I don't use Tilix currently and I abandoned my own gtkd-based projec= t, this was not a priority for me=2E > Do you have >something to share regarding this point Jan made? Should we not >better integrate _your_ ports in the FreeBSD ports tree and replace what >I just committed? Would you be interested in being the maintainer of >these ports? Well, replacing the whole thing (with descriptions etc) seems like too muc= h, just take the important part that makes the libs shared=2E I'm undecided/neutral on maintaining these =E2=80=93 they shouldn't be a b= urden but I don't actively use them anymore=2E If you actively use Tilix, y= ou might be a better maintainer of it :)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6305D686-A3AB-409A-9129-1DBF02DD5F3E>