From owner-freebsd-current Tue Jan 27 18:44:17 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id SAA19238 for current-outgoing; Tue, 27 Jan 1998 18:44:17 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from tecumseh.altavista-software.com (tecumseh.altavista-software.com [205.181.164.14]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id SAA19228 for ; Tue, 27 Jan 1998 18:44:12 -0800 (PST) (envelope-from matt@3am-software.com) Received: from nowin (1Cust103.max3.boston.ma.ms.uu.net [153.35.70.231]) by tecumseh.altavista-software.com (8.8.5/8.8.5) with SMTP id VAA17410; Tue, 27 Jan 1998 21:43:54 -0500 (EST) Message-Id: <199801280243.VAA17410@tecumseh.altavista-software.com> X-Sender: 3ampop@ranier.altavista-software.com X-Mailer: QUALCOMM Windows Eudora Pro Version 4.0 Date: Tue, 27 Jan 1998 21:41:32 -0500 To: Stephen McKay From: Matt Thomas Subject: Re: PATCH: if_de.c #ifdef based version encoding Cc: freebsd-current@FreeBSD.ORG In-Reply-To: <199801280124.LAA06212@ogre.dtir.qld.gov.au> References: <34CE4438.15FB7483@whistle.com> <199801271101.DAA25275@implode.root.com> <34CE4438.15FB7483@whistle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk >>> In theory, the de driver is maintained by Matt Thomas and he supports >>> multiple OS's and OS versions in the code. You'll notice that there are >>> #ifdef's for NetBSD and BSD/OS in there as well. If we were going to do >>> as you suggest, then it would only make sense if all of the OS #ifdef's >>> were removed. This will only make it more difficult for Matt to support >>> FreeBSD, so I think it's a bad idea. > >Making Matt's life difficult would be counterproductive, but these version >tests are pretty silly from an ivory tower purist view, and are also a pain >in practice. I'm with Terry on this one. If there is such a symbol on 2.1.0 or later I'll use it. -- Matt Thomas Internet: matt@3am-software.com 3am Software Foundry WWW URL: http://www.3am-software.com/bio/matt/ Nashua, NH Disclaimer: I disavow all knowledge of this message