From owner-cvs-all Sun Sep 2 22:27:28 2001 Delivered-To: cvs-all@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by hub.freebsd.org (Postfix) with ESMTP id B474937B406; Sun, 2 Sep 2001 22:27:18 -0700 (PDT) Received: from critter (localhost [127.0.0.1]) by critter.freebsd.dk (8.11.4/8.11.4) with ESMTP id f835QrT20161; Mon, 3 Sep 2001 07:26:53 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: "Andrey A. Chernov" Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/stdio fdopen.c fflush.c fopen.c fseek.c ftell.c fvwrite.c local.h refill.c stdio.c In-Reply-To: Your message of "Sun, 02 Sep 2001 12:10:12 PDT." <200109021910.f82JACD82362@freefall.freebsd.org> Date: Mon, 03 Sep 2001 07:26:53 +0200 Message-ID: <20159.999494813@critter> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <200109021910.f82JACD82362@freefall.freebsd.org>, "Andrey A. Chernov " writes: >ache 2001/09/02 12:10:12 PDT > > Modified files: > lib/libc/stdio fdopen.c fflush.c fopen.c fseek.c ftell.c > fvwrite.c local.h refill.c stdio.c > Log: > Move all stdio internal flags processing and setting out of __sread(), > __swrite() and __sseek() to higher level. According to funopen(3) they all > are just wrappers to something like standard read(2), write(2) and > lseek(2), i.e. must not touch stdio internals because they are replaceable > with any other functions knows nothing about stdio internals. See example > of funopen(3) usage in sendmail sources f.e. > > NOTE: this is original stdio bug, not result of my range checkin added. NOTE: You forgot to add "Reviewed by: xxx" Or do you seriously think that mucking about in STDIO doesn't need a review ? -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message