From owner-freebsd-perl@FreeBSD.ORG Mon Nov 3 12:50:36 2008 Return-Path: Delivered-To: perl@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 854941065673 for ; Mon, 3 Nov 2008 12:50:36 +0000 (UTC) (envelope-from tobez@tobez.org) Received: from heechee.tobez.org (heechee.tobez.org [194.255.56.42]) by mx1.freebsd.org (Postfix) with ESMTP id 152D58FC23 for ; Mon, 3 Nov 2008 12:50:35 +0000 (UTC) (envelope-from tobez@tobez.org) Received: by heechee.tobez.org (Postfix, from userid 1001) id 15EB66D402; Mon, 3 Nov 2008 13:50:35 +0100 (CET) Date: Mon, 3 Nov 2008 13:50:35 +0100 From: Anton Berezin To: Yen-Ming Lee Message-ID: <20081103125035.GA66067@heechee.tobez.org> References: <200810181406.m9IE6jW8067588@freefall.freebsd.org> <759236930810180813r415eaae2of299ebed951632a8@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <759236930810180813r415eaae2of299ebed951632a8@mail.gmail.com> X-Powered-By: FreeBSD http://www.freebsd.org/ User-Agent: Mutt/1.5.18 (2008-05-17) Cc: perl@freebsd.org Subject: Re: ports/128187: [PATCH] devel/p5-Parse-RecDescent: simplfy dependency X-BeenThere: freebsd-perl@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: maintainer of a number of perl-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Nov 2008 12:50:36 -0000 Hi, Sorry for not answering for such a long time. On Sat, Oct 18, 2008 at 08:13:34AM -0700, Yen-Ming Lee wrote: > 2008/10/18 : > > Synopsis: [PATCH] devel/p5-Parse-RecDescent: simplfy dependency > > > > State-Changed-From-To: open->feedback > > State-Changed-By: tobez > > State-Changed-When: Sat Oct 18 16:02:19 CEST 2008 > > State-Changed-Why: > > With regard making the dependency conditional on the perl version, > > I actually think that the better way to do it is to add modifications > > to bsd.perl.mk that we developed together with lth. But I do not have a > > principal objection to this. > > > > With regard to getting rid of BUILD_DEPENDS altogether, could > > you explain your reasoning behind it? In my view, by not > > doing the BUILD_DEPENDS bit, we a) introduce a spurious warning > > into the configure stage in at least some cases, and b) make it more > > difficult than necessary to do the testing without installing the > > modules. > > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=128187 > > > > Hi, > > The main reason is to keep minimal dependencies. I explained once in > another PR, and asked for feedbacks. However, nobody replied, so I > just assume that everyone agreed. (see solution 2) > > About the dependencies, we have the following solutions: > > 1. (I did so before) put 'requires' in BUILD_DEPENDS and RUN_DEPENDS, > and then append 'build_requires' to BUILD_DEPENDS. The trade-off is > that we will bring a lot of unnecessary dependencies, like some > dual-life modules or some p5-Test-* that only needed for tests, and > des@ doesn't like that. Well, until we have a bit more automatic and a bit more comprehensive solution, don't you think that we should consider such things on a case-by-case basis? I understand your arguments, and I have presented my own arguments, sometimes agreeing with you, sometimes not, but this discussion is larger than this particular PR. In *this* particular case, do you have a good reason of dropping Text::Balanced from the BUILD_DEPENDS? I don't see any, whatever way I slice it and dice it. > http://lists.freebsd.org/pipermail/freebsd-perl/2008-February/001745.html > http://lists.freebsd.org/pipermail/freebsd-perl/2008-February/001748.html > > 2. (I'm doing so now) put 'requires' in RUN_DEPENDS, and put something > in BUILD_DEPENDS if really needed. Also use conditional dependencies > to avoid dual-life modules. It complains during the configure stage, > but it works well. "Really needed" is in the eye of the beholder. You know that Makefile.PL bitching is harmless, I know it is harmless, but a person installing the module does not. > http://lists.freebsd.org/pipermail/freebsd-perl/2008-July/001900.html > > 3. use PERL_DEPENDS, but we still need to find out the relationship > between the minimum version of the required module and the package > version fulfill that minimum version of the module. In fact I > encounter this problem again recently: Net::Amazon::S3-0.45 requires > IO::File-0.14, which is from IO, but obviously not IO-0.14 Yes, this is a drawback of our proposed solution. I still think it is better to rely on distributions and not on individual modules, though. > http://lists.freebsd.org/pipermail/freebsd-perl/2008-April/001834.html > > We discussed about it several times, please make a decision this time > and put it somewhere in the porters handbook. Hey, *who* is it you want to make a decision? Cheers, \Anton. -- We're going for 'working' here. 'clean' is for people with skills... -- Flemming Jacobsen