From owner-freebsd-arm@FreeBSD.ORG  Wed Mar 11 09:39:15 2015
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 72A8F8AC
 for <freebsd-arm@freebsd.org>; Wed, 11 Mar 2015 09:39:15 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 52E21D59
 for <freebsd-arm@freebsd.org>; Wed, 11 Mar 2015 09:39:15 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t2B9dFti014160
 for <freebsd-arm@freebsd.org>; Wed, 11 Mar 2015 09:39:15 GMT
 (envelope-from root@phabric-backend.isc.freebsd.org)
Received: (from root@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t2B9dFQH014159;
 Wed, 11 Mar 2015 09:39:15 GMT (envelope-from root)
Date: Wed, 11 Mar 2015 09:39:15 +0000
To: freebsd-arm@freebsd.org
From: "zbb (Zbigniew Bodek)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Commented On] D2018: Introduce Annapurna Labs AHCI
 support
Message-ID: <aadbf5f481b35ed3ad3c3536eee938a4@localhost.localdomain>
X-Priority: 3
Thread-Topic: D2018: Introduce Annapurna Labs AHCI support
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-6m5mo2kjikkzyd33ld4n>
X-Phabricator-To: <PHID-USER-tmsdq7z6rym2k7agm3fv>
X-Phabricator-To: <PHID-USER-q5lmute3rwskeizvu5gf>
X-Phabricator-To: <PHID-USER-wqysm6qikfri2awpdmpj>
X-Phabricator-Cc: <PHID-MLST-stsrni3uozki6w7zubvy>
In-Reply-To: <differential-rev-PHID-DREV-lp4daqpuzz2y5vyrxipd-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-lp4daqpuzz2y5vyrxipd-req@FreeBSD.org>
Thread-Index: ZGMxZTcyZjQyYTA3MjQzZjU5NjlmODc0YTQ5IFUADUM=
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "Porting FreeBSD to ARM processors." <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm/>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Mar 2015 09:39:15 -0000

zbb added inline comments.

INLINE COMMENTS
  sys/dev/ahci/ahci.c:150-153 **Jakub Palider wrote:**
  >I have overlooked it in the specs and took the CAP register RW for
  >granted. You are right, writing to RO registers doesn't sound fine, and
  >we don't like it either. But we have little choice but to perform the
  >writes to make it operational.
  >You say adding it to quirks is not proper place? Where then?
  sys/dev/ahci/ahci.c:199-201 **Jakub Palider wrote:**
  >I'd prefer read MAY/SHOULD/MUST but the spec simply says that it is
  >loaded by the BIOS. However in reality that does not always happen and
  >higher level stuff suffers from broken implementations. Linux does it
  >and although it is not our reference it shows a way to just make things
  >work. Again - is adding platform quirks wrong way?

REVISION DETAIL
  https://reviews.freebsd.org/D2018

To: zbb, mav, imp, smh
Cc: freebsd-arm