From owner-svn-src-all@freebsd.org Sat Feb 22 18:53:47 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 07363249318; Sat, 22 Feb 2020 18:53:47 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (mx.allbsd.org [IPv6:2001:2f0:104:e001::41]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail.allbsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48PyCZ0SzCz4Fl8; Sat, 22 Feb 2020 18:53:45 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail-d.allbsd.org ([IPv6:2409:11:a740:4700:58:65ff:fe00:b0b]) (authenticated bits=56) by mail.allbsd.org (8.15.2/8.15.2) with ESMTPSA id 01MIrIMK074003 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=OK) (Client CN "/CN=mail-d.allbsd.org", Issuer "/C=US/O=Let's+20Encrypt/CN=Let's+20Encrypt+20Authority+20X3"); Sun, 23 Feb 2020 03:53:28 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (alph.allbsd.org [192.168.0.10]) (authenticated bits=0) by mail-d.allbsd.org (8.15.2/8.15.2) with ESMTPA id 01MIrCLC095422; Sun, 23 Feb 2020 03:53:13 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Sun, 23 Feb 2020 03:52:52 +0900 (JST) Message-Id: <20200223.035252.1359423210478514412.hrs@FreeBSD.org> To: kevans@FreeBSD.org, cem@freebsd.org, antoine@freebsd.org Cc: lwhsu@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r358152 - head/bin/sh From: Hiroki Sato In-Reply-To: References: X-Old-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-PGPkey-fingerprint: 6C0D 2353 27CF 80C7 901E FDD2 DBB0 7DC6 6F1F 737F X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha512; boundary="--Security_Multipart(Sun_Feb_23_03_52_52_2020_276)--" Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail.allbsd.org [IPv6:2001:2f0:104:e001:0:0:0:41]); Sun, 23 Feb 2020 03:53:34 +0900 (JST) X-Rspamd-Queue-Id: 48PyCZ0SzCz4Fl8 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.78 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-0.79)[-0.785,0]; ASN(0.00)[asn:7514, ipnet:2001:2f0::/32, country:JP]; NEURAL_HAM_LONG(-0.99)[-0.994,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Feb 2020 18:53:47 -0000 ----Security_Multipart(Sun_Feb_23_03_52_52_2020_276)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Conrad Meyer wrote in : ce> Given the report and looking at the change, I suspect the problem is ce> the promotion of '-residue' from size_t (unsigned 32-bit on i386) to ce> off_t (signed 64-bit). Something like '-(off_t)residue' or even ce> 'off_t residue;' should fix it. Yes, r358235 is the correct fix. I am sorry for the breakage and thank you for fixing it quickly. -- Hiroki ----Security_Multipart(Sun_Feb_23_03_52_52_2020_276)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iMkEABMKAC4WIQRsDSNTJ8+Ax5Ae/dLbsH3Gbx9zfwUCXlF4hBAcaHJzQGZyZWVi c2Qub3JnAAoJENuwfcZvH3N/7GwCCQF9bck/PMytWUxnFUbUK/LQesP36QdPL3lh BIBDMxlXSydCUHe8RaC78j0niIi5CC3ZTAUsRRuw17CXWSezqZvVkAIHbzmSTN6x BVCYenxOjXRe8KUVnYPLv004tIapzJSq7VL/+Ned0f41F5R38BKdtKozjETWJfW8 wCL+D0QaeI1WWHA= =W9aI -----END PGP SIGNATURE----- ----Security_Multipart(Sun_Feb_23_03_52_52_2020_276)----