Date: Sat, 25 Mar 2017 02:49:00 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Kyle Evans <bsdports@kyle-evans.net> Cc: Diane Bruce <db@freebsd.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r436814 - in head/comms: . direwolf direwolf/files Message-ID: <20170325024900.GC18367@FreeBSD.org> In-Reply-To: <CACNAnaGdOSmZY58oE6z8P2kHO6NaNUx4-geurbteH45bLe9f7w@mail.gmail.com> References: <201703241401.v2OE1nwY023666@repo.freebsd.org> <20170325014740.GC54562@FreeBSD.org> <CACNAnaFhG=WufG3VP3TG6CZWf507X=OFWzif2YUm8==JDKEuGg@mail.gmail.com> <20170325023517.GA18367@FreeBSD.org> <CACNAnaGdOSmZY58oE6z8P2kHO6NaNUx4-geurbteH45bLe9f7w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Mar 24, 2017 at 09:39:15PM -0500, Kyle Evans wrote:
> On Fri, Mar 24, 2017 at 9:35 PM, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> > Thanks, one more little thing before it can be committed.
>
> Hah, jokes on you, there were two things I messed up! =)
;-)
> >> +MAKE_ENV+= STAGEDIR=${STAGEDIR}
> >
> > You didn't run make -V MAKE_ARGS, did you? :-)
>
> Oy, I actually didn't because all of the other directories I cared
> about were in MAKE_ENV, and I was looking for STAGEDIR specifically.
>
> Attached is a revised patch, s/STAGEDIR/DESTDIR/ and the dw-start.sh
> script was getting installed with the wrong permissions because I
> overlooked the fact it's installed in the examples/ with a bunch of
> datafiles.
LGTM, but I'm sleepy and fainting away. Let's let Diane to review
and handle it as it was their commit in the first place.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170325024900.GC18367>