From owner-freebsd-rc@FreeBSD.ORG Fri Jan 25 18:43:13 2008 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 52FC816A46B; Fri, 25 Jan 2008 18:43:13 +0000 (UTC) (envelope-from mtm@FreeBSD.Org) Received: from mercury.mike.lan (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 7CFCE13C4D9; Fri, 25 Jan 2008 18:42:12 +0000 (UTC) (envelope-from mtm@FreeBSD.Org) Received: by mercury.mike.lan (Postfix, from userid 1000) id 2F6F526D02A; Fri, 25 Jan 2008 21:46:43 +0300 (EAT) From: Mike Makonnen To: freebsd-rc In-Reply-To: <20080125160412.GA36311@lor.one-eyed-alien.net> References: <200801251506.m0PF6Qwf043571@repoman.freebsd.org> <20080125152102.GD6064@submonkey.net> <20080125160412.GA36311@lor.one-eyed-alien.net> Content-Type: multipart/mixed; boundary="=-fXTbhac/7/bQlP6pFhdX" Date: Fri, 25 Jan 2008 21:46:42 +0300 Message-Id: <1201286802.2865.8.camel@mercury> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 FreeBSD GNOME Team Port Cc: scottl@freebsd.org, Brooks Davis Subject: Re: cvs commit: src/etc rc.subr X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mtm@FreeBSD.Org List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2008 18:43:13 -0000 --=-fXTbhac/7/bQlP6pFhdX Content-Type: text/plain Content-Transfer-Encoding: 7bit On Fri, 2008-01-25 at 10:04 -0600, Brooks Davis wrote: > On Fri, Jan 25, 2008 at 03:21:02PM +0000, Ceri Davies wrote: > > On Fri, Jan 25, 2008 at 03:06:26PM +0000, Mike Makonnen wrote: > > > mtm 2008-01-25 15:06:26 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > etc rc.subr > > > Log: > > > If the rc.conf(5) variable for a script is not enabled do not fail > > > silently. Display a message that the command wasn't run and make > > > possible suggestions for what to do. > > > > Any chance that we could make this behaviour dependent on some other > > variable (or not do it)? It's going to make booting look pretty nasty. > > The other option I'd considered was to create a quiet precmd that works like > force and use quietstart/quitestop for boot. I've become convinced this is the > right interactive behavior. > > -- Brooks > > > Ceri > > > > > | @@ -606,6 +606,9 @@ run_rc_command() > > > | # > > > | if [ -n "${rcvar}" -a "$rc_arg" != "rcvar" ]; then > > > | if ! checkyesno ${rcvar}; then > > > | + echo -n "Cannot '${rc_arg}' $name. Set ${rcvar} to " > > > | + echo -n "YES in /etc/rc.conf or use 'one${rc_arg}' " > > > | + echo "instead of '${rc_arg}'." > > > | return 0 > > > | fi > > > | fi > > Ok, I went with brooks@'s suggestion and instead implemented a quiet prefix. In addition, I also made the 'fast' prefix imply 'quiet'. Something else this buys us is that we now have a knob that we can put a lot of diagnostic messages behind to "de-clutter" the console during boot and shutdown. Patch is attached. Cheers. -- Mike Makonnen | GPG-KEY: http://people.freebsd.org/~mtm/mtm.asc mmakonnen @ gmail.com | AC7B 5672 2D11 F4D0 EBF8 5279 5359 2B82 7CD4 1F55 mtm @ FreeBSD.Org | FreeBSD - http://www.freebsd.org --=-fXTbhac/7/bQlP6pFhdX Content-Disposition: attachment; filename=rc.d-quiet.diff Content-Type: text/x-patch; name=rc.d-quiet.diff; charset=us-ascii Content-Transfer-Encoding: base64 SW5kZXg6IGV0Yy9yYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9ob21lL25jdnMvc3JjL2V0Yy9y Yyx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMzQwDQpkaWZmIC11IC1yMS4zNDAgcmMNCi0tLSBl dGMvcmMJMiBBcHIgMjAwNyAyMjo1MzowNiAtMDAwMAkxLjM0MA0KKysrIGV0Yy9yYwkyNSBKYW4g MjAwOCAxODowMjoxNCAtMDAwMA0KQEAgLTU2LDcgKzU2LDcgQEANCiAJcmNfZmFzdD15ZXMgICAg ICAgICMgcnVuX3JjX2NvbW1hbmQoKTogZG8gZmFzdCBib290aW5nDQogZWxzZQ0KIAlhdXRvYm9v dD1ubw0KLQlfYm9vdD0ic3RhcnQiDQorCV9ib290PSJxdWlldHN0YXJ0Ig0KIGZpDQogDQogZGx2 PWAvc2Jpbi9zeXNjdGwgLW4gdmZzLm5mcy5kaXNrbGVzc192YWxpZCAyPiAvZGV2L251bGxgDQpJ bmRleDogZXRjL3JjLnN1YnINCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvaG9tZS9uY3ZzL3NyYy9l dGMvcmMuc3Vicix2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNzkNCmRpZmYgLXUgLXIxLjc5IHJj LnN1YnINCi0tLSBldGMvcmMuc3VicgkyNSBKYW4gMjAwOCAxNjo0NDozNCAtMDAwMAkxLjc5DQor KysgZXRjL3JjLnN1YnIJMjUgSmFuIDIwMDggMTg6MjM6NDQgLTAwMDANCkBAIC0zNzcsOSArMzc3 LDEwIEBADQogIwlJZiBhcmd1bWVudCBoYXMgYSBnaXZlbiBwcmVmaXgsIHRoZW4gY2hhbmdlIHRo ZSBvcGVyYXRpb24gYXMgZm9sbG93czoNCiAjCQlQcmVmaXgJT3BlcmF0aW9uDQogIwkJLS0tLS0t CS0tLS0tLS0tLQ0KLSMJCWZhc3QJU2tpcCB0aGUgcGlkIGNoZWNrLCBhbmQgc2V0IHJjX2Zhc3Q9 eWVzDQorIwkJZmFzdAlTa2lwIHRoZSBwaWQgY2hlY2ssIGFuZCBzZXQgcmNfZmFzdD15ZXMsIHJj X3F1aWV0PXllcw0KICMJCWZvcmNlCVNldCAke3JjdmFyfSB0byBZRVMsIGFuZCBzZXQgcmNfZm9y Y2U9eWVzDQogIwkJb25lCVNldCAke3JjdmFyfSB0byBZRVMNCisjCQlxdWlldAlEb24ndCBvdXRw dXQgc29tZSBkaWFnbm9zdGljcywgYW5kIHNldCByY19xdWlldD15ZXMNCiAjDQogIwlUaGUgZm9s bG93aW5nIGdsb2JhbHMgYXJlIHVzZWQ6DQogIw0KQEAgLTUyMiw2ICs1MjMsOCBAQA0KICMNCiAj CXJjX2ZvcmNlCU5vdCBlbXB0eSBpZiAiZm9yY2UiIHdhcyBwcm92aWRlZCAocS52LikNCiAjDQor IwlyY19xdWlldAlOb3QgZW1wdHkgaWYgInF1aWV0IiB3YXMgcHJvdmlkZWQNCisjDQogIw0KIHJ1 bl9yY19jb21tYW5kKCkNCiB7DQpAQCAtNTQyLDYgKzU0NSw3IEBADQogCWZhc3QqKQkJCQkjICJm YXN0IiBwcmVmaXg7IGRvbid0IGNoZWNrIHBpZA0KIAkJcmNfYXJnPSR7cmNfYXJnI2Zhc3R9DQog CQlyY19mYXN0PXllcw0KKwkJcmNfcXVpZXQ9eWVzDQogCQk7Ow0KIAlmb3JjZSopCQkJCSMgImZv cmNlIHByZWZpeDsgYWx3YXlzIHJ1bg0KIAkJcmNfZm9yY2U9eWVzDQpAQCAtNTU4LDYgKzU2Miwx MSBAQA0KIAkJCWV2YWwgJHtyY3Zhcn09WUVTDQogCQlmaQ0KIAkJOzsNCisJcXVpZXQqKQkJCQkj ICJxdWlldCIgcHJlZml4OyBvbWl0IHNvbWUgbWVzc2FnZXMNCisJCV9yY19wcmVmaXg9cXVpZXQN CisJCXJjX2FyZz0ke3JjX2FyZyMke19yY19wcmVmaXh9fQ0KKwkJcmNfcXVpZXQ9eWVzDQorCQk7 Ow0KIAllc2FjDQogDQogCWV2YWwgX292ZXJyaWRlX2NvbW1hbmQ9XCQke25hbWV9X3Byb2dyYW0N CkBAIC02MDYsNiArNjE1LDEyIEBADQogCQkJCQkjDQogCWlmIFsgLW4gIiR7cmN2YXJ9IiAtYSAi JHJjX2FyZyIgIT0gInJjdmFyIiBdOyB0aGVuDQogCQlpZiAhIGNoZWNreWVzbm8gJHtyY3Zhcn07 IHRoZW4NCisJCQlpZiBbIC1uICIke3JjX3F1aWV0fSIgXTsgdGhlbg0KKwkJCQlyZXR1cm4gMA0K KwkJCWZpDQorCQkJZWNobyAtbiAiQ2Fubm90ICcke3JjX2FyZ30nICRuYW1lLiBTZXQgJHtyY3Zh cn0gdG8gIg0KKwkJCWVjaG8gLW4gIllFUyBpbiAvZXRjL3JjLmNvbmYgb3IgdXNlICdvbmUke3Jj X2FyZ30nICINCisJCQllY2hvICJpbnN0ZWFkIG9mICcke3JjX2FyZ30nLiINCiAJCQlyZXR1cm4g MA0KIAkJZmkNCiAJZmkNCkluZGV4OiBldGMvcmMuZC9uZXRpZg0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZp bGU6IC9ob21lL25jdnMvc3JjL2V0Yy9yYy5kL25ldGlmLHYNCnJldHJpZXZpbmcgcmV2aXNpb24g MS4yNA0KZGlmZiAtdSAtcjEuMjQgbmV0aWYNCi0tLSBldGMvcmMuZC9uZXRpZgkyNSBKdWwgMjAw NyAxODowODowMSAtMDAwMAkxLjI0DQorKysgZXRjL3JjLmQvbmV0aWYJMjUgSmFuIDIwMDggMTg6 MzM6MDYgLTAwMDANCkBAIC03Miw3ICs3Miw3IEBADQogDQogCWlmIFsgLWYgL2V0Yy9yYy5kL2lw ZmlsdGVyIF0gOyB0aGVuDQogCQkjIFJlc3luYyBpcGZpbHRlcg0KLQkJL2V0Yy9yYy5kL2lwZmls dGVyIHJlc3luYw0KKwkJL2V0Yy9yYy5kL2lwZmlsdGVyIHF1aWV0cmVzeW5jDQogCWZpDQogCWlm IFsgLWYgL2V0Yy9yYy5kL2JyaWRnZSAtYSAtbiAiJGNtZGlmbiIgXSA7IHRoZW4NCiAJCS9ldGMv cmMuZC9icmlkZ2Ugc3RhcnQgJGNtZGlmbg0K --=-fXTbhac/7/bQlP6pFhdX--