From owner-freebsd-cvsweb@FreeBSD.ORG  Sat Dec  3 19:33:46 2005
Return-Path: <owner-freebsd-cvsweb@FreeBSD.ORG>
X-Original-To: freebsd-cvsweb@freebsd.org
Delivered-To: freebsd-cvsweb@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2739216A41F
	for <freebsd-cvsweb@freebsd.org>; Sat,  3 Dec 2005 19:33:46 +0000 (GMT)
	(envelope-from scop@freebsd.org)
Received: from smtp3.pp.htv.fi (smtp3.pp.htv.fi [213.243.153.36])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A3AB343D58
	for <freebsd-cvsweb@freebsd.org>; Sat,  3 Dec 2005 19:33:45 +0000 (GMT)
	(envelope-from scop@freebsd.org)
Received: from [192.168.2.4] (cs168006.pp.htv.fi [213.243.168.6])
	by smtp3.pp.htv.fi (Postfix) with ESMTP id 1011227AD0C
	for <freebsd-cvsweb@freebsd.org>; Sat,  3 Dec 2005 21:33:43 +0200 (EET)
From: Ville =?ISO-8859-1?Q?Skytt=E4?= <scop@freebsd.org>
To: freebsd-cvsweb@freebsd.org
In-Reply-To: <20051203171743.51757.qmail@web30807.mail.mud.yahoo.com>
References: <20051203171743.51757.qmail@web30807.mail.mud.yahoo.com>
Content-Type: text/plain
Organization: FreeBSD
Date: Sat, 03 Dec 2005 21:33:43 +0200
Message-Id: <1133638423.2195.63.camel@localhost.localdomain>
Mime-Version: 1.0
X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) 
Content-Transfer-Encoding: 7bit
Subject: Re: CVSweb patches
X-BeenThere: freebsd-cvsweb@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS Web maintenance mailing list <freebsd-cvsweb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-cvsweb>, 
	<mailto:freebsd-cvsweb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-cvsweb>
List-Post: <mailto:freebsd-cvsweb@freebsd.org>
List-Help: <mailto:freebsd-cvsweb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-cvsweb>,
	<mailto:freebsd-cvsweb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 03 Dec 2005 19:33:46 -0000

On Sat, 2005-12-03 at 09:17 -0800, Daniel Qarras wrote:

> About the other comments: I've followed your suggestions and attached
> updated patches.

I've applied the "age colors" patch with some minor robustness changes.

About the "nice colors" patch, as you said, mileages vary and it's not
possible to please everyone with one color scheme.  I tend to think that
the old colors are nicer, so I haven't applied the patch.

A more "proper" and future proof solution to this problem IMO would be
to implement end user selectable alternative style sheets (with the
user's choice persisted, possibly in a "sticky" query string parameter
and/or a cookie), with the given available CSS URLs configured in
cvsweb.conf.  Some examples and more info:
http://www.w3.org/Style/Examples/007/alternatives.html
http://www.alistapart.com/articles/alternate/