From owner-svn-ports-head@freebsd.org Sat Aug 26 08:27:29 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 55836DF104B; Sat, 26 Aug 2017 08:27:29 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (prod2.absolight.net [79.143.243.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 05B113F50; Sat, 26 Aug 2017 08:27:28 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id A7A66BDD39; Sat, 26 Aug 2017 10:27:25 +0200 (CEST) Received: from atuin.in.mat.cc (atuin.in.mat.cc [79.143.241.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by prod2.absolight.net (Postfix) with ESMTPSA id 65CFDBDD31; Sat, 26 Aug 2017 10:27:25 +0200 (CEST) Subject: Re: svn commit: r448747 - in head/mail: . smfsav smfsav-devel smfsav-devel/files To: "Danilo G. Baio" , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201708260118.v7Q1IGxA078692@repo.freebsd.org> From: Mathieu Arnold Organization: Absolight / The FreeBSD Foundation Message-ID: Date: Sat, 26 Aug 2017 10:27:21 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <201708260118.v7Q1IGxA078692@repo.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="OL1OfwbPBKPwQ0ms0raq23SCP8w7VWnN5" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Aug 2017 08:27:29 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OL1OfwbPBKPwQ0ms0raq23SCP8w7VWnN5 Content-Type: multipart/mixed; boundary="kf8jC4XusHu6uVSPHtWJdm0crBIo97sQB"; protected-headers="v1" From: Mathieu Arnold To: "Danilo G. Baio" , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: Subject: Re: svn commit: r448747 - in head/mail: . smfsav smfsav-devel smfsav-devel/files References: <201708260118.v7Q1IGxA078692@repo.freebsd.org> In-Reply-To: <201708260118.v7Q1IGxA078692@repo.freebsd.org> --kf8jC4XusHu6uVSPHtWJdm0crBIo97sQB Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: fr Le 26/08/2017 =C3=A0 03:18, Danilo G. Baio a =C3=A9crit=C2=A0: > PLIST_SUB=3D SMFSAV_RUN_DIR=3D${SMFSAV_RUN_DIR} > SUB_FILES+=3D pkg-message > +SUB_LIST=3D ${PLIST_SUB} This is a very bad idea, it does not do what you think it does. $ make -V SUB_LIST SMFSAV_RUN_DIR=3D/var/run/smfs OSREL=3D11.1 PREFIX=3D%D LOCALBASE=3D/usr/= local=C2=A0 RESETPREFIX=3D/usr/local PORTDOCS=3D"" PORTEXAMPLES=3D"" LIB32DIR=3Dlib DOCSDIR=3D"share/doc/smfsav"=C2=A0 EXAMPLESDIR=3D"share/examples/smfsav"=C2= =A0 DATADIR=3D"share/smfsav"=C2=A0 WWWDIR=3D"www/smfsav"=C2=A0 ETCDIR=3D"etc/= smfsav" PREFIX=3D/usr/local LOCALBASE=3D/usr/local=C2=A0 DATADIR=3D/usr/local/sha= re/smfsav DOCSDIR=3D/usr/local/share/doc/smfsav EXAMPLESDIR=3D/usr/local/share/examples/smfsav=C2=A0 WWWDIR=3D/usr/local/www/smfsav ETCDIR=3D/usr/local/etc/smfsav Now, you have two instances of many variables in there, for example: $ make -V SUB_LIST:METCDIR* ETCDIR=3D"etc/smfsav" ETCDIR=3D/usr/local/etc/smfsav It is completely unsupported, and I am quite sure it would likely break very badly. A quick fix would be to change =3D by :=3D, but :=3D sometime does other things that you do not expect. It would probably be better to dupplicate the content. --=20 Mathieu Arnold --kf8jC4XusHu6uVSPHtWJdm0crBIo97sQB-- --OL1OfwbPBKPwQ0ms0raq23SCP8w7VWnN5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJZoTDsXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85I394QAKSeoifPhKa3vl5kN8X/dlC3 relRCruaKnQMaUk1NeI2ofMwBEjF9f0H28h82HSR7B2uHevLRtuK6vLcFDjIPmkf 7uHSpj4vi54s6BQlD8lym5k84/in1SaR+E+udNAHMD+m5SSjcudSMJULf3YFQiqu xC5ax4ahQJIo8azv+YBPqIQIj8hn3x5HuqdiMdfbX2IHCg9MN9UsyDKqGgeODL0I ZtC8mgr/NJbNrGKbIA00fedAIkwnx4QfK5DJFA/ZS6ZWwiDFMSihnr8t+a0s7x3+ 7B/mdcs1AJU7hnWjR+94S5YBb7P827HsTJh2jL6x0vBzoX/QKZ1JBC6DGBTo27Bj RJwkIS6jGCQZnXqfeOcUxeQ5M2dhTy/ApKHEZiJc8DqlzLSKSA4vz0uBYJXockuG p1Tz017x+LvIhzdzyI0XEtqo+bfdGwGnGb+dacsQjRMl6YKPU7BEJCNJEqxXlm3+ WydH9UoSkubowbwuRqHpzyRsDFsqQLg1djosshx1bZz0lN4w+jE4AD3GUQlkaq/t jqTEezT5u+/CSr+iMuD5xU8u+DRrbTtT4hT1KidoA1qKLEJC7TIPqSYFzWNsG6iy BQelEF2JdmSNIPIbhwV/2VCj3kofOK2x4rSHqjapzWKiCQIVcrWvyx8EF2uXOpk4 7+z8Zvm62EIM4au8hMS/ =MUB1 -----END PGP SIGNATURE----- --OL1OfwbPBKPwQ0ms0raq23SCP8w7VWnN5--