From owner-freebsd-hackers@FreeBSD.ORG Sat Nov 6 18:22:55 2010 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7B2281065670 for ; Sat, 6 Nov 2010 18:22:55 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 0FD978FC19 for ; Sat, 6 Nov 2010 18:22:54 +0000 (UTC) Received: by wyb34 with SMTP id 34so2118060wyb.13 for ; Sat, 06 Nov 2010 11:22:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received:date :x-google-sender-auth:message-id:subject:from:to:content-type; bh=r6fCTfoEPwOS/rcztMzL3NKIHUbcBrlWu3hgr+hM7Lw=; b=fl9ug253Y8Tugy+ihSemWDFMBxLdKqSZ6VW4BDYYKMggFaQULIgd+DDdxo4yvwRl4p N5+WHpRiKqVGLczh42vYl8/dp9InXCRD1CHMrN4XE1xBo9MH4Xk6k5Uo+5wrLJiXSzWT 98xZMQFEQ+twf2gl0jgdnHx0wX/SJ52yVAuug= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:content-type; b=NrtfWk7Q9tBAxza+Pm6tllufLnsulfhStVMXh4Dp1z7roi8vv8xL5w6wJnoEh+ezCy X6qFemVSBLXOiT4iN3SObDSgkUamRvHaa7buzVeIuRn2jt69hk2TzdIDgg7ZoHkMugFI yIpgdy+Vl4ONH/0qWiDthk+o/J8MyGyeZc0UY= MIME-Version: 1.0 Received: by 10.216.7.210 with SMTP id 60mr2551760wep.30.1289067773562; Sat, 06 Nov 2010 11:22:53 -0700 (PDT) Sender: yanegomi@gmail.com Received: by 10.216.198.27 with HTTP; Sat, 6 Nov 2010 11:22:53 -0700 (PDT) Date: Sat, 6 Nov 2010 11:22:53 -0700 X-Google-Sender-Auth: wolnXNXqWnQI59fkYUsWgEdAS5I Message-ID: From: Garrett Cooper To: hackers@freebsd.org Content-Type: multipart/mixed; boundary=0016364c7576bc10170494667abf Cc: Subject: [PATCH] Simplify uart_bus_pci_probe X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2010 18:22:55 -0000 --0016364c7576bc10170494667abf Content-Type: text/plain; charset=ISO-8859-1 Some of the logic could have been simplified in the probe. The proposed patch makes the detection process a tad bit more straightforward. Comments, review (and maybe a commit :P) are more than welcome :). Thanks! -Garrett --0016364c7576bc10170494667abf Content-Type: application/octet-stream; name="uart-bus-probe-minor-cleanup.patch" Content-Disposition: attachment; filename="uart-bus-probe-minor-cleanup.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gg6tkewo0 SW5kZXg6IHN5cy9kZXYvdWFydC91YXJ0X2J1c19wY2kuYwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzeXMvZGV2 L3VhcnQvdWFydF9idXNfcGNpLmMJKHJldmlzaW9uIDIxNDg1NykKKysrIHN5cy9kZXYvdWFydC91 YXJ0X2J1c19wY2kuYwkod29ya2luZyBjb3B5KQpAQCAtMTUwLDE0ICsxNTAsMTMgQEAKIAlzYyA9 IGRldmljZV9nZXRfc29mdGMoZGV2KTsKIAogCWlkID0gdWFydF9wY2lfbWF0Y2goZGV2LCBwY2lf bnM4MjUwX2lkcyk7Ci0JaWYgKGlkICE9IE5VTEwpIHsKLQkJc2MtPnNjX2NsYXNzID0gJnVhcnRf bnM4MjUwX2NsYXNzOwotCQlnb3RvIG1hdGNoOworCWlmIChpZCA9PSBOVUxMKSB7CisJCS8qIEFk ZCBjaGVja3MgZm9yIG5vbi1uczgyNTAgSURzIGhlcmUuICovCisJCXJldHVybiAoRU5YSU8pOwog CX0KLQkvKiBBZGQgY2hlY2tzIGZvciBub24tbnM4MjUwIElEcyBoZXJlLiAqLwotCXJldHVybiAo RU5YSU8pOwogCi0gbWF0Y2g6CisJc2MtPnNjX2NsYXNzID0gJnVhcnRfbnM4MjUwX2NsYXNzOwor CiAJaWYgKGlkLT5kZXNjKQogCQlkZXZpY2Vfc2V0X2Rlc2MoZGV2LCBpZC0+ZGVzYyk7CiAJcmV0 dXJuICh1YXJ0X2J1c19wcm9iZShkZXYsIDAsIGlkLT5yY2xrLCBpZC0+cmlkLCAwKSk7Cg== --0016364c7576bc10170494667abf--