From owner-svn-src-head@freebsd.org Mon Jul 23 07:02:01 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EC97E104143E; Mon, 23 Jul 2018 07:02:00 +0000 (UTC) (envelope-from lstewart@freebsd.org) Received: from lauren.room52.net (lauren.room52.net [45.63.28.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1FF6096F59; Mon, 23 Jul 2018 07:02:00 +0000 (UTC) (envelope-from lstewart@freebsd.org) Received: by lauren.room52.net (Postfix) with ESMTPSA id 683D62A2DB; Mon, 23 Jul 2018 17:01:47 +1000 (AEST) Subject: Re: svn commit: r336596 - in head/sys/netinet: . cc To: Matt Macy , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201807220537.w6M5bwTh005574@repo.freebsd.org> From: Lawrence Stewart Openpgp: preference=signencrypt Autocrypt: addr=lstewart@freebsd.org; prefer-encrypt=mutual; keydata= xsFNBFNq7K8BEADQFhZprR6joPIvqFonlsbZ0M72rkzHkCtGzk+hiE/TZh8df32VaGhXvgAH yP9ictqRai6lYRhO5LyjwR4ysBu4jAZlLCwWWBMY8l2JjuOohsv2+87+hQy+F1nVcPYuNJ4O Eqvqmi/RTU2+kZYGT2kbsSYVWiCUqwzSNWsbVZ8Sw1+ds2e380655Cstm+Ewn3gmX/wXPn3Y 22M+h5KRj3yDn8aJ439lUTcVDQ+Dah/7h4DTn3cXfZdKFSb3HEoiwPh78R3dyQGOQgYnJ3Fp KfKu5gRlXMyB1+6wUBh7G1henvYFrN+HClr+z1fBmsm22Lb7LLs/g6p0FtWslnNxA2CvIC9I Q1nbBoA0bKji/f0S3K7LlAIv/scUqPChfp1EkBvkTOek9N0znzcVCwJTjRjfS0uu6TMWuMXr qpCCrGKonN3gdqKW9pdWmn33kDt0GaESIPOgIRwBk8Ak9/j9Hd/vdtyHab1GKGJTZfIvnJB6 xVy/zwBhUIK/h5dboYqYZds+Ky5g+j+Q4j4bsKdgwjlrRO+eGQTCjRcZoiE0M2PZGK/dt/eS zuHWv0l6r7NkQXn5RBU+5JpdzECyyolKoBrDhHMDdI+Cc3KeQfMSkftKV7UwkScoplI86pLg yKHNxyrmqp3NTE04yxpY1KlEAUv3I/lnkikpj6j1PzGXyReMewARAQABzSpMYXdyZW5jZSBB LiBTdGV3YXJ0IDxsc3Rld2FydEBmcmVlYnNkLm9yZz7CwYAEEwEKACoCGwMFCRLMAwAFCwkI BwMFFQoJCAsFFgMCAQACHgECF4AFAlNq7/0CGQEACgkQmlC8/PQNmwmFSQ/+MpZl3Ysk1D8o FzhmuL5gHyMKWhM6lFGgRVzYW219CyJlxw/twkrdTjZ8YQBTCNnjOLg4ecV+0RQGsRzczfnW 1faBGEOC9CDInwuL00M+sybbiAylotEI54yR+ey0MRcCMuP1+y4LoHLZsCoOOa3PgR5ZrTUq 3Zlq2Zfhq9dq/zrdorWyGxrynlrmZFMqkf1F3ZsHkIvyOkfoJ8+icf/nAcbzsNJP7JMYE1fP PbqbLTR2jRSbHFOu9J1+3yumA5WNbTvHwEgOmxqA20XtGxlpwXXciWWzTN2RJ3EFqCjCiTFC mtYt9/zelkOnLncVQ9s1JHbs6vr4sYNST8bA9LvGOn2BZMDmECoazHfdmM3Q+hcnPYDX8W5h FKqgV049gQZItdZpMuSQ5xgx3K2EkwI5e63XK+SNcC/PUrmbmsAHHhwlrDbBy9LQ6DFQ5uf+ yX3J3+4f4MqSRNQJ4GaLIJXz1lII+CZ3iSEVIJyFMYK2eFlxxo1g26g2USSC0gxxyL4vuz9v GHk90aGPnz6ci0JZiTcBaXr7ObdZoHgDxKjWOq8Mg0juVj5S7Dcwa3vulf5N0Iq0hFffxfoM AAy6Pa+OxKVP6sz1VltTflM73ZqVM+30FLe96iAXzhe/Ku+zI19mJ/87ZKo/5b1lKgDu3II6 dV3IwSQFrV/S0lZEsYBOMw3OwU0EU2rsrwEQALlqsHLKoqF/jfV6O3Nn9MY8r9qeO5tc7jWA lg04uM83itX/E+1ci/V2EqVmsTQFEq2TdGzhxSU1FzoKRxJrsP4dSbazOK54xiXhWMA0fMOL DkM94DXlJwV1+9aamfHshcEHdp6V6nV6YIG7lDD0RDLeTeEtMaK+nSHPWN6beJpRBdLNP+/k 9jtW4Jw/sFXSD1vq7Eb871d9sxY31LijqR+6AJrQ0vJmSH6b8gpr23pslU2f/9utQPFT6tqH H2ZoQoIyGYjyWv6IlYS33/9Idl/A8Zdcsk+aelK/1gzhKwMxvJM7dLCckS8Ir6OTl/72bMZ0 Kb/bFDx0OVPZYhOu53SfUqy8eqhy7KIN6iOgd0mn4rH9+FiJuONq0hMe+Q2NVP7392CRGXXc zgTTwcVc3Nm4zAmEF0h/JpWZWN/AjA9+8zetMnCFjivkr68DGZHLyhbgj+TGan56cTayLLvY Zc/KVfAsI3nGmwMrQhysXZo9JdHPGJwBfTqZOsTDUbrcT4DbU56/1xt3/zpoajnJu+RcfLSd k1TXWzly/BZY60TxewDWxK0f10MzZd7mzidFdvyZKEL6lTkwzZ/kAaqLy4inpqdkicskg020 +kqKxlaCHPFedXLbwfMTthi67jwO8+ZOA7/QWChPL6bmNgZlK7VMHoi7uu+vwCgeh/H3xrMH ABEBAAHCwWUEGAEKAA8FAlNq7K8CGwwFCRLMAwAACgkQmlC8/PQNmwkOWQ//Xxuo/LWfNlqI lsvpnlPgEhVaDQX3vhuru/nMiZ7wq0eTmCD011eHw8wIaF7aOjs6zKM8sf/TpfF30V3GAQSL MpzeebSHWvBfN+XQSgMmwzgrKeQd6kTUf1I501rlzX0vz2NrUqUxktaLMZd6K/1hu7smDHEx fX8SZddz124QpjQJlmCZ0ewFKJ+bMz9W3prdCwV45Gu+glWYnREIXnMd1sXtbQMiu4Z+3CTG VOXmDj14lM3KnO2Vuc6IZTf9LeEeXM5Kvy4JCH4PK3DVInv+1e7KWqFo8KIapUumLxpGHg4c OG+3LTpLg+HTFiuSKqutZU2MDjp49/YdYAGLCEHgQ4rAUWqPNLzva+fbcHIuV/RpjJd6amNC LvtjsizvpE78TzACDtUV8mAHxrVXyrukvHHl+kJVfBH0XpKXxVT1aup+O4eBj5celCNaHF2z m2nKdJW/zjO8lr17Z1q/AxFgHb0blaKNqrpauKC3QUaHjbQEKxTxQXebKrfBdhDg/nG3Qiw9 4NYb/n84KIZMgzXN9OqoOlKgiaLDJ7ijH359GQAhl3UB1Nezfg0BcuxGORlkC063279ilBkE Pw5TRO/8gJH0+We+2unIqUZyHj4P4SLk2xXeyJxqoH+WUNCJBK3IItBQYLb2v0vsutbT193j xwpvFODEWa5OVDC+bcpRp1M= Message-ID: <932986e5-ee47-fdc9-abb8-dd0b26dcfe6a@freebsd.org> Date: Mon, 23 Jul 2018 17:01:46 +1000 User-Agent: Not your concern MIME-Version: 1.0 In-Reply-To: <201807220537.w6M5bwTh005574@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jul 2018 07:02:01 -0000 On 22/07/2018 15:37, Matt Macy wrote: > Author: mmacy > Date: Sun Jul 22 05:37:58 2018 > New Revision: 336596 > URL: https://svnweb.freebsd.org/changeset/base/336596 > > Log: > NULL out cc_data in pluggable TCP {cc}_cb_destroy > > When ABE was added (rS331214) to NewReno and leak fixed (rS333699) , it now has > a destructor (newreno_cb_destroy) for per connection state. Other congestion > controls may allocate and free cc_data on entry and exit, but the field is > never explicitly NULLed if moving back to NewReno which only internally > allocates stateful data (no entry contstructor) resulting in a situation where > newreno_cb_destory might be called on a junk pointer. > > - NULL out cc_data in the framework after calling {cc}_cb_destroy > - free(9) checks for NULL so there is no need to perform not NULL checks > before calling free. > - Improve a comment about NewReno in tcp_ccalgounload > > This is the result of a debugging session from Jason Wolfe, Jason Eggleston, > and mmacy@ and very helpful insight from lstewart@. > > Submitted by: Kevin Bowling > Reviewed by: lstewart > Sponsored by: Limelight Networks > Differential Revision: https://reviews.freebsd.org/D16282 Pointy hat to: lstewart Apologies for the bug and thanks for fixing. Cheers, Lawrence