From owner-freebsd-sysinstall@FreeBSD.ORG Wed Aug 4 18:41:50 2010 Return-Path: Delivered-To: freebsd-sysinstall@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BE66D1065677 for ; Wed, 4 Aug 2010 18:41:50 +0000 (UTC) (envelope-from dteske@vicor.com) Received: from postoffice.vicor.com (postoffice.vicor.com [69.26.56.53]) by mx1.freebsd.org (Postfix) with ESMTP id 3D8E08FC1B for ; Wed, 4 Aug 2010 18:41:49 +0000 (UTC) Received: from [208.206.78.30] (port=36516 helo=dt.vicor.com) by postoffice.vicor.com with esmtpsa (SSLv3:RC4-MD5:128) (Exim 4.71) (envelope-from ) id 1OgiuQ-0003UN-D2; Wed, 04 Aug 2010 11:41:48 -0700 From: Devin Teske To: Bruce Cran Content-Type: text/plain Organization: Vicor, Inc Date: Wed, 04 Aug 2010 11:41:45 -0700 Message-Id: <1280947306.19910.541.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.0.2 (2.0.2-41.el4) Content-Transfer-Encoding: 7bit X-Scan-Signature: 88db2959e544eeecca737f26d1e2c941 X-Scan-Host: postoffice.vicor.com Cc: freebsd-sysinstall@freebsd.org, brucec@freebsd.org Subject: slattach still in RELENG_8 X-BeenThere: freebsd-sysinstall@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Sysinstall Work List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Aug 2010 18:41:50 -0000 Hi Bruce, et. al., For network.c (src/usr.sbin/sysinstall/network.c), we appear to have a tagging issue. In version 1.55, I see that you've removed PPP/SLIP code (very nice -- originally started out this e-mail with a request to remove erroneous call to `slattach' which is no longer available in 8.x but was pleasantly surprised to find that the deed had already been done by you 2.5 weeks ago). However, I am seeing that the call to `slattach' still exists in RELENG_8, RELENG_8_1, RELENG_8_1_0_RELEASE, RELENG_8_0, and RELENG_8_0_0_RELEASE. Yet... the CVS comment for the commit of version 1.55 of network.c in MAIN/HEAD which you entered does indeed indicate that the lack of `slattach' (used in mediaInitNetwork) should propagate to all 8.x tags. Your CVS comment for 1.55: "FreeBSD 8 doesn't support kernel PPP or SLIP; remove code for configuring and installing via such devices from sysinstall." -brucec I am just curious... Is a branching of network.c in the works for the remaining FreeBSD-8.x tags? I only ask because I'm doing a top-down remediation of sysinstall(8)'s use of external executables in RELENG_8 and found that `slattach' does not exist yet is still conditionally called. -- Cheers, Devin Teske -> CONTACT INFORMATION <- Business Solutions Consultant II FIS - fisglobal.com 510-735-5650 Mobile 510-621-2038 Office 510-621-2020 Office Fax 909-477-4578 Home/Fax devin.teske@fisglobal.com -> LEGAL DISCLAIMER <- This message contains confidential and proprietary information of the sender, and is intended only for the person(s) to whom it is addressed. Any use, distribution, copying or disclosure by any other person is strictly prohibited. If you have received this message in error, please notify the e-mail sender immediately, and delete the original message without making a copy. -> END TRANSMISSION <-