From nobody Thu Oct 5 15:10:18 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S1Zk22Zwrz4vjdr; Thu, 5 Oct 2023 15:10:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S1Zk21rzkz4XQG; Thu, 5 Oct 2023 15:10:18 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696518618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aeuFRYsHaV/oLsA7bbrBQS0+gIsRYWOgL+P2vvkCrFU=; b=kY1XecLFDzVtb3xp8Bzj63qBPCV1Q2KcKkWLwvkZoNUkV398xhg/CzROWAHmQ+RsBv+Qb5 kGQhVSkEzMJfpYzJzX9gn5yErqAa8KZb2fgSz0gWeHP8btBMIBhNAvFQ6Uq96q3030sW0f mn6I9hxYgcQPkXuY7tZDh8YNvEVuNhdAElM+lkYr6vlYxc1n32rHb8ruvlAgHtKRTJNQNq locYUZfVcKbETMuysIror/lztfNNxQyw0MWp7xVflBsPlL+gRSR12taioc51QMbwTBbVlv XjkF40iThQAF2/TMMJUAAiwgS936YkLcDUj6IDZTIti+8viAEpYUJpmk17cXcQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696518618; a=rsa-sha256; cv=none; b=eGIh2luzwqOj1JbBzqdfLooFXPg4pdVcaQuQCPD30XGjKod1sYY6Oy7PD3KXC6r7epRqqQ AgiHVFpddYoMVd27fRPX7sXkiiLCuCE6Yr/ZtY4iaTugJmrt4T2rouCBK9wJf983bsOevG 3VazR3kw67XuAto+zZ0F9qW7BEXeDXW/r3mzp/UKN0o/Ko0LBw5ZFzGqV5TPVRXpJPEKjl NOO4X1ODHU566XK6/DGceokCCX0OZuXGk0/KHuZvWHyp9hdtG2TJK4SYcjBWmlZ54ucoKZ WzfosnTwOkqnI/zYer9gIGdEmjjNF3mmvWgzYSWlwzTkcQcg9Wgp+4Qoz2CwHA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696518618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aeuFRYsHaV/oLsA7bbrBQS0+gIsRYWOgL+P2vvkCrFU=; b=Zsd40zD7maDSIEH7wY8R7mY5EO45GHi6ECcogS3g1kkhZVEA+dIL/7DKzjMNoD9UhbkEN5 18Uq0E26nk4ZqOaXHn09AWmzN1AdL+3EeysZgVvA8C3Usdy2EV2s30pkCKi6yXPvNJhW9P l0j0U6BKytqOSOGqBLvciqoUQNFg/CpEXgKp6HQtsrsYNxKQ7nEAJ/2KE08IjSsF8JRLv0 Cqyg0Ug9LinjOb9S/22DOSO2zPASKXF195l7u76/laH99r76fQ6GDRIQRJwtdRC4Dv/yBg f5OgPh0rdkex51q4ehuNPRTw4tejJQPAscjWd9AGMiJySGadx3BduQFMzVyY5w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S1Zk20y19z1PZ6; Thu, 5 Oct 2023 15:10:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 395FAIoF071380; Thu, 5 Oct 2023 15:10:18 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 395FAIM2071377; Thu, 5 Oct 2023 15:10:18 GMT (envelope-from git) Date: Thu, 5 Oct 2023 15:10:18 GMT Message-Id: <202310051510.395FAIM2071377@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 901d81c3e0f4 - releng/14.0 - hdac: Defer interrupt allocation in hdac_attach() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.0 X-Git-Reftype: branch X-Git-Commit: 901d81c3e0f43cb0e4e10bb42ab9f0a71cfcda0a Auto-Submitted: auto-generated The branch releng/14.0 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=901d81c3e0f43cb0e4e10bb42ab9f0a71cfcda0a commit 901d81c3e0f43cb0e4e10bb42ab9f0a71cfcda0a Author: Mark Johnston AuthorDate: 2023-09-27 12:23:58 +0000 Commit: Mark Johnston CommitDate: 2023-10-05 14:01:19 +0000 hdac: Defer interrupt allocation in hdac_attach() hdac_attach() registers an interrupt handler before allocating various driver resources which are accessed by the interrupt handler. On some platforms we observe what appear to be spurious interrupts upon a cold boot, resulting in panics. Partially work around the problem by deferring irq allocation until after other resources are allocated. I think this is not a complete solution, but is correct and sufficient to work around the problems reported in the PR. Approved by: re (gjb) PR: 268393 Tested by: Alexander Sherikov Tested by: Oleh Hushchenkov MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D41883 (cherry picked from commit 015daf5221f7588b9258fe0242cee09bde39fe21) (cherry picked from commit 1e8737f4e884fdf4b966056662e4e6003d3379d9) --- sys/dev/sound/pci/hda/hdac.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sys/dev/sound/pci/hda/hdac.c b/sys/dev/sound/pci/hda/hdac.c index 422f7f930ea5..2cf9239499af 100644 --- a/sys/dev/sound/pci/hda/hdac.c +++ b/sys/dev/sound/pci/hda/hdac.c @@ -1270,9 +1270,6 @@ hdac_attach(device_t dev) /* Allocate resources */ result = hdac_mem_alloc(sc); - if (result != 0) - goto hdac_attach_fail; - result = hdac_irq_alloc(sc); if (result != 0) goto hdac_attach_fail; @@ -1347,6 +1344,10 @@ hdac_attach(device_t dev) hdac_corb_init(sc); hdac_rirb_init(sc); + result = hdac_irq_alloc(sc); + if (result != 0) + goto hdac_attach_fail; + /* Defer remaining of initialization until interrupts are enabled */ sc->intrhook.ich_func = hdac_attach2; sc->intrhook.ich_arg = (void *)sc;