From owner-svn-src-head@FreeBSD.ORG Mon Sep 21 11:08:41 2009 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 74F661065676 for ; Mon, 21 Sep 2009 11:08:41 +0000 (UTC) (envelope-from serenity@exscape.org) Received: from ch-smtp01.sth.basefarm.net (ch-smtp01.sth.basefarm.net [80.76.149.212]) by mx1.freebsd.org (Postfix) with ESMTP id 015EB8FC1F for ; Mon, 21 Sep 2009 11:08:40 +0000 (UTC) Received: from c83-253-248-99.bredband.comhem.se ([83.253.248.99]:45303 helo=mx.exscape.org) by ch-smtp01.sth.basefarm.net with esmtp (Exim 4.68) (envelope-from ) id 1Mpgkf-0008B8-5k; Mon, 21 Sep 2009 13:08:15 +0200 Received: from [192.168.1.5] (macbookpro [192.168.1.5]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mx.exscape.org (Postfix) with ESMTPSA id 58660FD80D; Mon, 21 Sep 2009 13:08:10 +0200 (CEST) Mime-Version: 1.0 (Apple Message framework v1076) Content-Type: text/plain; charset=us-ascii; format=flowed; delsp=yes From: Thomas Backman In-Reply-To: <20090908194311.GB32690@lor.one-eyed-alien.net> Date: Mon, 21 Sep 2009 13:08:08 +0200 Content-Transfer-Encoding: 7bit Message-Id: <5A148FA5-4B30-46AF-8A65-1B5E18F43C8B@exscape.org> References: <200907241503.n6OF3ATP013228@svn.freebsd.org> <20090829201228.00005860@unknown> <20090904221432.GC82231@lor.one-eyed-alien.net> <20090906044700.5208ba62@gluon.draftnet> <20090908194311.GB32690@lor.one-eyed-alien.net> To: Brooks Davis X-Mailer: Apple Mail (2.1076) X-Originating-IP: 83.253.248.99 X-Scan-Result: No virus found in message 1Mpgkf-0008B8-5k. X-Scan-Signature: ch-smtp01.sth.basefarm.net 1Mpgkf-0008B8-5k 581733450da24a49939a30dbde33fa78 Cc: Bruce Cran , svn-src-head@FreeBSD.org Subject: Re: svn commit: r195843 - in head: lib/libkvm sys/kern sys/sys X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Sep 2009 11:08:41 -0000 On Sep 8, 2009, at 9:43 PM, Brooks Davis wrote: > On Sun, Sep 06, 2009 at 04:47:00AM +0100, Bruce Cran wrote: >> On Fri, 4 Sep 2009 17:14:32 -0500 >> Brooks Davis wrote: >> >>> On Sat, Aug 29, 2009 at 08:12:28PM +0100, Bruce Cran wrote: >>>> On Fri, 24 Jul 2009 15:03:10 +0000 (UTC) >>>> Brooks Davis wrote: >>>> >>>>> Author: brooks >>>>> Date: Fri Jul 24 15:03:10 2009 >>>>> New Revision: 195843 >>>>> URL: http://svn.freebsd.org/changeset/base/195843 >>>>> >>>>> Log: >>>>> Revert the changes to struct kinfo_proc in r194498. Instead, >>>>> fill in up to 16 (KI_NGROUPS) values and steal a bit from >>>>> ki_cr_flags (all bits currently unused) to indicate overflow with >>>>> the new flag KI_CRF_GRP_OVERFLOW. >>>>> >>>>> This fixes procstat -s. >>>>> >>>>> Approved by: re (kib) >>>> >>>> Hi Brooks, >>>> >>>> This checkin appears to have broken crash dump support: the bcopy >>>> in >>>> kvm_proc.c crashes when running "ps -ax -M /var/crash/vmcore.x >>>> -N /boot/kernel/kernel", apparently because ucred.cr_groups isn't >>>> valid. Does it need converted using KVM_READ first? >>> >>> Sorry for the delay, I believe you are correct we need to use >>> kvm_read >>> here instead of the bcopy. Do you still have a core handy you can >>> test a patch against? The following should do it. >> >> The patch has fixed the crash, and data is now returned too. > > Thanks for testing! I've committed the patch and will MFC in the next > week or so. MFC coming up? The patch fixes the segfault for me as well, and this should *really* make it into 8.0. Regards, Thomas