From nobody Sat Jun 27 13:13:01 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gnXz34tVmz6jXkK; Sat, 27 Jun 2026 13:13:03 +0000 (UTC) (envelope-from des@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gnXz34Fltz3MW0; Sat, 27 Jun 2026 13:13:03 +0000 (UTC) (envelope-from des@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782565983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4oEBLnSmnAiTCwT9NB2b7aDWv7lo4A9Ejp/fonMQJW8=; b=CADbvP95SmB6W+MMYUSI08QDiHh+RVR8nubDkUIehSuDpamAf7m1NDO48/2l/lycFYz+jw Bj+yYNWO7l06Bfre4+/6D8YjVYUUOyIx2LdZqp0UzZC2MygSMGP374GgkosldiyPGL5c7K 7uqfWOJSDX7y3ErkFMSrhtMBzIRkZ/gII6oQ+bWZv94S2X77ztNCd6VXSmV0A7zM3upvwC hMY6iF7YPeo2VqszLQAde2teQTTfc/J36mJxvGeKx1Hd7Nj5VWg+bywagvWKkHiBD6Whmj rJa69LcSudhUHIs6MhRPGCW0lLC4rawggMcbmcvfj1M8FvD+7oOX7ZvH9YbRHQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782565983; a=rsa-sha256; cv=none; b=IIjvZQ5bNNpsEQ/K67p8wpoyh5hvsjnWoP+Rxwti0b6iK+Oj1RyLuggmz3qZs9nsdILAXn PJSMaqvHXKydxTSi9Bjj/tCOgYJ8XZGTDx3rBhZ7wD2EZzr3rpL9gEFTduGZlrc9RzrT4e pzrPQEEdDkCRKwK295LFv4JD3NlDTsPdOkBJ1EvObThcYaWK+sn+CymD1OAmfYYQu6H7Na XrLGq7Jq7zB40F78UV/QnuTp/HxBFB4b0Nxr+tv0DNJdFdy69l3z/9WnPLqXOA1zah0q51 pmyhoibWeaeEbctIZm/fwL3QrkTaBnXVu+UQGMTQdk1uxN/X3jldbN4s73U4Ew== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782565983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4oEBLnSmnAiTCwT9NB2b7aDWv7lo4A9Ejp/fonMQJW8=; b=mhADBgBsqBaIUCDnWVC00OCDNMWvRoY1gokWkqrlx56eGmYeEZ06tC1CfEH9PbFLb3T/NI Y7BCJr2k+F7El+GqiEzKNvyCkrczoeHYXujJO9L/GZVknX0nNRzgcI6n9ors6ZZduz/J/7 7qfdxt7WeQ5lmv2c2qjkqIGjXB+9jo07UedskfM0jsGT304t+9c8LjUn1qHHmIGvHu9+5R 5317rSCr5r2t7s7DkjSykx4jyiMGbzQ52oXxrRdmoFBK+FDBmXKlse5nbWOtxfSehfYtHI vRazIXSa7v0UJDwJBe0o+OqLa/IAXc+q+BM+KJPiX6pGpuBLCANhvvKnqPJ9CA== Received: from ltc.des.dev (unknown [92.183.55.143]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: des/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gnXz31T8yz122C; Sat, 27 Jun 2026 13:13:03 +0000 (UTC) (envelope-from des@freebsd.org) Received: by ltc.des.dev (Postfix, from userid 1001) id B36C4A9467; Sat, 27 Jun 2026 15:13:01 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: "Siva Mahadevan" Cc: , , Subject: Re: git: 5b8c28adb829 - main - ping/tests: expect bell chars from stderr after initial status In-Reply-To: (Siva Mahadevan's message of "Sat, 27 Jun 2026 09:04:14 -0400") References: <6a3f0534.34ab3.7098834f@gitrepo.freebsd.org> <86bjcwdxet.fsf@ltc.des.dev> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Sat, 27 Jun 2026 15:13:01 +0200 Message-ID: <867bnkdt42.fsf@ltc.des.dev> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable "Siva Mahadevan" writes: > If it is incorrect, my apologies, but I'm not sure in which way. I wrote > this from what I understood from the comments in the associated > reviews[0][1]. You ignored this: https://ron-dev.freebsd.org/FreeBSD/src/pulls/50#issuecomment-853 and this: https://reviews.freebsd.org/D57884 and misrepresented the parts you did not ignore. 1) ping was incorrectly mixing buffered and unbuffered I/O on the same descriptor (standard output), which is not permitted by the standard and results in undeterministic output. 2) My first commit to ping had the side effect of changing the ordering of ping's output in the conditions established by the test, causing the test to fail. This is not a bug in my commit, it is a bug in the test, which assumes deterministic output from a non-determinstic program. 4) My second commit changed ping to guarantee determinstic output in all cases. 5) Your commit changed the test to expect the output which ping now deterministically produces. > Can you suggest a better commit message? And I'm not sure it warrants a > revert and re-commit. The current message is pure fiction, reverting and re-committing is the only way to correct the record. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org