From owner-freebsd-hackers@freebsd.org Fri Nov 3 02:43:46 2017 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1013AE693F4; Fri, 3 Nov 2017 02:43:46 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B61AD735BF; Fri, 3 Nov 2017 02:43:45 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 02803160F6; Fri, 3 Nov 2017 02:43:45 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 2C4D58E5E; Fri, 3 Nov 2017 02:43:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id Hm_3bVnWKcT5; Fri, 3 Nov 2017 02:43:41 +0000 (UTC) Content-Type: text/plain; charset=utf-8 DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 497448E5B Mime-Version: 1.0 (1.0) Subject: Re: Head build unsafe for /etc today From: Bryan Drewery X-Mailer: iPhone Mail (15A402) In-Reply-To: <20171103023651.GC34123@FreeBSD.org> Date: Thu, 2 Nov 2017 19:43:20 -0700 Cc: Steve Kargl , FreeBSD Toolchain , freebsd-hackers , FreeBSD Current Content-Transfer-Encoding: quoted-printable Message-Id: References: <3045EEBF-09E6-4209-B54F-2F95394DBA82@FreeBSD.org> <20171103014907.GA88522@troutmask.apl.washington.edu> <68BECDA4-C182-436E-854C-C3B19ABB4373@FreeBSD.org> <20171103022327.GA88659@troutmask.apl.washington.edu> <20171103023651.GC34123@FreeBSD.org> To: Glen Barber X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Nov 2017 02:43:46 -0000 > On Nov 2, 2017, at 19:36, Glen Barber wrote: >=20 >> On Thu, Nov 02, 2017 at 07:23:27PM -0700, Steve Kargl wrote: >> On Thu, Nov 02, 2017 at 07:08:50PM -0700, Bryan Drewery wrote: >>>> On Nov 2, 2017, at 18:49, Steve Kargl wrote: >>>> You're making changes to the build infrastructure and you're >>>> not properly testing it before committing? This is beyond >>>> pointyhat material.=20 >>>=20 >>> I ran 2 universes, dozens of buildworlds and buildkernels, >>> dozens of installworld and installkernel, several xdev and >>> native-xtools, several full DIRDEPS_BUILD builds and bootstraps, >>> ran subdir builds, ran subdir cleans, tested several targets together, >>> ran various special case tests for submakes, played around with a >>> ton of MAKEOBJDIRPREFIX cases, handled and tested symlinked objdirs >>> special, ran it through my work repro a few times, did special >>> testing in rescue/, and had a volunteer test release. In the process >>> I found a bmake bug, GPL_DTC build bug and several others I don=E2=80=99= t >>> recall from the bus. >>>=20 >>> What I missed was the =E2=80=9Cclean=E2=80=9D buildworld because I forgo= t it >>> even exists. I=E2=80=99ve wanted to remove it for a year. I also forgot t= o >>> test buildenv. >>>=20 >>=20 >> If you did all the above under META_MODE, then no you did not=20 >> buildworld and buildkernel and all the other stuff you claim. >> If your first step isn't 'cd /usr/obj ; rm -rf *' or equivalent >> in whatever jail you use, then you're not properly testing=20 >> your changes to the build infrastructure. >=20 > I did test this, personally, and missed it. To be fair you didn=E2=80=99t test the AUTO_OBJ piece but did test the much m= ore riskier changes to objdir handling. Thanks for that. >> As you have demonstrated, >> Makefile, Makefile.inc1, and the *.mk files are sufficiently=20 >> complicated that proper testing should be done, and proper=20 >> testing means one doesn't takes shortcuts. >>=20 >=20 > Mistakes happen. Things sometimes get accidentally missed. >=20 > Glen >=20